[{"id":18280,"web_url":"https://patchwork.libcamera.org/comment/18280/","msgid":"","date":"2021-07-23T11:44:39","subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nCC'ing Sakari. For future kernel patches, you can use the\n./scripts/get_maintainer.pl script in the kernel sources to get a list\nof appropriate recipients. The list should be taken with a grain of salt\nthough, it has a tendency to return too many recipients. For this\nparticular patch, for instance, it also recommends Mauro and LKML.\nWhether to CC the subsystem maintainer on every patch depends on the\nsubsystem (it's more common for small ones than big ones) and on the\nmaintainer's preferences. LKML is a catch-all mailing list with very\nhigh traffic, and when more appropriate venues exist for patches, I\nusually recommend skipping LKML.\n\nOn Fri, Jul 23, 2021 at 04:52:33PM +0530, Umang Jain wrote:\n> The range for analog gain mentioned in the datasheet is [0, 480].\n> The real gain formula mentioned in the datasheet is:\n> \n> \tGain = 512 / (512 – X)\n> \n> Hence, values larger than 511 clearly makes no sense. The gain\n> register field is also documented to be of 9-bits in the datasheet.\n> \n> Certainly, it is enough to infer that, the kernel driver currently\n> advertises an arbitrary analog gain max. Fix it by rectifying the\n> value as per the data sheet i.e. 480.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> drivers/media/i2c/imx258.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c\n> index 4e695096e5d0..81cdf37216ca 100644\n> --- a/drivers/media/i2c/imx258.c\n> +++ b/drivers/media/i2c/imx258.c\n> @@ -47,7 +47,7 @@\n> /* Analog gain control */\n> #define IMX258_REG_ANALOG_GAIN\t\t0x0204\n> #define IMX258_ANA_GAIN_MIN\t\t0\n> -#define IMX258_ANA_GAIN_MAX\t\t0x1fff\n> +#define IMX258_ANA_GAIN_MAX\t\t480\n> #define IMX258_ANA_GAIN_STEP\t\t1\n> #define IMX258_ANA_GAIN_DEFAULT\t\t0x0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20FA8C0109\n\tfor ;\n\tFri, 23 Jul 2021 11:44:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 822E96877A;\n\tFri, 23 Jul 2021 13:44:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED3D468536\n\tfor ;\n\tFri, 23 Jul 2021 13:44:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 631F73F2;\n\tFri, 23 Jul 2021 13:44:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cPe1by62\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627040681;\n\tbh=JHz/Csmf+EYiqA9Bpq8OJoQQuG3Ke8RVgt/voA3SM2c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cPe1by62EgaF/Rck2LOGzJjR6EhSQ1lXVxu3gNb0186l0a2TrY1KRvr5Spp3A1PC/\n\tNWuoSrL5XyY8c6Yf6Al8TPbiWsixWBusIvLN+E1hrMuQfJhmwy2HIhzouwiLQ+vjJe\n\txU/UaIuEgMvKcy+JNDoeu7gBi34fZLwD98ImfV8k=","Date":"Fri, 23 Jul 2021 14:44:39 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210723112233.1361319-1-umang.jain@ideasonboard.com>\n\t<20210723112233.1361319-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210723112233.1361319-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tSakari Ailus , linux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18282,"web_url":"https://patchwork.libcamera.org/comment/18282/","msgid":"","date":"2021-07-23T11:52:06","subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Jul 23, 2021 at 02:44:40PM +0300, Laurent Pinchart wrote:\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> CC'ing Sakari. For future kernel patches, you can use the\n> ./scripts/get_maintainer.pl script in the kernel sources to get a list\n> of appropriate recipients. The list should be taken with a grain of salt\n> though, it has a tendency to return too many recipients. For this\n> particular patch, for instance, it also recommends Mauro and LKML.\n> Whether to CC the subsystem maintainer on every patch depends on the\n> subsystem (it's more common for small ones than big ones) and on the\n> maintainer's preferences. LKML is a catch-all mailing list with very\n> high traffic, and when more appropriate venues exist for patches, I\n> usually recommend skipping LKML.\n\nAnd expanding the CC list further to include Dave (for his contribution\nto the discussion), and Krzysztof and Bingbu (for their contributions to\nthe driver, as reported by git log).\n\n> On Fri, Jul 23, 2021 at 04:52:33PM +0530, Umang Jain wrote:\n> > The range for analog gain mentioned in the datasheet is [0, 480].\n> > The real gain formula mentioned in the datasheet is:\n> > \n> > \tGain = 512 / (512 – X)\n> > \n> > Hence, values larger than 511 clearly makes no sense. The gain\n> > register field is also documented to be of 9-bits in the datasheet.\n> > \n> > Certainly, it is enough to infer that, the kernel driver currently\n> > advertises an arbitrary analog gain max. Fix it by rectifying the\n> > value as per the data sheet i.e. 480.\n> > \n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > drivers/media/i2c/imx258.c | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c\n> > index 4e695096e5d0..81cdf37216ca 100644\n> > --- a/drivers/media/i2c/imx258.c\n> > +++ b/drivers/media/i2c/imx258.c\n> > @@ -47,7 +47,7 @@\n> > /* Analog gain control */\n> > #define IMX258_REG_ANALOG_GAIN\t\t0x0204\n> > #define IMX258_ANA_GAIN_MIN\t\t0\n> > -#define IMX258_ANA_GAIN_MAX\t\t0x1fff\n> > +#define IMX258_ANA_GAIN_MAX\t\t480\n> > #define IMX258_ANA_GAIN_STEP\t\t1\n> > #define IMX258_ANA_GAIN_DEFAULT\t\t0x0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A110EC322C\n\tfor ;\n\tFri, 23 Jul 2021 11:52:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A56F687A4;\n\tFri, 23 Jul 2021 13:52:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 43FC868544\n\tfor ;\n\tFri, 23 Jul 2021 13:52:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C59C13F2;\n\tFri, 23 Jul 2021 13:52:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"puMm8H8H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627041129;\n\tbh=NSabhji7YvZjuH+LZ+iegX7uKb156EqOfIsXeL8vn04=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=puMm8H8HNJKOS42l8y9hyERfvzIembmYI5kudvY8jkXcKDOQs7qeVEqsPUC2mUH4L\n\twdIM+DCnCLMqKSKEDYXv+fumqflpmtfVTWJp1zcNvazVdnpMDe5R5NpaOd27hVF7K8\n\t8a4C6kNBPRd11R6SJEmi2jbK5rL0jIgs3K54XUZ0=","Date":"Fri, 23 Jul 2021 14:52:06 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210723112233.1361319-1-umang.jain@ideasonboard.com>\n\t<20210723112233.1361319-3-umang.jain@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Krzysztof Kozlowski ,\n\tlibcamera-devel@lists.libcamera.org, \n\tSakari Ailus ,\n\tBingbu Cao , linux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18283,"web_url":"https://patchwork.libcamera.org/comment/18283/","msgid":"","date":"2021-07-23T12:36:10","subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Hi Umang and Laurent\n\nOn Fri, 23 Jul 2021 at 12:52, Laurent Pinchart\n wrote:\n>\n> On Fri, Jul 23, 2021 at 02:44:40PM +0300, Laurent Pinchart wrote:\n> > Hi Umang,\n> >\n> > Thank you for the patch.\n> >\n> > CC'ing Sakari. For future kernel patches, you can use the\n> > ./scripts/get_maintainer.pl script in the kernel sources to get a list\n> > of appropriate recipients. The list should be taken with a grain of salt\n> > though, it has a tendency to return too many recipients. For this\n> > particular patch, for instance, it also recommends Mauro and LKML.\n> > Whether to CC the subsystem maintainer on every patch depends on the\n> > subsystem (it's more common for small ones than big ones) and on the\n> > maintainer's preferences. LKML is a catch-all mailing list with very\n> > high traffic, and when more appropriate venues exist for patches, I\n> > usually recommend skipping LKML.\n>\n> And expanding the CC list further to include Dave (for his contribution\n> to the discussion), and Krzysztof and Bingbu (for their contributions to\n> the driver, as reported by git log).\n>\n> > On Fri, Jul 23, 2021 at 04:52:33PM +0530, Umang Jain wrote:\n> > > The range for analog gain mentioned in the datasheet is [0, 480].\n> > > The real gain formula mentioned in the datasheet is:\n> > >\n> > > Gain = 512 / (512 – X)\n> > >\n> > > Hence, values larger than 511 clearly makes no sense. The gain\n> > > register field is also documented to be of 9-bits in the datasheet.\n> > >\n> > > Certainly, it is enough to infer that, the kernel driver currently\n> > > advertises an arbitrary analog gain max. Fix it by rectifying the\n> > > value as per the data sheet i.e. 480.\n> > >\n> > > Signed-off-by: Umang Jain \n> >\n> > Reviewed-by: Laurent Pinchart \n\nThat certainly follows the datasheet that I have.\n\nGains up to code 480 work as expected. Up to 496 seems to work, but\ngoing beyond that causes issues. Adopting the documented maximum value\nis the safest approach.\n\nReviewed-by: Dave Stevenson \n\n> >\n> > > ---\n> > > drivers/media/i2c/imx258.c | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c\n> > > index 4e695096e5d0..81cdf37216ca 100644\n> > > --- a/drivers/media/i2c/imx258.c\n> > > +++ b/drivers/media/i2c/imx258.c\n> > > @@ -47,7 +47,7 @@\n> > > /* Analog gain control */\n> > > #define IMX258_REG_ANALOG_GAIN 0x0204\n> > > #define IMX258_ANA_GAIN_MIN 0\n> > > -#define IMX258_ANA_GAIN_MAX 0x1fff\n> > > +#define IMX258_ANA_GAIN_MAX 480\n> > > #define IMX258_ANA_GAIN_STEP 1\n> > > #define IMX258_ANA_GAIN_DEFAULT 0x0\n> > >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03185C0109\n\tfor ;\n\tFri, 23 Jul 2021 12:36:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35196687A4;\n\tFri, 23 Jul 2021 14:36:30 +0200 (CEST)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CD4368544\n\tfor ;\n\tFri, 23 Jul 2021 14:36:28 +0200 (CEST)","by mail-wm1-x332.google.com with SMTP id k4so716602wms.3\n\tfor ;\n\tFri, 23 Jul 2021 05:36:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rnE/2g8D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=bFm9gyGphXZlqoA8OlM0mMcdR/uVY+OZViqTdiCQk0k=;\n\tb=rnE/2g8D4iBvvScaBleJSSJrdoE5I1imntcO2/81o5RkIwa+/WMjTHlJPDKmFVB2qn\n\tOj0xRPDs4fsRTI8KVT9UUPn8g1+YWaTNAbxzAce4N0MKGCWScf3TXz30KTU6XIpwYZxm\n\tKfFtX2d09ihdz3nSTlA559xaeGP5G/P5TB8A4BZfw2WJFd8XF4k0mwBJ9KKQyloY9MIk\n\tkfUrDgJOtLrwyOrOHaeVDiuu273nJXt7/2P8J4uylQs74LbKymkc0IH8MiBf3LTBkJFY\n\t69I4GVTk9+dRjeXe1w8ZVHRi+IX8Ui0g4LXIv/32W09XNHRl2Vm/MoXLtpmyu5Y3FAZQ\n\tTdNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=bFm9gyGphXZlqoA8OlM0mMcdR/uVY+OZViqTdiCQk0k=;\n\tb=nHZ5goSSRuOvw1KbTYTcuzeq4pZv+XsbzXUe68rEF4rBWd4ztr1DQ4v5+WSMlYmlpa\n\tKQJKDU3nv2X3X8QsziX/ckN8asuPJnQxUK6BU+iczx3Gc0IURP39tm96fkHtKiihXjWY\n\t856IzFCZtVFT1qTFT9cu6+fEep6PWaYXHP7j/60XtLYoQ0DhEuGgcID7lQ/F/N5JF71u\n\twyx3gJrJ4I23E/cMaaMVxhZaoQwQANIPHNB0OQypCNa2cx9H0P2RvGtOZ7R1n/rkXTEQ\n\txKKJPWlbD/c1kIJh7Ou+TVLHJPUvT5VzmHhay6sNwzsIcxLuSa9SKzu2KoCXjZtjKxJ1\n\tFEYg==","X-Gm-Message-State":"AOAM531dYFiVCBfY5tmx4pVw+vR2g3Mx8ZiNsef29KR1MqHeoDpjS/mQ\n\txBJq7A21yo9K8jtAw3Qjh8eKsDBB8ALgIljQIvJZsA==","X-Google-Smtp-Source":"ABdhPJyHmqakFgCAcjg+RaZe8WTZJ5MXvHMD64pqxv6s8etl7rMKaLLcEO/og+bwo+sLjmGrAFAuVNxWat/qNf5iKv8=","X-Received":"by 2002:a05:600c:354e:: with SMTP id\n\ti14mr4392294wmq.96.1627043787958; \n\tFri, 23 Jul 2021 05:36:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20210723112233.1361319-1-umang.jain@ideasonboard.com>\n\t<20210723112233.1361319-3-umang.jain@ideasonboard.com>\n\t\n\t","In-Reply-To":"","From":"Dave Stevenson ","Date":"Fri, 23 Jul 2021 13:36:10 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Krzysztof Kozlowski ,\n\tlibcamera devel ,\n\tSakari Ailus ,\n\tBingbu Cao , \n\tLinux Media Mailing List ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18284,"web_url":"https://patchwork.libcamera.org/comment/18284/","msgid":"","date":"2021-07-23T12:29:54","subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","submitter":{"id":91,"url":"https://patchwork.libcamera.org/api/people/91/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 23/07/2021 13:52, Laurent Pinchart wrote:\n> On Fri, Jul 23, 2021 at 02:44:40PM +0300, Laurent Pinchart wrote:\n>> Hi Umang,\n>>\n>> Thank you for the patch.\n>>\n>> CC'ing Sakari. For future kernel patches, you can use the\n>> ./scripts/get_maintainer.pl script in the kernel sources to get a list\n>> of appropriate recipients. The list should be taken with a grain of salt\n>> though, it has a tendency to return too many recipients. For this\n>> particular patch, for instance, it also recommends Mauro and LKML.\n>> Whether to CC the subsystem maintainer on every patch depends on the\n>> subsystem (it's more common for small ones than big ones) and on the\n>> maintainer's preferences. LKML is a catch-all mailing list with very\n>> high traffic, and when more appropriate venues exist for patches, I\n>> usually recommend skipping LKML.\n> \n> And expanding the CC list further to include Dave (for his contribution\n> to the discussion), and Krzysztof and Bingbu (for their contributions to\n> the driver, as reported by git log).\n> \n\nI don't work with this sensor anymore and I don't have it. I trust the\nchange is reasonable, but I did not check it in documentation.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 523C5C322C\n\tfor ;\n\tFri, 23 Jul 2021 12:52:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D06516877A;\n\tFri, 23 Jul 2021 14:52:52 +0200 (CEST)","from mail-ej1-f54.google.com (mail-ej1-f54.google.com\n\t[209.85.218.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFE5368536\n\tfor ;\n\tFri, 23 Jul 2021 14:29:56 +0200 (CEST)","by mail-ej1-f54.google.com with SMTP id gt31so3255550ejc.12\n\tfor ;\n\tFri, 23 Jul 2021 05:29:56 -0700 (PDT)","from [192.168.8.102] ([86.32.47.9])\n\tby smtp.googlemail.com with ESMTPSA id\n\tlu1sm10593596ejb.89.2021.07.23.05.29.55\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 23 Jul 2021 05:29:55 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=40HDoNrg7c/qfx3DsP+OtTChWRBlH+y4nzbI7cSuhxY=;\n\tb=MlkkEW/G2ejmDsw//Th2fVSCsLE7h8cTrhsDW8fgAfd5AyycM3hVyT6EKLaFzEdVwe\n\tOixU7CYSlcuiEHX2AaKpzbj6QQ2I9SI3RK50BvU4ipjYCz1X5gKrpETP1Che1fYWv32B\n\tJdx3nbDJPmUyta4GsEHr3+0Q/L8hr1AwX0GEcQLc9LGSy5jIrx3ZY/PgxpxYUSK8fUHJ\n\t42bPoYgbAG2lcaede9e35GHRs0gDdn8r4Q47/REjdg93io/fmwiptNTR15g423O1OmLc\n\tULM3z7jQXPkhUvO3xJj4iVJ52CHkgXM91lzQFgLfFFz2na2HgFyDsessIg6aGvFd9OIg\n\tJwfg==","X-Gm-Message-State":"AOAM533F9tx7D77Z8Rf85nDmCGEtI5PoiTs/e7Iy7OPwpxWAB7qnbK9I\n\t0ZSh9uGZAgewUpPhWJXMpT0=","X-Google-Smtp-Source":"ABdhPJyDhurE/O32sB8wcEwbc7RgPGs8tKxGazrD4yXCnThcM099ZyNAe+da65n0w8z7Os5o4OkKWA==","X-Received":"by 2002:a17:906:34ca:: with SMTP id\n\th10mr4539616ejb.41.1627043396467; \n\tFri, 23 Jul 2021 05:29:56 -0700 (PDT)","To":"Laurent Pinchart ,\n\tUmang Jain ","References":"<20210723112233.1361319-1-umang.jain@ideasonboard.com>\n\t<20210723112233.1361319-3-umang.jain@ideasonboard.com>\n\t\n\t","From":"Krzysztof Kozlowski ","Message-ID":"","Date":"Fri, 23 Jul 2021 14:29:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Mailman-Approved-At":"Fri, 23 Jul 2021 14:52:52 +0200","Subject":"Re: [libcamera-devel] [PATCH 2/2] media: imx258: Limit the max\n\tanalogue gain to 480","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, Bingbu Cao , \n\tSakari Ailus , linux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]