[{"id":18376,"web_url":"https://patchwork.libcamera.org/comment/18376/","msgid":"<20210727093948.lksws6pa4bi42msw@uno.localdomain>","date":"2021-07-27T09:39:48","subject":"Re: [libcamera-devel] [PATCH] cam: options: Restore std::cerr\n\tadjustement field","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Jul 23, 2021 at 07:23:53AM +0300, Laurent Pinchart wrote:\n> The std::cerr adjustment is set to std::left to print the usage text.\n> Restore it to its original value when done, to avoid affecting the\n> caller.\n\nSeems sane!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/options.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 33bc512e6571..4f7e869144c8 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -453,7 +453,7 @@ void KeyValueParser::usage(int indent)\n> \t\t\t\targument += \"]\";\n> \t\t}\n>\n> -\t\tstd::cerr << std::setw(indent) << std::left << argument;\n> +\t\tstd::cerr << std::setw(indent) << argument;\n>\n> \t\tfor (const char *help = option.help, *end = help; end;) {\n> \t\t\tend = strchr(help, '\\n');\n> @@ -994,7 +994,12 @@ void OptionsParser::usage()\n>\n> \tstd::cerr << \"Options:\" << std::endl;\n>\n> +\tstd::ios_base::fmtflags f(std::cerr.flags());\n> +\tstd::cerr << std::left;\n> +\n> \tusageOptions(options_, indent);\n> +\n> +\tstd::cerr.flags(f);\n> }\n>\n> void OptionsParser::usageOptions(const std::list