[{"id":18292,"web_url":"https://patchwork.libcamera.org/comment/18292/","msgid":"<66c1829c-2627-713f-a896-70fc3835d2ef@ideasonboard.com>","date":"2021-07-23T14:16:08","subject":"Re: [libcamera-devel] [PATCH] cam: Initialize CamApp::loopUsers_","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn 7/23/21 9:34 AM, Laurent Pinchart wrote:\n> The CamApp loopUsers_ member variable isn't initialized, which results\n> in random execution of the event loop. Fix it.\n>\n> Fixes: caa6ffacb2fc (\"cam: Reorganize run() function and merge the two event loops\")\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \nTested-by: Umang Jain \n> ---\n> src/cam/main.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index f9a90672a474..34cbc3229563 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -56,6 +56,7 @@ private:\n> CamApp *CamApp::app_ = nullptr;\n> \n> CamApp::CamApp()\n> +\t: loopUsers_(0)\n> {\n> \tCamApp::app_ = this;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45254C322C\n\tfor ;\n\tFri, 23 Jul 2021 14:16:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DD05687A9;\n\tFri, 23 Jul 2021 16:16:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF13368537\n\tfor ;\n\tFri, 23 Jul 2021 16:16:14 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.103])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF1CE3F2;\n\tFri, 23 Jul 2021 16:16:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T7AAG1cK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627049774;\n\tbh=HX/rZF8OlYDZxNIu/Q8646LHwa955DDqY45QH8BfZdE=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=T7AAG1cKFRncmXYR8Jtg+L5NY5HSpBadBGZ2BtVn+tCKM637nVZQN5WmTJUf7/+S+\n\tSWcjtrdgcfXzclDPsfIU6mgkDdjT22OunvkLIifaEtUJ30K3/lkG1Rg32uHTpdFnUg\n\tnT8sUPFoBDvJWV40dis9+GwbszlwTtxWSXJhMIug=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210723040421.1898-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<66c1829c-2627-713f-a896-70fc3835d2ef@ideasonboard.com>","Date":"Fri, 23 Jul 2021 19:46:08 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210723040421.1898-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] cam: Initialize CamApp::loopUsers_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]