[{"id":177,"web_url":"https://patchwork.libcamera.org/comment/177/","msgid":"<19095570.TyhPWjFbXB@avalon>","date":"2019-01-02T11:11:30","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: media_device: Make\n\tgetEntityByName() const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wednesday, 2 January 2019 13:00:16 EET Jacopo Mondi wrote:\n> The function does not modify the instance state. Mark it as const.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\nPlease push.\n\n> ---\n> src/libcamera/include/media_device.h | 2 +-\n> src/libcamera/media_device.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/include/media_device.h\n> b/src/libcamera/include/media_device.h index d787be3..9db18bb 100644\n> --- a/src/libcamera/include/media_device.h\n> +++ b/src/libcamera/include/media_device.h\n> @@ -34,7 +34,7 @@ public:\n> \tconst std::string devnode() const { return devnode_; }\n> \n> \tconst std::vector &entities() const { return entities_; }\n> -\tMediaEntity *getEntityByName(const std::string &name);\n> +\tMediaEntity *getEntityByName(const std::string &name) const;\n> \n> private:\n> \tstd::string driver_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 9fbc5a7..25d1825 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -244,7 +244,7 @@ int MediaDevice::populate()\n> * \\return The entity with \\a name\n> * \\return nullptr if no entity with \\a name is found\n> */\n> -MediaEntity *MediaDevice::getEntityByName(const std::string &name)\n> +MediaEntity *MediaDevice::getEntityByName(const std::string &name) const\n> {\n> \tfor (MediaEntity *e : entities_)\n> \t\tif (e->name() == name)\n> --\n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B57360B0C\n\tfor ;\n\tWed, 2 Jan 2019 12:10:30 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1FA3505;\n\tWed, 2 Jan 2019 12:10:29 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546427429;\n\tbh=zegTSE27+GTc+NM0jrECrNIT2FCodOVz6qY6sWgG9eQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gKO8FitHgCzUeof9sqS8tv3UuAaPJsLq9VJdPyfvJ8ZSaPhoSnE69wfvFkW1FYg5z\n\t/Hz7wpVciX6YWCXxFInV/HDtMssytectFgyKiU0JS3PlVoud/Hg5FeZ8LBFfkqvrm7\n\tZGSYyY46v2gq+3b4VQcBxZFHpIoeSJv+5RU5RQBg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 02 Jan 2019 13:11:30 +0200","Message-ID":"<19095570.TyhPWjFbXB@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190102110016.5489-2-jacopo@jmondi.org>","References":"<20190102110016.5489-1-jacopo@jmondi.org>\n\t<20190102110016.5489-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: media_device: Make\n\tgetEntityByName() const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 02 Jan 2019 11:10:30 -0000"}}]