[{"id":18306,"web_url":"https://patchwork.libcamera.org/comment/18306/","msgid":"","date":"2021-07-24T07:24:45","subject":"Re: [libcamera-devel] [RFC PATCH 10/17] libcamera: pipeline:\n\tsimple: Migrate to Camera::Private","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2021-07-23 07:00:29 +0300, Laurent Pinchart wrote:\n> As part of the effort to remove the CameraData class, migrate the\n> pipeline handler-specific camera data from CameraData to the\n> Camera::Private class.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 25 ++++++++++++------------\n> 1 file changed, 13 insertions(+), 12 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 43af3fafa475..81d342a3fa73 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -147,7 +147,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> \n> } /* namespace */\n> \n> -class SimpleCameraData : public CameraData\n> +class SimpleCameraData : public Camera::Private\n> {\n> public:\n> \tSimpleCameraData(SimplePipelineHandler *pipe,\n> @@ -213,7 +213,7 @@ private:\n> \t * reference to the camera data, store a new reference to the camera.\n> \t */\n> \tstd::shared_ptr camera_;\n> -\tconst SimpleCameraData *data_;\n> +\tSimpleCameraData *data_;\n\nThis looks odd, I can't figure out why const is dropped. Looking back \nshould not Camera::Private::pipe() have a const version? It should be OK \nto get the pipe for RO operations.\n\n> \n> \tconst SimpleCameraData::Configuration *pipeConfig_;\n> \tbool needConversion_;\n> @@ -246,10 +246,9 @@ protected:\n> private:\n> \tstatic constexpr unsigned int kNumInternalBuffers = 3;\n> \n> -\tSimpleCameraData *cameraData(const Camera *camera)\n> +\tSimpleCameraData *cameraData(Camera *camera)\n> \t{\n> -\t\treturn static_cast(\n> -\t\t\tPipelineHandler::cameraData(camera));\n> +\t\treturn static_cast(camera->_d());\n> \t}\n> \n> \tstd::vector locateSensors();\n> @@ -274,7 +273,7 @@ private:\n> SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> \t\t\t\t unsigned int numStreams,\n> \t\t\t\t MediaEntity *sensor)\n> -\t: CameraData(pipe), streams_(numStreams)\n> +\t: Camera::Private(pipe), streams_(numStreams)\n> {\n> \tint ret;\n> \n> @@ -355,7 +354,8 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> \n> int SimpleCameraData::init()\n> {\n> -\tSimplePipelineHandler *pipe = static_cast(pipe_);\n> +\tSimplePipelineHandler *pipe =\n> +\t\tstatic_cast(this->pipe());\n> \tSimpleConverter *converter = pipe->converter();\n> \tint ret;\n> \n> @@ -480,7 +480,8 @@ int SimpleCameraData::setupLinks()\n> int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> \t\t\t\t V4L2Subdevice::Whence whence)\n> {\n> -\tSimplePipelineHandler *pipe = static_cast(pipe_);\n> +\tSimplePipelineHandler *pipe =\n> +\t\tstatic_cast(this->pipe());\n> \tint ret;\n> \n> \t/*\n> @@ -581,7 +582,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> \t}\n> \n> \t/* Adjust the requested streams. */\n> -\tSimplePipelineHandler *pipe = static_cast(data_->pipe_);\n> +\tSimplePipelineHandler *pipe = static_cast(data_->pipe());\n> \tSimpleConverter *converter = pipe->converter();\n> \n> \t/*\n> @@ -1046,10 +1047,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\t std::inserter(streams, streams.end()),\n> \t\t\t [](Stream &stream) { return &stream; });\n> \n> +\t\tconst std::string &id = data->sensor_->id();\n> \t\tstd::shared_ptr camera =\n> -\t\t\tCamera::create(new Camera::Private(this),\n> -\t\t\t\t data->sensor_->id(), streams);\n> -\t\tregisterCamera(std::move(camera), std::move(data));\n> +\t\t\tCamera::create(data.release(), id, streams);\n> +\t\tregisterCamera(std::move(camera), nullptr);\n> \t\tregistered = true;\n> \t}\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41E4FC0109\n\tfor ;\n\tSat, 24 Jul 2021 07:24:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC31B687A9;\n\tSat, 24 Jul 2021 09:24:48 +0200 (CEST)","from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D90C168540\n\tfor ;\n\tSat, 24 Jul 2021 09:24:46 +0200 (CEST)","by mail-lj1-x236.google.com with SMTP id e5so4436532ljp.6\n\tfor ;\n\tSat, 24 Jul 2021 00:24:46 -0700 (PDT)","from localhost (h-46-59-88-219.A463.priv.bahnhof.se.\n\t[46.59.88.219]) by smtp.gmail.com with ESMTPSA id\n\tf26sm3569264ljp.137.2021.07.24.00.24.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 24 Jul 2021 00:24:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"F/P8e4W3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=n9JzCpDIsPlJHhJLrbb3lFOrFOEKAouzik1BNODZ6gA=;\n\tb=F/P8e4W3nnnz7LqeQHcoxHcQUg3+WcrU+crM5W/biwbQCaEKdNFyKdLUl/fJ5SD05o\n\t+UzuBUX20SyAwaO0bJEtYXFz+48zpEVESDYaObKdO9U6ghCd9TniE1dFNhhuNw0yZE5C\n\tM8T/6C4FbRq7SnsWVYwwgWfOdeu1n5cfJ8qiahANX4KihBefHOR0XZyW2mccVVPyebIB\n\tHwNt57ZvoNHNRiEOYn5t+cmc50XUvnRa0t8wMo/VhIeAHk7J42PmbG/xmHobmArmKVo1\n\tpptx0S9+HO+RdEEUD1LfR/tNG5nN+eUI6zIZnuwndyffy8Rmryc7KR8jtWNWgk9+KOzy\n\t2KWA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=n9JzCpDIsPlJHhJLrbb3lFOrFOEKAouzik1BNODZ6gA=;\n\tb=ahvQ1cj9NZXsB37Ui0tzT9bEPhB9qckBWAhAdgB9ByVTrY3gO77h6QoiBlVPDTuisf\n\t4gL03UEQ+yZCDTmUw73JDpiF1qAvmbMrkiPufCcpN+yvBnNwK/28JlKllXazrSvamqn9\n\tvlgMNW/hAxKxN4OfMv7xYQR/+RohFUNX2kPy1TWu0S6emErtN3j4vQW9/TZI4cYEDxpb\n\tKAdgJqX8lcZZ6NalIp8qTzLhSZeURhGkhbDGzAFliG0u1ATSl12/npvJtzzrmmYDe0qW\n\tX9Zfs5PJBby8Mbp93ls8/Zstp80ypsipO+li465qBgqjp4bQfHwSsh4ngzOopiIiToi0\n\tyxWQ==","X-Gm-Message-State":"AOAM531IkGTVYkYtkNSjPPB6ShaZLHaxM4vlRUrX7NSkyi1c/Cul57u4\n\t05tNNiD/nfRRDttnkFhFlJmafQ==","X-Google-Smtp-Source":"ABdhPJzQn9e9Oc10RSZJt/nIf+zUKu1UMu5Jgn/SHGRLdWudgKvJZ7wr63LnIi7RyT7kY9Ea7tLQSg==","X-Received":"by 2002:a2e:a317:: with SMTP id\n\tl23mr5726712lje.410.1627111486246; \n\tSat, 24 Jul 2021 00:24:46 -0700 (PDT)","Date":"Sat, 24 Jul 2021 09:24:45 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>\n\t<20210723040036.32346-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210723040036.32346-11-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 10/17] libcamera: pipeline:\n\tsimple: Migrate to Camera::Private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18318,"web_url":"https://patchwork.libcamera.org/comment/18318/","msgid":"","date":"2021-07-24T19:34:06","subject":"Re: [libcamera-devel] [RFC PATCH 10/17] libcamera: pipeline:\n\tsimple: Migrate to Camera::Private","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Sat, Jul 24, 2021 at 09:24:45AM +0200, Niklas Söderlund wrote:\n> On 2021-07-23 07:00:29 +0300, Laurent Pinchart wrote:\n> > As part of the effort to remove the CameraData class, migrate the\n> > pipeline handler-specific camera data from CameraData to the\n> > Camera::Private class.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 25 ++++++++++++------------\n> > 1 file changed, 13 insertions(+), 12 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 43af3fafa475..81d342a3fa73 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -147,7 +147,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> > \n> > } /* namespace */\n> > \n> > -class SimpleCameraData : public CameraData\n> > +class SimpleCameraData : public Camera::Private\n> > {\n> > public:\n> > \tSimpleCameraData(SimplePipelineHandler *pipe,\n> > @@ -213,7 +213,7 @@ private:\n> > \t * reference to the camera data, store a new reference to the camera.\n> > \t */\n> > \tstd::shared_ptr camera_;\n> > -\tconst SimpleCameraData *data_;\n> > +\tSimpleCameraData *data_;\n> \n> This looks odd, I can't figure out why const is dropped. Looking back \n> should not Camera::Private::pipe() have a const version? It should be OK \n> to get the pipe for RO operations.\n\nThe following changes end up being needed:\n\ndiff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 44242332a52f..a20ace75fe8b 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -30,6 +30,7 @@ public:\n \t~Private();\n\n \tPipelineHandler *pipe() { return pipe_.get(); }\n+\tconst PipelineHandler *pipe() const { return pipe_.get(); }\n\n \tstd::list queuedRequests_;\n \tControlInfoMap controlInfo_;\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 72a42dbeb3d3..dec4efbfe993 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -361,11 +361,15 @@ Camera::Private::~Private()\n }\n\n /**\n- * \\fn Camera::Private::pipe()\n+ * \\fn Camera::Private::pipe() const\n * \\brief Retrieve the pipeline handler related to this camera\n * \\return The pipeline handler for this camera\n */\n\n+/**\n+ * \\fn Camera::Private::pipe()\n+ * \\copydoc Camera::Private::pipe() const\n+ */\n /**\n * \\var Camera::Private::queuedRequests_\n * \\brief The list of queued and not yet completed request\ndiff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex b5e34c4cd0c5..6a92e89a1867 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -278,7 +278,7 @@ SizeRange SimpleConverter::sizes(const Size &input)\n\n std::tuple\n SimpleConverter::strideAndFrameSize(const PixelFormat &pixelFormat,\n-\t\t\t\t const Size &size)\n+\t\t\t\t const Size &size) const\n {\n \tV4L2DeviceFormat format;\n \tformat.fourcc = m2m_->capture()->toV4L2PixelFormat(pixelFormat);\ndiff --git a/src/libcamera/pipeline/simple/converter.h b/src/libcamera/pipeline/simple/converter.h\nindex 276a2a291c21..960c102091be 100644\n--- a/src/libcamera/pipeline/simple/converter.h\n+++ b/src/libcamera/pipeline/simple/converter.h\n@@ -40,7 +40,7 @@ public:\n \tSizeRange sizes(const Size &input);\n\n \tstd::tuple\n-\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size);\n+\tstrideAndFrameSize(const PixelFormat &pixelFormat, const Size &size) const;\n\n \tint configure(const StreamConfiguration &inputCfg,\n \t\t const std::vector> &outputCfg);\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 8594520f520c..84bc2723f42b 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -213,7 +213,7 @@ private:\n \t * reference to the camera data, store a new reference to the camera.\n \t */\n \tstd::shared_ptr camera_;\n-\tSimpleCameraData *data_;\n+\tconst SimpleCameraData *data_;\n\n \tconst SimpleCameraData::Configuration *pipeConfig_;\n \tbool needConversion_;\n@@ -239,6 +239,7 @@ public:\n \tV4L2VideoDevice *video(const MediaEntity *entity);\n \tV4L2Subdevice *subdev(const MediaEntity *entity);\n \tSimpleConverter *converter() { return converter_.get(); }\n+\tconst SimpleConverter *converter() const { return converter_.get(); }\n\n protected:\n \tint queueRequestDevice(Camera *camera, Request *request) override;\n@@ -582,8 +583,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t}\n\n \t/* Adjust the requested streams. */\n-\tSimplePipelineHandler *pipe = static_cast(data_->pipe());\n-\tSimpleConverter *converter = pipe->converter();\n+\tconst SimplePipelineHandler *pipe = static_cast(data_->pipe());\n+\tconst SimpleConverter *converter = pipe->converter();\n\n \t/*\n \t * Enable usage of the converter when producing multiple streams, as\n\nI'm thinking about storing a pointer to the Camera in\nCameraConfiguration, which will allow accessing the pipeline handler to\nbe accessed through Camera::Private. That's why I didn't want to\nintroduce this change yet.\n\n> > \n> > \tconst SimpleCameraData::Configuration *pipeConfig_;\n> > \tbool needConversion_;\n> > @@ -246,10 +246,9 @@ protected:\n> > private:\n> > \tstatic constexpr unsigned int kNumInternalBuffers = 3;\n> > \n> > -\tSimpleCameraData *cameraData(const Camera *camera)\n> > +\tSimpleCameraData *cameraData(Camera *camera)\n> > \t{\n> > -\t\treturn static_cast(\n> > -\t\t\tPipelineHandler::cameraData(camera));\n> > +\t\treturn static_cast(camera->_d());\n> > \t}\n> > \n> > \tstd::vector locateSensors();\n> > @@ -274,7 +273,7 @@ private:\n> > SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> > \t\t\t\t unsigned int numStreams,\n> > \t\t\t\t MediaEntity *sensor)\n> > -\t: CameraData(pipe), streams_(numStreams)\n> > +\t: Camera::Private(pipe), streams_(numStreams)\n> > {\n> > \tint ret;\n> > \n> > @@ -355,7 +354,8 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe,\n> > \n> > int SimpleCameraData::init()\n> > {\n> > -\tSimplePipelineHandler *pipe = static_cast(pipe_);\n> > +\tSimplePipelineHandler *pipe =\n> > +\t\tstatic_cast(this->pipe());\n> > \tSimpleConverter *converter = pipe->converter();\n> > \tint ret;\n> > \n> > @@ -480,7 +480,8 @@ int SimpleCameraData::setupLinks()\n> > int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> > \t\t\t\t V4L2Subdevice::Whence whence)\n> > {\n> > -\tSimplePipelineHandler *pipe = static_cast(pipe_);\n> > +\tSimplePipelineHandler *pipe =\n> > +\t\tstatic_cast(this->pipe());\n> > \tint ret;\n> > \n> > \t/*\n> > @@ -581,7 +582,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> > \t}\n> > \n> > \t/* Adjust the requested streams. */\n> > -\tSimplePipelineHandler *pipe = static_cast(data_->pipe_);\n> > +\tSimplePipelineHandler *pipe = static_cast(data_->pipe());\n> > \tSimpleConverter *converter = pipe->converter();\n> > \n> > \t/*\n> > @@ -1046,10 +1047,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> > \t\t\t std::inserter(streams, streams.end()),\n> > \t\t\t [](Stream &stream) { return &stream; });\n> > \n> > +\t\tconst std::string &id = data->sensor_->id();\n> > \t\tstd::shared_ptr camera =\n> > -\t\t\tCamera::create(new Camera::Private(this),\n> > -\t\t\t\t data->sensor_->id(), streams);\n> > -\t\tregisterCamera(std::move(camera), std::move(data));\n> > +\t\t\tCamera::create(data.release(), id, streams);\n> > +\t\tregisterCamera(std::move(camera), nullptr);\n> > \t\tregistered = true;\n> > \t}\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 861D9C0109\n\tfor ;\n\tSat, 24 Jul 2021 19:34:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3D6C687AF;\n\tSat, 24 Jul 2021 21:34:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37C0B68536\n\tfor ;\n\tSat, 24 Jul 2021 21:34:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8F333D7;\n\tSat, 24 Jul 2021 21:34:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ATV1mP2f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627155249;\n\tbh=lVFCd7Hw8+W3f5eufM60JcLosz6fjag0pu7Hx7rz+R4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ATV1mP2fCgSnu8I485NgroyNoz0zuwxEzgjTDMbTYpACrb8w5ikf/s2Ta4UllR9sQ\n\tpUvZShMDyrbUo8lSWi2f1DUKm84wBoLgTbvjGNLMVibcy+Ff6GZH4CeNbwaOKJelJU\n\tvuHFwgltdF+8uDPkPbAw/ok7Br2S0A1enbnW5hK4=","Date":"Sat, 24 Jul 2021 22:34:06 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>\n\t<20210723040036.32346-11-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH 10/17] libcamera: pipeline:\n\tsimple: Migrate to Camera::Private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]