[{"id":18303,"web_url":"https://patchwork.libcamera.org/comment/18303/","msgid":"","date":"2021-07-24T07:01:53","subject":"Re: [libcamera-devel] [RFC PATCH 07/17] libcamera: camera: Make\n\tCamera::Private members private","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2021-07-23 07:00:26 +0300, Laurent Pinchart wrote:\n> To prepare for the Camera::Private structure being used by pipeline\n> handlers, turn all its members to private. Members that are useful for\n> pipeline handlers will be made public again, or will be exposed through\n> accessor functions, on a case-by-case basis.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/camera.h | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 9ef5d8ae98a6..b60ed140356a 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -26,6 +26,11 @@ class Camera::Private : public Extensible::Private\n> \tLIBCAMERA_DECLARE_PUBLIC(Camera)\n> \n> public:\n> +\tPrivate(PipelineHandler *pipe, const std::string &id,\n> +\t\tconst std::set &streams);\n> +\t~Private();\n> +\n> +private:\n> \tenum State {\n> \t\tCameraAvailable,\n> \t\tCameraAcquired,\n> @@ -34,10 +39,6 @@ public:\n> \t\tCameraRunning,\n> \t};\n> \n> -\tPrivate(PipelineHandler *pipe, const std::string &id,\n> -\t\tconst std::set &streams);\n> -\t~Private();\n> -\n> \tbool isRunning() const;\n> \tint isAccessAllowed(State state, bool allowDisconnected = false,\n> \t\t\t const char *from = __builtin_FUNCTION()) const;\n> @@ -53,7 +54,6 @@ public:\n> \tstd::set streams_;\n> \tstd::set activeStreams_;\n> \n> -private:\n> \tbool disconnected_;\n> \tstd::atomic state_;\n> };\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9BE0C0109\n\tfor ;\n\tSat, 24 Jul 2021 07:01:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81AA8687A9;\n\tSat, 24 Jul 2021 09:01:56 +0200 (CEST)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27D9868540\n\tfor ;\n\tSat, 24 Jul 2021 09:01:55 +0200 (CEST)","by mail-lf1-x12f.google.com with SMTP id h14so5783071lfv.7\n\tfor ;\n\tSat, 24 Jul 2021 00:01:55 -0700 (PDT)","from localhost (h-46-59-88-219.A463.priv.bahnhof.se.\n\t[46.59.88.219]) by smtp.gmail.com with ESMTPSA id\n\to7sm1696215lfi.59.2021.07.24.00.01.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 24 Jul 2021 00:01:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"hVubukx2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=DMYyCO+8h4UXPv4uUW7tiSunzQh5zXYBoisLDglxDe8=;\n\tb=hVubukx2wD6Eha5CNihiPY83y9P5aiOV28HQiI5et4jOzV6EswuYA8TgM/95U6ZXNW\n\tdcdsAjtMbFxApyaTtzD1ts70GYhWkQ1f6z0/lGP9gfO2s5n8dxwbZiRmFn7xl8xZkzXL\n\tBg/bRJbYtqF9HbsYPoWrmeiCHUvjPpRrnNgLiV5TERQjs8dyj4z+JfX+Vr9byGTZ/umu\n\t9YLZ3R8z+2gShCPZyMc7IE9lgy5Cvp2hGTfBFZAnU9Jm9hfk1K08q9leQlypnXVy3bFD\n\t4F6ScHCbBe9vHC0FHrqNBB4gl8FHQ0f7uraMp68KlZLUD12G/kHTMtf+ScBhrrFCGn+m\n\trleg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=DMYyCO+8h4UXPv4uUW7tiSunzQh5zXYBoisLDglxDe8=;\n\tb=qkqz2ODd5aeMXAO/FdSMMHCZiDcEvsmmMJnT5oW06jdM9L+JFNytk2WkkCqEjkYBZq\n\tKCA4n5cdOiV3NUO4qo8wgYsI8r0/3GWQie87saNEVRlXPWCx1xZVRq8ZJtYp/1Oi0dqD\n\tbM1ZicNpyYA5RYRVayKwzLyyK4cWpfzR/pbl56UMRuc0M7tDYPQ+/ZOBQXTQRuBaJs6m\n\tlmkdH8Ma5G2KhN9gQcZtv0vpW52flAM8s0nkyGKvwL5IbEtRtNxqj0CGHWMF9GLhCfwb\n\tUTWG2AaqhtOfoYYBs0+wNP0xMM5ISpKpAM1901U+xUSQsF7Vvy4MDTMMGl2xyXoPFamC\n\tcCsg==","X-Gm-Message-State":"AOAM532e6QYkQiuaPQh2DtKjbLAoeukClVQfXTb3D6jRnGJcKsfcrU3G\n\t0dZytD2l/rOjGYZg7SwWnBPtCKgsW0391Q==","X-Google-Smtp-Source":"ABdhPJzg373VSm915LTuHw+zeNVe1HHN+LfvBWH3BCo2YZEcEirfX6Oa3aSsZ3AsYeSSaUhI2nExvQ==","X-Received":"by 2002:ac2:51de:: with SMTP id u30mr4187153lfm.70.1627110114600;\n\tSat, 24 Jul 2021 00:01:54 -0700 (PDT)","Date":"Sat, 24 Jul 2021 09:01:53 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>\n\t<20210723040036.32346-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210723040036.32346-8-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 07/17] libcamera: camera: Make\n\tCamera::Private members private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18428,"web_url":"https://patchwork.libcamera.org/comment/18428/","msgid":"<20210729205200.vcnni66mucq4jagl@uno.localdomain>","date":"2021-07-29T20:52:00","subject":"Re: [libcamera-devel] [RFC PATCH 07/17] libcamera: camera: Make\n\tCamera::Private members private","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Fri, Jul 23, 2021 at 07:00:26AM +0300, Laurent Pinchart wrote:\n> To prepare for the Camera::Private structure being used by pipeline\n> handlers, turn all its members to private. Members that are useful for\n> pipeline handlers will be made public again, or will be exposed through\n> accessor functions, on a case-by-case basis.\n\nIt makes easier to follow what happens indeed\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/camera.h | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 9ef5d8ae98a6..b60ed140356a 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -26,6 +26,11 @@ class Camera::Private : public Extensible::Private\n> \tLIBCAMERA_DECLARE_PUBLIC(Camera)\n>\n> public:\n> +\tPrivate(PipelineHandler *pipe, const std::string &id,\n> +\t\tconst std::set &streams);\n> +\t~Private();\n> +\n> +private:\n> \tenum State {\n> \t\tCameraAvailable,\n> \t\tCameraAcquired,\n> @@ -34,10 +39,6 @@ public:\n> \t\tCameraRunning,\n> \t};\n>\n> -\tPrivate(PipelineHandler *pipe, const std::string &id,\n> -\t\tconst std::set &streams);\n> -\t~Private();\n> -\n> \tbool isRunning() const;\n> \tint isAccessAllowed(State state, bool allowDisconnected = false,\n> \t\t\t const char *from = __builtin_FUNCTION()) const;\n> @@ -53,7 +54,6 @@ public:\n> \tstd::set streams_;\n> \tstd::set activeStreams_;\n>\n> -private:\n> \tbool disconnected_;\n> \tstd::atomic state_;\n> };\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88C12C3230\n\tfor ;\n\tThu, 29 Jul 2021 20:51:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F376D687BF;\n\tThu, 29 Jul 2021 22:51:15 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7DB7687BA\n\tfor ;\n\tThu, 29 Jul 2021 22:51:14 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id F1FFC1C0002;\n\tThu, 29 Jul 2021 20:51:13 +0000 (UTC)"],"Date":"Thu, 29 Jul 2021 22:52:00 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210729205200.vcnni66mucq4jagl@uno.localdomain>","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>\n\t<20210723040036.32346-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210723040036.32346-8-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 07/17] libcamera: camera: Make\n\tCamera::Private members private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]