{"id":13093,"url":"https://patchwork.libcamera.org/api/patches/13093/?format=json","web_url":"https://patchwork.libcamera.org/patch/13093/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210723040036.32346-8-laurent.pinchart@ideasonboard.com>","date":"2021-07-23T04:00:26","name":"[libcamera-devel,RFC,07/17] libcamera: camera: Make Camera::Private members private","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b8636fcc83ecf7997b4634118a0d4b650e5378b0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13093/mbox/","series":[{"id":2270,"url":"https://patchwork.libcamera.org/api/series/2270/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2270","date":"2021-07-23T04:00:19","name":"libcamera: Replace CameraData with Camera::Private","version":1,"mbox":"https://patchwork.libcamera.org/series/2270/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13093/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13093/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 061B6C322D\n\tfor ;\n\tFri, 23 Jul 2021 04:00:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4CF8687B7;\n\tFri, 23 Jul 2021 06:00:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52667687AF\n\tfor ;\n\tFri, 23 Jul 2021 06:00:45 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC97F3F2\n\tfor ;\n\tFri, 23 Jul 2021 06:00:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EvXER4A7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627012845;\n\tbh=2dapEB1s8HjLGPfNSyHNQ4skTYwINAySQpEVV8WsSiM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=EvXER4A7Kjifz0F7sN11whkHaLMidGKbC3RJW32Z6mthuAzszOe95A2Q4oz2o2c5y\n\tnvrSau89QDWjX+SO+wtBxYu5rWzUzHf48R2L0d/TkQVk/nV5s8nGhRqYwKRwfm52g9\n\tfasNFOzrQfM/NVVr+b24NQ/aS1csfqJqXYNgA8zI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 23 Jul 2021 07:00:26 +0300","Message-Id":"<20210723040036.32346-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 07/17] libcamera: camera: Make\n\tCamera::Private members private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To prepare for the Camera::Private structure being used by pipeline\nhandlers, turn all its members to private. Members that are useful for\npipeline handlers will be made public again, or will be exposed through\naccessor functions, on a case-by-case basis.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/camera.h | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 9ef5d8ae98a6..b60ed140356a 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -26,6 +26,11 @@ class Camera::Private : public Extensible::Private\n \tLIBCAMERA_DECLARE_PUBLIC(Camera)\n \n public:\n+\tPrivate(PipelineHandler *pipe, const std::string &id,\n+\t\tconst std::set &streams);\n+\t~Private();\n+\n+private:\n \tenum State {\n \t\tCameraAvailable,\n \t\tCameraAcquired,\n@@ -34,10 +39,6 @@ public:\n \t\tCameraRunning,\n \t};\n \n-\tPrivate(PipelineHandler *pipe, const std::string &id,\n-\t\tconst std::set &streams);\n-\t~Private();\n-\n \tbool isRunning() const;\n \tint isAccessAllowed(State state, bool allowDisconnected = false,\n \t\t\t const char *from = __builtin_FUNCTION()) const;\n@@ -53,7 +54,6 @@ public:\n \tstd::set streams_;\n \tstd::set activeStreams_;\n \n-private:\n \tbool disconnected_;\n \tstd::atomic state_;\n };\n","prefixes":["libcamera-devel","RFC","07/17"]}