[{"id":18298,"web_url":"https://patchwork.libcamera.org/comment/18298/","msgid":"","date":"2021-07-24T06:49:20","subject":"Re: [libcamera-devel] [RFC PATCH 02/17] libcamera: base: class:\n\tLink LIBCAMERA_O_PTR to Extensible documentation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2021-07-23 07:00:21 +0300, Laurent Pinchart wrote:\n> The LIBCAMERA_O_PTR macro is part of the Extensible class\n> infrastructure, but doesn't link to it. This makes the generated\n> documentation unclear. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/base/class.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/base/class.cpp b/src/libcamera/base/class.cpp\n> index d0899671ca11..d4f0ac64ad48 100644\n> --- a/src/libcamera/base/class.cpp\n> +++ b/src/libcamera/base/class.cpp\n> @@ -98,8 +98,9 @@ namespace libcamera {\n> * \\def LIBCAMERA_O_PTR()\n> * \\brief Retrieve the public instance corresponding to the private data\n> *\n> - * This macro is used in any member function of the private data class to access\n> - * the public class instance corresponding to the private data.\n> + * This macro is part of the libcamera::Extensible class infrastructure. It may\n> + * be used in any member function of a libcamera::Extensible::Private subclass\n> + * to access the public class instance corresponding to the private data.\n> */\n> \n> /**\n> @@ -139,6 +140,8 @@ namespace libcamera {\n> * protected and private members.\n> *\n> * The PublicClass exposes its Private data pointer through the _d() function.\n> + * In the other direction, the pointer to the PublicClass can be retrieved in\n> + * functions of the Private class using the LIBCAMERA_O_PTR() macro.\n> */\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B3C0C0109\n\tfor ;\n\tSat, 24 Jul 2021 06:49:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC578687A9;\n\tSat, 24 Jul 2021 08:49:23 +0200 (CEST)","from mail-lf1-x131.google.com (mail-lf1-x131.google.com\n\t[IPv6:2a00:1450:4864:20::131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F95D60273\n\tfor ;\n\tSat, 24 Jul 2021 08:49:22 +0200 (CEST)","by mail-lf1-x131.google.com with SMTP id a26so5698907lfr.11\n\tfor ;\n\tFri, 23 Jul 2021 23:49:22 -0700 (PDT)","from localhost (h-46-59-88-219.A463.priv.bahnhof.se.\n\t[46.59.88.219]) by smtp.gmail.com with ESMTPSA id\n\t24sm573026lft.98.2021.07.23.23.49.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 23 Jul 2021 23:49:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"VzweuUK8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=uN4R+sU5YgDHq/w6TgAruWQ/xQPmZjF5v/9N3lW4CE8=;\n\tb=VzweuUK8rcxPNjXU+1zTBhwXDQkdWJcRfoW1T9Vb1LYaqvRwoWxTQnYFHVhZJtBT8R\n\tTL8cIdozOAXVnnOBm+kcryryp40NoTw+X1oHTRz9VoeYp3rsmFE8QeB6PG6ljcKcAgkt\n\t5TtHDVuZcqlzzC3vrkMXJWWTwAh0blilNgwtuIgtfipm9DBjaghAG6UBu7+6qFF3blPs\n\tJOJMN+FZdcdXKPBMkgAmh63r1SNRq7x0pT34FlneVu4M/OddrXqiW8gfvqJ3HbKYFTtC\n\tlCC02UazNoYKZXPShNCcl2GpedtkLGG1MXSGtVbqMBhcZcm5Lf1YzwBRGDCFXxVEyvPE\n\tuH8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=uN4R+sU5YgDHq/w6TgAruWQ/xQPmZjF5v/9N3lW4CE8=;\n\tb=QXBf/0ssNult/9sAJYoRRWvko2hD+hSJbZiz6ttRxbNG3yUfFyf3ZlIyXCxyB+nhhO\n\tDbO9sdOrfsZB8Db17nkVkYJwopezaaRbPRS1sE8ZBBT7E5Ex+Fjx2qIm9KLOIGi4JjX1\n\tmpvisY1xqOMn+yxNvyhXCCWRP9grsPz+4tDtmM37aSzfhvTaTCm/RHbr88sU7LvSSI3t\n\t/RzHdj1esnCC9fP+dlire9jbfWhst9VMIlGjbFc9wu2AReCPBk0KRwPBw07kSQeWe//y\n\teXyfzrXRw8V+k14n2oHimmmi5xdB7MzRfqgJI3QAs2MQj6ksjRlLFuvfDM9ABnM9SahU\n\tRWwg==","X-Gm-Message-State":"AOAM5322ApLCynLcAYJZJsaxKXYzopKdO6L7/EaUueL8txiA06hcEse2\n\tyr8yvqcusIL/kwToKtdsub1oig==","X-Google-Smtp-Source":"ABdhPJxDb60ru60DR+UdzPt0qLtrhWxPtvWrfX033dmxAL+rJlKSM4uRPkitEYVUuEL4LzpK36/+ow==","X-Received":"by 2002:a05:6512:2091:: with SMTP id\n\tt17mr5624863lfr.60.1627109361815; \n\tFri, 23 Jul 2021 23:49:21 -0700 (PDT)","Date":"Sat, 24 Jul 2021 08:49:20 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>\n\t<20210723040036.32346-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20210723040036.32346-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 02/17] libcamera: base: class:\n\tLink LIBCAMERA_O_PTR to Extensible documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18423,"web_url":"https://patchwork.libcamera.org/comment/18423/","msgid":"<20210729201022.akurrnuorxtmm3j5@uno.localdomain>","date":"2021-07-29T20:10:22","subject":"Re: [libcamera-devel] [RFC PATCH 02/17] libcamera: base: class:\n\tLink LIBCAMERA_O_PTR to Extensible documentation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Jul 23, 2021 at 07:00:21AM +0300, Laurent Pinchart wrote:\n> The LIBCAMERA_O_PTR macro is part of the Extensible class\n> infrastructure, but doesn't link to it. This makes the generated\n> documentation unclear. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/base/class.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/base/class.cpp b/src/libcamera/base/class.cpp\n> index d0899671ca11..d4f0ac64ad48 100644\n> --- a/src/libcamera/base/class.cpp\n> +++ b/src/libcamera/base/class.cpp\n> @@ -98,8 +98,9 @@ namespace libcamera {\n> * \\def LIBCAMERA_O_PTR()\n> * \\brief Retrieve the public instance corresponding to the private data\n> *\n> - * This macro is used in any member function of the private data class to access\n> - * the public class instance corresponding to the private data.\n> + * This macro is part of the libcamera::Extensible class infrastructure. It may\n> + * be used in any member function of a libcamera::Extensible::Private subclass\n> + * to access the public class instance corresponding to the private data.\n> */\n>\n> /**\n> @@ -139,6 +140,8 @@ namespace libcamera {\n> * protected and private members.\n> *\n> * The PublicClass exposes its Private data pointer through the _d() function.\n> + * In the other direction, the pointer to the PublicClass can be retrieved in\n> + * functions of the Private class using the LIBCAMERA_O_PTR() macro.\n> */\n>\n> /**\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D74D3C322E\n\tfor ;\n\tThu, 29 Jul 2021 20:09:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25E88687BD;\n\tThu, 29 Jul 2021 22:09:38 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB04D687BA\n\tfor ;\n\tThu, 29 Jul 2021 22:09:36 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 2092C100004;\n\tThu, 29 Jul 2021 20:09:35 +0000 (UTC)"],"Date":"Thu, 29 Jul 2021 22:10:22 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210729201022.akurrnuorxtmm3j5@uno.localdomain>","References":"<20210723040036.32346-1-laurent.pinchart@ideasonboard.com>\n\t<20210723040036.32346-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210723040036.32346-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 02/17] libcamera: base: class:\n\tLink LIBCAMERA_O_PTR to Extensible documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]