{"id":13080,"url":"https://patchwork.libcamera.org/api/patches/13080/?format=json","web_url":"https://patchwork.libcamera.org/patch/13080/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210722232851.747614-7-nfraprado@collabora.com>","date":"2021-07-22T23:28:46","name":"[libcamera-devel,v7,06/11] lc-compliance: Move role to string conversion to its own function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"22ced58018ffceb066fd5e04f3eb8e51588ef864","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/people/84/?format=json","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13080/mbox/","series":[{"id":2269,"url":"https://patchwork.libcamera.org/api/series/2269/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2269","date":"2021-07-22T23:28:40","name":"lc-compliance: Add test to queue more requests than hardware depth","version":7,"mbox":"https://patchwork.libcamera.org/series/2269/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13080/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13080/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D773CC0109\n\tfor ;\n\tThu, 22 Jul 2021 23:29:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B821687AC;\n\tFri, 23 Jul 2021 01:29:37 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05D7E6877B\n\tfor ;\n\tFri, 23 Jul 2021 01:29:37 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2804:14c:1a9:2434:a4c5:aa5e:1d8c:5e2c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 26ECD1F447D0;\n\tFri, 23 Jul 2021 00:29:34 +0100 (BST)"],"From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jul 2021 20:28:46 -0300","Message-Id":"<20210722232851.747614-7-nfraprado@collabora.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210722232851.747614-1-nfraprado@collabora.com>","References":"<20210722232851.747614-1-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 06/11] lc-compliance: Move role to\n\tstring conversion to its own function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel@collabora.com, =?utf-8?q?Andr=C3=A9_Almeida?=\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The functions that generate the test name based on the parameters need\nto convert a StreamRole to a string. Move this to a separate function to\navoid redundancy.\n\nSigned-off-by: Nícolas F. R. A. Prado \n---\n\nNo changes in v7\n\nNo changes in v6\n\nAdded in v5\n\n src/lc-compliance/capture_test.cpp | 21 ++++++++++++---------\n 1 file changed, 12 insertions(+), 9 deletions(-)","diff":"diff --git a/src/lc-compliance/capture_test.cpp b/src/lc-compliance/capture_test.cpp\nindex 949407d3191e..b4807486ee07 100644\n--- a/src/lc-compliance/capture_test.cpp\n+++ b/src/lc-compliance/capture_test.cpp\n@@ -18,6 +18,16 @@ using namespace libcamera;\n const std::vector NUMREQUESTS = { 1, 2, 3, 5, 8, 13, 21, 34, 55, 89 };\n const std::vector ROLES = { Raw, StillCapture, VideoRecording, Viewfinder };\n \n+static const std::string &roleToString(const StreamRole &role)\n+{\n+\tstatic std::map rolesMap = { { Raw, \"Raw\" },\n+\t\t\t\t\t\t\t { StillCapture, \"StillCapture\" },\n+\t\t\t\t\t\t\t { VideoRecording, \"VideoRecording\" },\n+\t\t\t\t\t\t\t { Viewfinder, \"Viewfinder\" } };\n+\n+\treturn rolesMap[role];\n+}\n+\n class CameraHolder\n {\n protected:\n@@ -71,15 +81,8 @@ void SingleStream::TearDown()\n \n std::string SingleStream::nameParameters(const testing::TestParamInfo &info)\n {\n-\tstd::map rolesMap = { { Raw, \"Raw\" },\n-\t\t\t\t\t\t { StillCapture, \"StillCapture\" },\n-\t\t\t\t\t\t { VideoRecording, \"VideoRecording\" },\n-\t\t\t\t\t\t { Viewfinder, \"Viewfinder\" } };\n-\n-\tstd::string roleName = rolesMap[std::get<0>(info.param)];\n-\tstd::string numRequestsName = std::to_string(std::get<1>(info.param));\n-\n-\treturn roleName + \"_\" + numRequestsName;\n+\treturn roleToString(std::get<0>(info.param)) + \"_\" +\n+\t std::to_string(std::get<1>(info.param));\n }\n \n /*\n","prefixes":["libcamera-devel","v7","06/11"]}