[{"id":18295,"web_url":"https://patchwork.libcamera.org/comment/18295/","msgid":"","date":"2021-07-24T05:05:28","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Daniel,\n\nThanks for the patch.\n\nOn 7/23/21 2:06 AM, Daniel Scally wrote:\n> Add camera sensor properties for the OV8865 sensor. This is the world\n> facing camera on most MS Surface platforms.\n>\n> Signed-off-by: Daniel Scally \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 7d8ba9e9..e1b6416b 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -102,6 +102,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t */\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov8865\", {\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> +\t\t\t\t{ 2, controls::draft::TestPatternModeColorBars },\n> +\t\t\t\t/*\n> +\t\t\t\t * No corresponding test pattern mode for:\n> +\t\t\t\t * 1: \"Random data\"\n> +\t\t\t\t * 3: \"Colour Bars with Rolling Bar\"\n> +\t\t\t\t * 4: \"Color squares\"\n> +\t\t\t\t * 5: \"Color squares with rolling bar\"\n> +\t\t\t\t */\n> +\t\t\t},\n> +\t\t} },\n> \t};\n> \n> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39401C0109\n\tfor ;\n\tSat, 24 Jul 2021 05:05:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76781687A9;\n\tSat, 24 Jul 2021 07:05:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 411C260273\n\tfor ;\n\tSat, 24 Jul 2021 07:05:33 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.103])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4772E3D7;\n\tSat, 24 Jul 2021 07:05:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VWy70jLb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627103132;\n\tbh=M+MxtNbuXo5vXytgx/ygbH9TcGDJFugMLwmmUU5iQoQ=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=VWy70jLbiSJwzimuiNHAPO0U6WCJq1IleKU7RrwbgFN4N0vQsUYqYGIgCrZ+yIQfp\n\t737yyWQndNmLCJpYpUzHMviQ89v5HdvBVbCf7mWVuw3YMFnv3pk5QENX7IJmd2B3L5\n\tlQEdKfTxXDpL4seC45Ii7g1y0fUzasDU3nSsh1eM=","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","References":"<20210722203658.3588263-1-djrscally@gmail.com>\n\t<20210722203658.3588263-2-djrscally@gmail.com>","From":"Umang Jain ","Message-ID":"","Date":"Sat, 24 Jul 2021 10:35:28 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210722203658.3588263-2-djrscally@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18321,"web_url":"https://patchwork.libcamera.org/comment/18321/","msgid":"","date":"2021-07-24T22:57:50","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Thu, Jul 22, 2021 at 09:36:58PM +0100, Daniel Scally wrote:\n> Add camera sensor properties for the OV8865 sensor. This is the world\n> facing camera on most MS Surface platforms.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 7d8ba9e9..e1b6416b 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -102,6 +102,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t */\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov8865\", {\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> +\t\t\t\t{ 2, controls::draft::TestPatternModeColorBars },\n\nWould you be able to capture an image with this test pattern ? The color\nbars pattern has a specific definition, identical to the one in the CCS\nspecification. I'd like to double-check that it matches.\n\n> +\t\t\t\t/*\n> +\t\t\t\t * No corresponding test pattern mode for:\n> +\t\t\t\t * 1: \"Random data\"\n> +\t\t\t\t * 3: \"Colour Bars with Rolling Bar\"\n> +\t\t\t\t * 4: \"Color squares\"\n> +\t\t\t\t * 5: \"Color squares with rolling bar\"\n> +\t\t\t\t */\n> +\t\t\t},\n> +\t\t} },\n> \t};\n> \n> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB95DC0109\n\tfor ;\n\tSat, 24 Jul 2021 22:57:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11CFC687B2;\n\tSun, 25 Jul 2021 00:57:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D71D868537\n\tfor ;\n\tSun, 25 Jul 2021 00:57:54 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5279F255;\n\tSun, 25 Jul 2021 00:57:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vr976gXZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627167474;\n\tbh=Z46KFyeV1QbZuZ0R9epURSp62e+7c2eTeZTu8Vu+49I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Vr976gXZkNLM8MF8m7umteQR2oYiwgzlZgp2bGp4OKywz6K7qRCeBqhuq5/nfIgyN\n\tNpNKFcaK58U1FetlJxyElLVOfWq9r3/2XM9mnPvIFKcoKybwjWZnXLlqZJygDHhJik\n\tO553FcaJkrKPPEkSolGYw6/sB5z21va6osL88mBA=","Date":"Sun, 25 Jul 2021 01:57:50 +0300","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20210722203658.3588263-1-djrscally@gmail.com>\n\t<20210722203658.3588263-2-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210722203658.3588263-2-djrscally@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18323,"web_url":"https://patchwork.libcamera.org/comment/18323/","msgid":"","date":"2021-07-24T23:24:30","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/","name":"Daniel Scally","email":"djrscally@gmail.com"},"content":"Hi Laurent\n\nOn 24/07/2021 23:57, Laurent Pinchart wrote:\n> Hi Dan,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 22, 2021 at 09:36:58PM +0100, Daniel Scally wrote:\n>> Add camera sensor properties for the OV8865 sensor. This is the world\n>> facing camera on most MS Surface platforms.\n>>\n>> Signed-off-by: Daniel Scally \n>> ---\n>> src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n>> 1 file changed, 14 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n>> index 7d8ba9e9..e1b6416b 100644\n>> --- a/src/libcamera/camera_sensor_properties.cpp\n>> +++ b/src/libcamera/camera_sensor_properties.cpp\n>> @@ -102,6 +102,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>> \t\t\t\t */\n>> \t\t\t},\n>> \t\t} },\n>> +\t\t{ \"ov8865\", {\n>> +\t\t\t.unitCellSize = { 1400, 1400 },\n>> +\t\t\t.testPatternModes = {\n>> +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n>> +\t\t\t\t{ 2, controls::draft::TestPatternModeColorBars },\n> Would you be able to capture an image with this test pattern ? The color\n> bars pattern has a specific definition, identical to the one in the CCS\n> specification. I'd like to double-check that it matches.\n\n\nSure, this is the output: https://i.imgur.com/Lna5L47.png ... guess it's\nmore like \"coloured columns\" than bars. On that note, just noticed I\nspelled colour the UK way in the comment for item 3.\n\n>\n>> +\t\t\t\t/*\n>> +\t\t\t\t * No corresponding test pattern mode for:\n>> +\t\t\t\t * 1: \"Random data\"\n>> +\t\t\t\t * 3: \"Colour Bars with Rolling Bar\"\n>> +\t\t\t\t * 4: \"Color squares\"\n>> +\t\t\t\t * 5: \"Color squares with rolling bar\"\n>> +\t\t\t\t */\n>> +\t\t\t},\n>> +\t\t} },\n>> \t};\n>> \n>> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C433C0109\n\tfor ;\n\tSat, 24 Jul 2021 23:24:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8804687B6;\n\tSun, 25 Jul 2021 01:24:33 +0200 (CEST)","from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E42568537\n\tfor ;\n\tSun, 25 Jul 2021 01:24:32 +0200 (CEST)","by mail-wr1-x431.google.com with SMTP id l4so6457503wrs.4\n\tfor ;\n\tSat, 24 Jul 2021 16:24:32 -0700 (PDT)","from [192.168.1.211] ([2.29.20.106])\n\tby smtp.gmail.com with ESMTPSA id\n\th8sm2288162wro.36.2021.07.24.16.24.31\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tSat, 24 Jul 2021 16:24:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GhjPYIDP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding:content-language; \n\tbh=tB98GtZTXrgkSSp2PL6xnMn0oIGRwiO3hiuY8WjPzC4=;\n\tb=GhjPYIDPrUim4/ABRJp41rP4qilrFTW+V+KL61po6Iw8vPxRFs88e6axkSdTDAjZTo\n\t8pZDE+3wUZ5fdUlHs0OQo0kYhFeqyFSZdSCgk087aanvGJX47wR1rlwOlgb3e/cCXS/5\n\tPfwfch2HEZH8NeM+HFHfACUq/6k/haWYv7UOiMzugFLQNfn5Uj/pTWNvd92ukYScp9Gy\n\trP7GkXR4ssPGQSUkSAkF3UCTIuGxxcU6j7QtAdbTBuJMBSkNbB3n1/JiZWl8z5VrHb0y\n\tHRfi6EqQBsh+kXAAl1G+zIjd9rB1Cnu7pUvDAaA4tvV/fJzi1y/+jC0CF/GIS+IBvdmr\n\twBtQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding\n\t:content-language;\n\tbh=tB98GtZTXrgkSSp2PL6xnMn0oIGRwiO3hiuY8WjPzC4=;\n\tb=jjdZDPonRWgjkVtbr/iBQvIvvuHBYnmJMhm7UHh+SFFt16J25948rXzesx0l0Fh8TN\n\tx1tOicdY7gK/MqG8oRdG71th2kMFvmbzFgYfpVHqThsdR/x9XCJz3b90VCnqHNLGIjh6\n\tgH1X229pcm/LvEh0+p8oyoAReHFGTqncnD316k2p3fzyEGxVRfkAQz+CXIbixwUMPIbb\n\tm23pxerXa+3P+1lguyywCwwaYQlAylkAQosTNyR4IN3IOivV11ujZQ+dn8DeXFxUgSaE\n\t++Jp0yaUoKC2CNxprQHLKT1OlAUtX0MgqPa0dkA5o9BjYl+tcBATfYLMG9tyzhcq4hBI\n\tTyGQ==","X-Gm-Message-State":"AOAM531NvNuapv84U2weaCkCkvMND/3TP6tE6jIMTXzhqZ9KWjDeKkac\n\twNeX+9LOKt2VW3aAscCatrI1SpFCO7Y=","X-Google-Smtp-Source":"ABdhPJyotRGwC41YK4EhLjHWPdTd7ihygzKnr9UORn6sQ+afXDMQI9f7gM9DU1wD2+rXBf3OAPgq0Q==","X-Received":"by 2002:a5d:504a:: with SMTP id\n\th10mr1135532wrt.185.1627169072094; \n\tSat, 24 Jul 2021 16:24:32 -0700 (PDT)","To":"Laurent Pinchart ","References":"<20210722203658.3588263-1-djrscally@gmail.com>\n\t<20210722203658.3588263-2-djrscally@gmail.com>\n\t","From":"Daniel Scally ","Message-ID":"","Date":"Sun, 25 Jul 2021 00:24:30 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18324,"web_url":"https://patchwork.libcamera.org/comment/18324/","msgid":"","date":"2021-07-24T23:30:21","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sun, Jul 25, 2021 at 12:24:30AM +0100, Daniel Scally wrote:\n> On 24/07/2021 23:57, Laurent Pinchart wrote:\n> > On Thu, Jul 22, 2021 at 09:36:58PM +0100, Daniel Scally wrote:\n> >> Add camera sensor properties for the OV8865 sensor. This is the world\n> >> facing camera on most MS Surface platforms.\n> >>\n> >> Signed-off-by: Daniel Scally \n> >> ---\n> >> src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n> >> 1 file changed, 14 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> >> index 7d8ba9e9..e1b6416b 100644\n> >> --- a/src/libcamera/camera_sensor_properties.cpp\n> >> +++ b/src/libcamera/camera_sensor_properties.cpp\n> >> @@ -102,6 +102,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> >> \t\t\t\t */\n> >> \t\t\t},\n> >> \t\t} },\n> >> +\t\t{ \"ov8865\", {\n> >> +\t\t\t.unitCellSize = { 1400, 1400 },\n> >> +\t\t\t.testPatternModes = {\n> >> +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> >> +\t\t\t\t{ 2, controls::draft::TestPatternModeColorBars },\n> > Would you be able to capture an image with this test pattern ? The color\n> > bars pattern has a specific definition, identical to the one in the CCS\n> > specification. I'd like to double-check that it matches.\n> \n> \n> Sure, this is the output: https://i.imgur.com/Lna5L47.png ... guess it's\n> more like \"coloured columns\" than bars.\n\nThank you. This doesn't seem to match what is expected by\ncontrols::draft::TestPatternModeColorBars, so I'd leave it out (you can\ncheck the MIPI CCS specification if you want to see what the color bars\npattern is supposed to look like).\n\n> On that note, just noticed I spelled colour the UK way in the comment\n> for item 3.\n\nI prefer the British spelling, but in APIs it seems to be a lost battle\n:-(\n\n> >> +\t\t\t\t/*\n> >> +\t\t\t\t * No corresponding test pattern mode for:\n> >> +\t\t\t\t * 1: \"Random data\"\n> >> +\t\t\t\t * 3: \"Colour Bars with Rolling Bar\"\n> >> +\t\t\t\t * 4: \"Color squares\"\n> >> +\t\t\t\t * 5: \"Color squares with rolling bar\"\n> >> +\t\t\t\t */\n> >> +\t\t\t},\n> >> +\t\t} },\n> >> \t};\n> >> \n> >> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0192DC322C\n\tfor ;\n\tSat, 24 Jul 2021 23:30:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F7F0687B6;\n\tSun, 25 Jul 2021 01:30:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15E0060274\n\tfor ;\n\tSun, 25 Jul 2021 01:30:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86E8E255;\n\tSun, 25 Jul 2021 01:30:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MpfAIhMg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627169425;\n\tbh=LOQ/fmCBK/StRg9Wn3Ymv+qeD0FvE9I1dSuodhDvAWM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MpfAIhMgR4lGQ108uYaA86af/MpX1ed9WTcp1uLBE8ppLpdFXXvSP5PTzldiLkAau\n\tTslU9bP/s/YZwPTqgMLhuqXFsIEM5dMc7QSV7/0iFfXNVofrW2EBPQf5jQO2V48Vi4\n\tvhJPd82Xsyj3vE/hWeqsqmHGIUWz2vZ/aVBKvmv0=","Date":"Sun, 25 Jul 2021 02:30:21 +0300","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20210722203658.3588263-1-djrscally@gmail.com>\n\t<20210722203658.3588263-2-djrscally@gmail.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18325,"web_url":"https://patchwork.libcamera.org/comment/18325/","msgid":"","date":"2021-07-24T23:39:28","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sun, Jul 25, 2021 at 02:30:23AM +0300, Laurent Pinchart wrote:\n> On Sun, Jul 25, 2021 at 12:24:30AM +0100, Daniel Scally wrote:\n> > On 24/07/2021 23:57, Laurent Pinchart wrote:\n> > > On Thu, Jul 22, 2021 at 09:36:58PM +0100, Daniel Scally wrote:\n> > >> Add camera sensor properties for the OV8865 sensor. This is the world\n> > >> facing camera on most MS Surface platforms.\n> > >>\n> > >> Signed-off-by: Daniel Scally \n> > >> ---\n> > >> src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n> > >> 1 file changed, 14 insertions(+)\n> > >>\n> > >> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > >> index 7d8ba9e9..e1b6416b 100644\n> > >> --- a/src/libcamera/camera_sensor_properties.cpp\n> > >> +++ b/src/libcamera/camera_sensor_properties.cpp\n> > >> @@ -102,6 +102,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > >> \t\t\t\t */\n> > >> \t\t\t},\n> > >> \t\t} },\n> > >> +\t\t{ \"ov8865\", {\n> > >> +\t\t\t.unitCellSize = { 1400, 1400 },\n> > >> +\t\t\t.testPatternModes = {\n> > >> +\t\t\t\t{ 0, controls::draft::TestPatternModeOff },\n> > >> +\t\t\t\t{ 2, controls::draft::TestPatternModeColorBars },\n> > > Would you be able to capture an image with this test pattern ? The color\n> > > bars pattern has a specific definition, identical to the one in the CCS\n> > > specification. I'd like to double-check that it matches.\n> > \n> > \n> > Sure, this is the output: https://i.imgur.com/Lna5L47.png ... guess it's\n> > more like \"coloured columns\" than bars.\n> \n> Thank you. This doesn't seem to match what is expected by\n> controls::draft::TestPatternModeColorBars, so I'd leave it out (you can\n> check the MIPI CCS specification if you want to see what the color bars\n> pattern is supposed to look like).\n\nPlease ignore this. It's the fade-to-gray bars that is special. The\ncontrols::draft::TestPatternModeColorBars seems to match.\n\nThe white and black bars are shorter though, which I assume is due to\ncropping somewhere in the pipeline ?\n\n> > On that note, just noticed I spelled colour the UK way in the comment\n> > for item 3.\n> \n> I prefer the British spelling, but in APIs it seems to be a lost battle\n> :-(\n\nI'll update that to match the string from the kernel driver, \"Color bars\nwith rolling bar\".\n\nReviewed-by: Laurent Pinchart \n\n> > >> +\t\t\t\t/*\n> > >> +\t\t\t\t * No corresponding test pattern mode for:\n> > >> +\t\t\t\t * 1: \"Random data\"\n> > >> +\t\t\t\t * 3: \"Colour Bars with Rolling Bar\"\n> > >> +\t\t\t\t * 4: \"Color squares\"\n> > >> +\t\t\t\t * 5: \"Color squares with rolling bar\"\n> > >> +\t\t\t\t */\n> > >> +\t\t\t},\n> > >> +\t\t} },\n> > >> \t};\n> > >> \n> > >> \tconst auto it = sensorProps.find(sensor);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BA29C0109\n\tfor ;\n\tSat, 24 Jul 2021 23:39:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EA7F687B5;\n\tSun, 25 Jul 2021 01:39:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8456360274\n\tfor ;\n\tSun, 25 Jul 2021 01:39:32 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EEA01255;\n\tSun, 25 Jul 2021 01:39:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RyZ7+1ys\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627169972;\n\tbh=WthmY4vkLr+P+Yuxq36B8FpEpmV7u4q+uRuKgfwi6lw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RyZ7+1ys96pUBR+E1sosc9IGsrW0fvxE2asU2c78yMGq6aiIfzaGAp7ue6AvujpU1\n\tXRcIJ+D/wXE1j03MgTu7obxyO5alZRf1uc6NxrxHHUmPgA7ldc+7MIBdbxOs8bjcPG\n\tJgJy5kOPY2iwNacl+DQQfJLQjMe86PU8oyyhGSLk=","Date":"Sun, 25 Jul 2021 02:39:28 +0300","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20210722203658.3588263-1-djrscally@gmail.com>\n\t<20210722203658.3588263-2-djrscally@gmail.com>\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV8865 sensor\n\tproperties.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]