[{"id":18296,"web_url":"https://patchwork.libcamera.org/comment/18296/","msgid":"<807c3c92-058a-be19-3f0b-5b6886c7c83d@ideasonboard.com>","date":"2021-07-24T05:06:56","subject":"Re: [libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper\n\tfor ov8865","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Daniel,\n\nThanks for the patch.\n\nOn 7/23/21 2:06 AM, Daniel Scally wrote:\n> Add a CameraSensorHelperOv8865 class. The gain coefficients are gleaned\n> from the datasheet; the lowest 7 bits are reported there as fractional\n> bits, so real gain is val/128.\n>\n> Signed-off-by: Daniel Scally \nReviewed-by: Umang Jain \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 709835a8..e72167ec 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -325,6 +325,16 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n> \n> +class CameraSensorHelperOv8865 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv8865()\n> +\t{\n> +\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov8865\", CameraSensorHelperOv8865)\n> +\n> #endif /* __DOXYGEN__ */\n> \n> } /* namespace ipa */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D49AC0109\n\tfor ;\n\tSat, 24 Jul 2021 05:07:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CCDB687A9;\n\tSat, 24 Jul 2021 07:07:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFE4D60273\n\tfor ;\n\tSat, 24 Jul 2021 07:07:00 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.103])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24D0C3D7;\n\tSat, 24 Jul 2021 07:06:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v53zymwy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627103220;\n\tbh=f5ljorWTS19koZA9funLvfxpWCWbEb3LIbrKS0qSaX8=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=v53zymwyUL5nz+bouV40LLsnxUO0C6zJInDZ61gU0YpAP3aLrYDssqbzvj5aUpheI\n\tiVENauPaY+YFTiRqVMSYZnpFf9YDPxjfzivVyM8LVh90rd2/yttR7bEieST1DHyxZF\n\t32V+FVb5oupaJd0nO3yyvQdx5S6CqOi1sj2gDqNU=","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","References":"<20210722203658.3588263-1-djrscally@gmail.com>","From":"Umang Jain ","Message-ID":"<807c3c92-058a-be19-3f0b-5b6886c7c83d@ideasonboard.com>","Date":"Sat, 24 Jul 2021 10:36:56 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210722203658.3588263-1-djrscally@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper\n\tfor ov8865","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18319,"web_url":"https://patchwork.libcamera.org/comment/18319/","msgid":"","date":"2021-07-24T22:52:40","subject":"Re: [libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper\n\tfor ov8865","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Daniel,\n\nThank you for the patch.\n\nOn Thu, Jul 22, 2021 at 09:36:57PM +0100, Daniel Scally wrote:\n> Add a CameraSensorHelperOv8865 class. The gain coefficients are gleaned\n> from the datasheet; the lowest 7 bits are reported there as fractional\n> bits, so real gain is val/128.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 709835a8..e72167ec 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -325,6 +325,16 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n> \n> +class CameraSensorHelperOv8865 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv8865()\n> +\t{\n> +\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov8865\", CameraSensorHelperOv8865)\n> +\n\nLet's move this above OV13858 to keep entries sorted. I'll fix this when\napplying.\n\nReviewed-by: Laurent Pinchart \n\n> #endif /* __DOXYGEN__ */\n> \n> } /* namespace ipa */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9968C322C\n\tfor ;\n\tSat, 24 Jul 2021 22:52:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D3BE687B2;\n\tSun, 25 Jul 2021 00:52:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4034468537\n\tfor ;\n\tSun, 25 Jul 2021 00:52:45 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B2E1F255;\n\tSun, 25 Jul 2021 00:52:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ta8JYN83\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627167164;\n\tbh=48c+0+VHLpx6sZz5p0Uti8dOx1qw3MkUjXBu5i/xCgQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ta8JYN832KBjOoYOMKhl1K9iVd6faolB5DacNRQwTyhfozKko9p7p6n+/4GS4fjhp\n\t5j0PBSNa169X4p4VGUjDf32k7RnkolY7uXO2mg41xvVKdzy+w8eVIbm8v9xuk73m+b\n\tOJgkVNkpbXX8xJZ9gAUd3CTb/mG7ubucHJq2aWuY=","Date":"Sun, 25 Jul 2021 01:52:40 +0300","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20210722203658.3588263-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210722203658.3588263-1-djrscally@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper\n\tfor ov8865","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18320,"web_url":"https://patchwork.libcamera.org/comment/18320/","msgid":"<16327242-d0c7-5d85-8c5c-ed9a2b7e2872@gmail.com>","date":"2021-07-24T22:54:32","subject":"Re: [libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper\n\tfor ov8865","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/","name":"Daniel Scally","email":"djrscally@gmail.com"},"content":"Hi Laurent\n\nOn 24/07/2021 23:52, Laurent Pinchart wrote:\n> Hi Daniel,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 22, 2021 at 09:36:57PM +0100, Daniel Scally wrote:\n>> Add a CameraSensorHelperOv8865 class. The gain coefficients are gleaned\n>> from the datasheet; the lowest 7 bits are reported there as fractional\n>> bits, so real gain is val/128.\n>>\n>> Signed-off-by: Daniel Scally \n>> ---\n>> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n>> 1 file changed, 10 insertions(+)\n>>\n>> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n>> index 709835a8..e72167ec 100644\n>> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n>> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n>> @@ -325,6 +325,16 @@ public:\n>> };\n>> REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n>> \n>> +class CameraSensorHelperOv8865 : public CameraSensorHelper\n>> +{\n>> +public:\n>> +\tCameraSensorHelperOv8865()\n>> +\t{\n>> +\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n>> +\t}\n>> +};\n>> +REGISTER_CAMERA_SENSOR_HELPER(\"ov8865\", CameraSensorHelperOv8865)\n>> +\n> Let's move this above OV13858 to keep entries sorted. I'll fix this when\n> applying.\n\n\nOne day I will learn to sort things! Thanks very much\n\n> Reviewed-by: Laurent Pinchart \n>\n>> #endif /* __DOXYGEN__ */\n>> \n>> } /* namespace ipa */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E88CC0109\n\tfor ;\n\tSat, 24 Jul 2021 22:54:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09D1F687B2;\n\tSun, 25 Jul 2021 00:54:35 +0200 (CEST)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C293368537\n\tfor ;\n\tSun, 25 Jul 2021 00:54:33 +0200 (CEST)","by mail-wm1-x335.google.com with SMTP id\n\t9-20020a05600c26c9b02901e44e9caa2aso3855426wmv.4\n\tfor ;\n\tSat, 24 Jul 2021 15:54:33 -0700 (PDT)","from [192.168.1.211] ([2.29.20.106])\n\tby smtp.gmail.com with ESMTPSA id\n\td5sm5138840wre.77.2021.07.24.15.54.32\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tSat, 24 Jul 2021 15:54:33 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qDnLb8Cm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding:content-language; \n\tbh=jUcUJ1ckbxIn+qwY1aAcnQcq/RdJGMJ1Hdpr8K8W/u0=;\n\tb=qDnLb8CmhjYryQ/Wm385xkSWSdqdwRv04PiQRrOCslhILgiy3LLsALrcJsqTxIvOEP\n\tD+C1nTlKe1qJI24fDLsxU8B8Bg41DTXT9RtlflmDbZiRUaOZwMceU+k2RZGvDL1aY8Pd\n\tOx5Mi0zRseEAhOcdEpHMl9WYeWogRWMVlbstC+G/ai9fXxCdHi8eONr0w1m8c/Jq619/\n\tnj8Gdav93W40yX7xrfRm980ZuPV9F0KVktHX8b/2DfWdwcolP+VsAdxbrs6Ao2qO4VS4\n\tNQksYZH0pKv70YjMLPjk6b0lsjYeQ5ExHCse3SumNMCljO1Ae9g1a744aJM/Y6Um14HJ\n\tU46Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding\n\t:content-language;\n\tbh=jUcUJ1ckbxIn+qwY1aAcnQcq/RdJGMJ1Hdpr8K8W/u0=;\n\tb=c0fSz/Rh1HEZqp4cLFnoXb0drHmEN1u6Yf/6aRO7SD4KPnWjjvwiK7B3MOc78renXB\n\t38kM43pmTIdvtjfJnUdGCKeu8snMMHXQS8yju0j2aQOHFVoY0d3+mPStdbxXPtUG5WeP\n\trw1nwizcxNDNPvqPq/Eu4/IH+gMvx2xr1eHSmCnzuHmqul10TcwlqxM464mQ3VaPeix3\n\tp3IkeHzdmBRU04SHIU/eODB53JTRzcjyVGCZcU1OKv0bnV9vOBILczldMCLqlkXg9cJK\n\tNQV4qgDl/IRDrBuz+4JtOU8bdH2tG3CCffdSZnRYq/kyjiMXmXjFhDNc4nWjLBXll7tc\n\tgPeQ==","X-Gm-Message-State":"AOAM5319SFjUJXvXCLnoLEDoGKmj3iqf8JGkiOd6Zckv+YURd0RUBhTf\n\t5IbZY4F4dOkpdknYsGEPA4aPyG20K7A=","X-Google-Smtp-Source":"ABdhPJz+x/aWqWU1Daj3HVes80CZ372voByEshq+rucQF/hNkFB2Ci3anphCJbC2IyOSnq+jmrj1Mw==","X-Received":"by 2002:a05:600c:4f11:: with SMTP id\n\tl17mr1348302wmq.94.1627167273472; \n\tSat, 24 Jul 2021 15:54:33 -0700 (PDT)","To":"Laurent Pinchart ","References":"<20210722203658.3588263-1-djrscally@gmail.com>\n\t","From":"Daniel Scally ","Message-ID":"<16327242-d0c7-5d85-8c5c-ed9a2b7e2872@gmail.com>","Date":"Sat, 24 Jul 2021 23:54:32 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/2] libipa: Add CameraSensorHelper\n\tfor ov8865","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]