[{"id":18394,"web_url":"https://patchwork.libcamera.org/comment/18394/","msgid":"","date":"2021-07-28T06:36:38","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Return\n\tcontrols::FrameDuration from the IPA","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nGentle ping for some feedback on this change.\n\nThanks,\nNaush\n\nOn Thu, 22 Jul 2021 at 12:57, Naushir Patuck wrote:\n\n> Return controls::FrameDuration through the per-frame Request metadata. The\n> frame duration is obtained by either the value in DelayedControls, or\n> (preferably) the value parsed from the embedded data buffer.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 5cd333049807..b08602f474af 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -465,6 +465,8 @@ void IPARPi::reportMetadata()\n> libcameraMetadata_.set(controls::ExposureTime,\n>\n> deviceStatus->shutter_speed.get());\n> libcameraMetadata_.set(controls::AnalogueGain,\n> deviceStatus->analogue_gain);\n> + libcameraMetadata_.set(controls::FrameDuration,\n> +\n> helper_->Exposure(deviceStatus->frame_length).get());\n> }\n>\n> AgcStatus *agcStatus =\n> rpiMetadata_.GetLocked(\"agc.status\");\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B66B7C3230\n\tfor ;\n\tWed, 28 Jul 2021 06:36:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 26647687C4;\n\tWed, 28 Jul 2021 08:36:56 +0200 (CEST)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BF646026F\n\tfor ;\n\tWed, 28 Jul 2021 08:36:54 +0200 (CEST)","by mail-lf1-x135.google.com with SMTP id h14so1927876lfv.7\n\tfor ;\n\tTue, 27 Jul 2021 23:36:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rnh1Hi4T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=bQwMpaUcFWlrhp1BHT8D88lqpfnKtzdzZzl1rZM1w1E=;\n\tb=rnh1Hi4T3SyaLl3u5pCFS5Y54gTwB+3KGQB+yh89D7/PZLAN1NbWJHxq4Opqu7Q0rV\n\tpI4nMa9wx9/LAuLHqUMlvbS/abNtM84H+ogRKh6P3JS3DfysqA6ot2MA4DKs44cpr+wY\n\t7a59nlR4cOfy0aNH1l+sRxpR+vnlNdLwITNgWSYV56sOs5O+diCj/qhdSbJ7ccf8ZLVP\n\t8CJjNTHRW9kwlNYqBSvDx6zDOUc3ZYWClVGb37agTjM8tT3jW0n7oYz1zl1LobVL3aHJ\n\t1D3/CSvucXlI2rE07CkVCophUUN+TBtciQB1apwKJvxGy7nfiqBSwNsJ++gzdgeOitun\n\tH2+w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=bQwMpaUcFWlrhp1BHT8D88lqpfnKtzdzZzl1rZM1w1E=;\n\tb=PBpgcvblM392KFRDMP3dVr9jRaYMT4mGtFGEqTFbVxalq5sjmz4C37JEs9DpQD7HIz\n\tRdUjXfyuZPMI7rYjsxR186cjuHj0p2qEPWZ+hffY2Twwi3kK6LhXg+WrxCj2VtQ1ZnmF\n\tG8+R55JoouG0Oy/bFDfCBgvCyf9VjZ8EikCvxAPAY5TAJ5WGWd/IO2DNLDHOrvzR4y/g\n\t2sWUVo4/HxEPKYxYw4+KmT5vl01wD8Brbd7XRg58VgiI7GJ+3mIaLpYqWZ9RbAYoRn1M\n\t8kG0RsSZxMt4sSpWBq/oNqNTP+RlNHjBu25W12BMaljd/v0JuxKMp7hzuJDm4NYgVEHp\n\taHow==","X-Gm-Message-State":"AOAM531b/PMILl2O8QWQ6TUHZn2CQ5e4f4ZqADefkDOEhM/iLCTBUdBN\n\t/QF268cNYwEHa2RrnYokK60mr2ihe2cxeuP0Fv6pFcExIJs=","X-Google-Smtp-Source":"ABdhPJyHbwRaGLAbcwVZanHs771U6/P7jziePcw/eqDXUV6wwCy9537qlVYW6t4D6I4LuWc69V9JM3DXLqqciz3BDBo=","X-Received":"by 2002:a05:6512:1104:: with SMTP id\n\tl4mr18880132lfg.375.1627454213084; \n\tTue, 27 Jul 2021 23:36:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20210722115742.3131100-1-naush@raspberrypi.com>","In-Reply-To":"<20210722115742.3131100-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Wed, 28 Jul 2021 07:36:38 +0100","Message-ID":"","To":"libcamera devel ","Content-Type":"multipart/alternative; boundary=\"000000000000426e9d05c82936e3\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Return\n\tcontrols::FrameDuration from the IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18397,"web_url":"https://patchwork.libcamera.org/comment/18397/","msgid":"","date":"2021-07-28T06:55:13","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Return\n\tcontrols::FrameDuration from the IPA","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Thu, Jul 22, 2021 at 12:57:42PM +0100, Naushir Patuck wrote:\n> Return controls::FrameDuration through the per-frame Request metadata. The\n> frame duration is obtained by either the value in DelayedControls, or\n> (preferably) the value parsed from the embedded data buffer.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\nDavid, would you like to review this, or should I merge it ?\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 5cd333049807..b08602f474af 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -465,6 +465,8 @@ void IPARPi::reportMetadata()\n> \t\tlibcameraMetadata_.set(controls::ExposureTime,\n> \t\t\t\t deviceStatus->shutter_speed.get());\n> \t\tlibcameraMetadata_.set(controls::AnalogueGain, deviceStatus->analogue_gain);\n> +\t\tlibcameraMetadata_.set(controls::FrameDuration,\n> +\t\t\t\t helper_->Exposure(deviceStatus->frame_length).get());\n> \t}\n> \n> \tAgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81F69C322E\n\tfor ;\n\tWed, 28 Jul 2021 06:55:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FFED687C4;\n\tWed, 28 Jul 2021 08:55:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97BEF6026F\n\tfor ;\n\tWed, 28 Jul 2021 08:55:19 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A339EE;\n\tWed, 28 Jul 2021 08:55:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PeZ+jG3D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627455319;\n\tbh=LY3FlTYa6ipp+fRFXjb5nYG/2EaSJjwPtV/4+Z1l1DY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PeZ+jG3DLGkknlU5Hj0qBUE/L2697NygAUqtFwTo1cQQBRF1L3psklOVaFUN5fYE/\n\tnWY6/D3zctdVYxS+vDO3vJlO6NXZ4JCnmWyRC8ppCcN2Z3CH8Cocesi2DD6V4wJ33X\n\t2JoXDGWnLIlHcJDmnUAGG4RZ3TmQXLGN1bPVHOjA=","Date":"Wed, 28 Jul 2021 09:55:13 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ,\n\tDavid Plowman ","Message-ID":"","References":"<20210722115742.3131100-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210722115742.3131100-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Return\n\tcontrols::FrameDuration from the IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18401,"web_url":"https://patchwork.libcamera.org/comment/18401/","msgid":"","date":"2021-07-28T08:22:45","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Return\n\tcontrols::FrameDuration from the IPA","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nSorry, this one must have slipped past me! Happy to merge, also with\n\nReviewed-by: David Plowman \n\nThanks!\nDavod\n\nOn Wed, 28 Jul 2021 at 07:55, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 22, 2021 at 12:57:42PM +0100, Naushir Patuck wrote:\n> > Return controls::FrameDuration through the per-frame Request metadata. The\n> > frame duration is obtained by either the value in DelayedControls, or\n> > (preferably) the value parsed from the embedded data buffer.\n> >\n> > Signed-off-by: Naushir Patuck \n>\n> Reviewed-by: Laurent Pinchart \n>\n> David, would you like to review this, or should I merge it ?\n>\n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 5cd333049807..b08602f474af 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -465,6 +465,8 @@ void IPARPi::reportMetadata()\n> > libcameraMetadata_.set(controls::ExposureTime,\n> > deviceStatus->shutter_speed.get());\n> > libcameraMetadata_.set(controls::AnalogueGain, deviceStatus->analogue_gain);\n> > + libcameraMetadata_.set(controls::FrameDuration,\n> > + helper_->Exposure(deviceStatus->frame_length).get());\n> > }\n> >\n> > AgcStatus *agcStatus = rpiMetadata_.GetLocked(\"agc.status\");\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 762A2C3230\n\tfor ;\n\tWed, 28 Jul 2021 08:22:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B20A5687C4;\n\tWed, 28 Jul 2021 10:22:57 +0200 (CEST)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9415B687B6\n\tfor ;\n\tWed, 28 Jul 2021 10:22:56 +0200 (CEST)","by mail-wr1-x432.google.com with SMTP id b7so1427997wri.8\n\tfor ;\n\tWed, 28 Jul 2021 01:22:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"b0JEP0f9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=YaZq9tnzNSUqAPwyUZnKnpq4YBwmv2Jl2RdEgSzijT0=;\n\tb=b0JEP0f9Vw7Ubpz66WwOmWwN+Lj6mkdjRQ//fbzBOVB0MJqRyYCfcE9Dc9GC8TCOsr\n\t3DmZmSUaZCRaTIvCPKD+EwlC4EeNvUhSiHxvPyTveuMUH0gmAfXnMVGsWlmwoRdLT9eQ\n\tEchkZxZ7tlkiDs8l8b3Hd68ZXfbV/wWe3fVpWs9r1WPMVFNGjVAkRqoJGSKmXzrNigxG\n\tXo/WKnE7iZqe7RbA1nIHHJ6mBLkJtB1IuWeIiq1E0m4AsUty/71ZRpoovAACz5mKMhH1\n\txPIMmQww9RxL4gbONMqa1P27KckcG+ek8kJ1I+vDaHK9Kr5x8kaZZcbAl5xPf8ZqVCRL\n\t059g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=YaZq9tnzNSUqAPwyUZnKnpq4YBwmv2Jl2RdEgSzijT0=;\n\tb=R5fKUMwwBD88cWGoiKwAr9bD0k8U22PokKtxfdA9+FroMfG6AFobQuF8k1Asn6wiQQ\n\t/Sk1+2QDs+tOpvw+5EkZT+jIvp6hgpvXiO0/VrIXKV/PYsgbmJLN+olcaLtrWZgYnPX5\n\tjhxbes9Dvg/NNAhFStOA4x0vuWO2+Nl9UBOrY7t0pbhZ21VgmzQ0DYEyfs1lU5AbPwmG\n\tUAeqHqRqHJ0MzU6I1oDCbyPGWCQeoN69y8s7DGamDdjzDzfRK3jpWsGM/F+K7tfPsn/i\n\txhcI6CSRhB3BBjuL0mTAMTIBPohf81wIZ3ncjl8K1fHAL2D92mr9mce0wG1Rjrnf2iGU\n\tgUAA==","X-Gm-Message-State":"AOAM532Go5wjqm8I8TB3wkcAwsz+3AsuisgZrHhh0qEPa9NoZk9oXQ/j\n\t2m36a8JF9p/FrEQadWPFEFGMl41HdEHTmuh6ZmvCUg==","X-Google-Smtp-Source":"ABdhPJyfly/gMv3yNZD1lFnRpirbj8JmZU97H3ajPcQcgcxRaA+SBQJfTx7l/e+GM2ijsirzljlrIBj6tqsO+LMr3zI=","X-Received":"by 2002:adf:ed4a:: with SMTP id u10mr9767554wro.86.1627460576210;\n\tWed, 28 Jul 2021 01:22:56 -0700 (PDT)","MIME-Version":"1.0","References":"<20210722115742.3131100-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Wed, 28 Jul 2021 09:22:45 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Return\n\tcontrols::FrameDuration from the IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]