[{"id":18266,"web_url":"https://patchwork.libcamera.org/comment/18266/","msgid":"","date":"2021-07-22T13:56:45","subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tIMX258","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Jul 22, 2021 at 04:52:50PM +0530, Umang Jain wrote:\n> Extend the CameraSensorHelper factory with support for the IMX258\n> sensor found in the Nautilus Chromebook.\n> \n> The values are read by manually tweaking the IMX258 kernel driver.\n> The IMX258 kernel driver hints that the sensor may be compatible\n> with the MIPI CCS specification, as the register set matches.\n> The values for analog gain constants are obtained by reading the\n> register indexes, corresponding to the analog gain constants, as\n> mentioned in MIPI CCS v1.1 specification.\n\nI would add here\n\n\"The values have further been confirmed by Dave Stevenson as correct.\"\n\n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> v1 -> v2:\n> - Revamp commit message. \n> - Dave from RPi can confirm these values from the datasheet.\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 709835a8..c43368df 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -295,6 +295,16 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n> \n> +class CameraSensorHelperImx258 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperImx258()\n> + {\n> + analogueGainConstants_ = { AnalogueGainLinear, 0, 512, -1, 512 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n> +\n> class CameraSensorHelperOv5670 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2DD5C0109\n\tfor ;\n\tThu, 22 Jul 2021 13:56:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 289246027F;\n\tThu, 22 Jul 2021 15:56:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A93816027A\n\tfor ;\n\tThu, 22 Jul 2021 15:56:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F044465;\n\tThu, 22 Jul 2021 15:56:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IjrjjGE1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626962206;\n\tbh=rSSf9DlCR5e2CZSE1xQVVn/4lUKzBHX8TXhYyk7XvIM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IjrjjGE1w6S1pJEQt+WnAdPqm3KNpdY4jNju/kZdTGOod3BwLkOfWOfmbIsTeT21Y\n\tP5H5vqpylNZ+vDg3ooRNO1mXpIt53G1PbD5O+cR1HXP4D57wHVjxCjkYes63tCcDkx\n\tF1VN4JbstkrI2m/VE8jHrKf9MhXxiUXCF2TRHEkg=","Date":"Thu, 22 Jul 2021 16:56:45 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20210722112250.805973-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210722112250.805973-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tIMX258","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18268,"web_url":"https://patchwork.libcamera.org/comment/18268/","msgid":"","date":"2021-07-22T14:07:54","subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tIMX258","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"On Thu, 22 Jul 2021 at 14:56, Laurent Pinchart\n wrote:\n>\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 22, 2021 at 04:52:50PM +0530, Umang Jain wrote:\n> > Extend the CameraSensorHelper factory with support for the IMX258\n> > sensor found in the Nautilus Chromebook.\n> >\n> > The values are read by manually tweaking the IMX258 kernel driver.\n> > The IMX258 kernel driver hints that the sensor may be compatible\n> > with the MIPI CCS specification, as the register set matches.\n> > The values for analog gain constants are obtained by reading the\n> > register indexes, corresponding to the analog gain constants, as\n> > mentioned in MIPI CCS v1.1 specification.\n>\n> I would add here\n>\n> \"The values have further been confirmed by Dave Stevenson as correct.\"\n\nName and shame the guilty party! :-)\n\n\"The values have further been confirmed by Dave Stevenson as being\nthose specified in the datasheet\"\n\nI have no intrinsic knowledge of the sensor itself, and we all know\nthat datasheets can be wrong at times.\n\n Dave\n\n> > Signed-off-by: Umang Jain \n>\n> Reviewed-by: Laurent Pinchart \n>\n> > ---\n> > v1 -> v2:\n> > - Revamp commit message.\n> > - Dave from RPi can confirm these values from the datasheet.\n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> > 1 file changed, 10 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index 709835a8..c43368df 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -295,6 +295,16 @@ public:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n> >\n> > +class CameraSensorHelperImx258 : public CameraSensorHelper\n> > +{\n> > +public:\n> > + CameraSensorHelperImx258()\n> > + {\n> > + analogueGainConstants_ = { AnalogueGainLinear, 0, 512, -1, 512 };\n> > + }\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n> > +\n> > class CameraSensorHelperOv5670 : public CameraSensorHelper\n> > {\n> > public:\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4F7BC0109\n\tfor ;\n\tThu, 22 Jul 2021 14:08:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3DE03687A4;\n\tThu, 22 Jul 2021 16:08:12 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7616F68778\n\tfor ;\n\tThu, 22 Jul 2021 16:08:10 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id r11so6080058wro.9\n\tfor ;\n\tThu, 22 Jul 2021 07:08:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"K4TsMbOF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=dqAQ44kZsA99BrVNZcvt+UDEU8scRH6QjTn8tc8otpY=;\n\tb=K4TsMbOFGNgeFthNPPHS1Wa33anlxky/zQBA/+gv/tiLyEW7q4uhar9Yme3ZELSvX5\n\tNS77y/06aK3SmercIznJhpSPKgYWUHK3eUXznDgtsKQ7dBzObJh9ppmf0ZL/9fG0BVcQ\n\tyBchFCq6piXV+GrGdbbxpC3eoJ5SglW59eRN39id6kSxXNglIJrTEaxYFU/ewxUMoqSB\n\tyQnbfNnEr/OWaWPBgbQW+zYB5hbE2ouPKaBSQA6970DZv5N3VsLI187WzFNCZ0iA1Qi2\n\tiwn3Hh8TA9MQebSafC1+nRR8vOws33Og7JmZk/pwfaQshtMffC3384MxxL/qDMJXCyDF\n\tbJHA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=dqAQ44kZsA99BrVNZcvt+UDEU8scRH6QjTn8tc8otpY=;\n\tb=TkAoXsV1foMDiVLGiWhm+6GfdWlZrz4UMoQi2crbdGzR91IbFMordQ4dUGya0KXvMj\n\tYlpTI/C68SQvwPAu1LhcQhRVQrhxRLVq5BVzmJ3/00iQlQWXjrOaBlDWIqPQrcJYSfnq\n\tszPCEP7nB1xfnQM4oPTwzWhzbhC6jgnRITUcK9bNib4ix0qchXYXX3zkJ+lh9lkeHnyr\n\tjJfB9Q0yZZx6psyZ5EWSm5KLz1STL+i93gJ4zRaae89Zi4AJ/i7p/6Tj9IMj5H6EqvmM\n\tPlx5Jb5j7cbxgYF9WoMnba3daAJdqjI8Dv4yHLBDtmIWWEkmFNcr7WAizGu0Beq9TKLz\n\tpOEw==","X-Gm-Message-State":"AOAM531N91ml5dOQQdsPQulFSHz8Rd1cPy8Lgn2QFLFaxaLUW0nLdaJr\n\tRQcqQXdCxuGNzZDFFX23u6O+7tx26Kb8KldCxS5uBelxj1BDbg==","X-Google-Smtp-Source":"ABdhPJwfJXrtBTlFDFnA32aWllTjyWuPeZPYj1dQ9Q+YL8Qyr4E8ieOe0luMRrFrZIkYComBhlTVKFdZkLmvghF48U0=","X-Received":"by 2002:a5d:68c2:: with SMTP id p2mr92536wrw.27.1626962890045;\n\tThu, 22 Jul 2021 07:08:10 -0700 (PDT)","MIME-Version":"1.0","References":"<20210722112250.805973-1-umang.jain@ideasonboard.com>\n\t","In-Reply-To":"","From":"Dave Stevenson ","Date":"Thu, 22 Jul 2021 15:07:54 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tIMX258","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18270,"web_url":"https://patchwork.libcamera.org/comment/18270/","msgid":"","date":"2021-07-22T14:34:22","subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tIMX258","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jul 22, 2021 at 03:07:54PM +0100, Dave Stevenson wrote:\n> On Thu, 22 Jul 2021 at 14:56, Laurent Pinchart wrote:\n> > On Thu, Jul 22, 2021 at 04:52:50PM +0530, Umang Jain wrote:\n> > > Extend the CameraSensorHelper factory with support for the IMX258\n> > > sensor found in the Nautilus Chromebook.\n> > >\n> > > The values are read by manually tweaking the IMX258 kernel driver.\n> > > The IMX258 kernel driver hints that the sensor may be compatible\n> > > with the MIPI CCS specification, as the register set matches.\n> > > The values for analog gain constants are obtained by reading the\n> > > register indexes, corresponding to the analog gain constants, as\n> > > mentioned in MIPI CCS v1.1 specification.\n> >\n> > I would add here\n> >\n> > \"The values have further been confirmed by Dave Stevenson as correct.\"\n> \n> Name and shame the guilty party! :-)\n> \n> \"The values have further been confirmed by Dave Stevenson as being\n> those specified in the datasheet\"\n\nEven better :-) Thanks Dave.\n\n> I have no intrinsic knowledge of the sensor itself, and we all know\n> that datasheets can be wrong at times.\n> \n> > > Signed-off-by: Umang Jain \n> >\n> > Reviewed-by: Laurent Pinchart \n> >\n> > > ---\n> > > v1 -> v2:\n> > > - Revamp commit message.\n> > > - Dave from RPi can confirm these values from the datasheet.\n> > > ---\n> > > src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> > > 1 file changed, 10 insertions(+)\n> > >\n> > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > index 709835a8..c43368df 100644\n> > > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > @@ -295,6 +295,16 @@ public:\n> > > };\n> > > REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n> > >\n> > > +class CameraSensorHelperImx258 : public CameraSensorHelper\n> > > +{\n> > > +public:\n> > > + CameraSensorHelperImx258()\n> > > + {\n> > > + analogueGainConstants_ = { AnalogueGainLinear, 0, 512, -1, 512 };\n> > > + }\n> > > +};\n> > > +REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n> > > +\n> > > class CameraSensorHelperOv5670 : public CameraSensorHelper\n> > > {\n> > > public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 248B8C0109\n\tfor ;\n\tThu, 22 Jul 2021 14:34:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90B866877A;\n\tThu, 22 Jul 2021 16:34:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FD1368779\n\tfor ;\n\tThu, 22 Jul 2021 16:34:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8626A465;\n\tThu, 22 Jul 2021 16:34:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jfhzrWXW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626964463;\n\tbh=Z08gPZmfqcQOAXsdzkUW7y/h+ONDJOZ7zQU4+rRatic=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jfhzrWXWp4ygpQcWUE40YxIESDVLqgbCeoyGbxVz0ONnO8QiyJdM6zN37A4r1nXdh\n\tGzNfI25zaiQQ4MIJjfOcfAud+5E2oe2CsbeCvhuolPAFtThxP643av4rxIP0/XeHWm\n\tj+bXv4El2aCAjUanarHXkgin1Obul63RKQGvKezs=","Date":"Thu, 22 Jul 2021 17:34:22 +0300","From":"Laurent Pinchart ","To":"Dave Stevenson ","Message-ID":"","References":"<20210722112250.805973-1-umang.jain@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tIMX258","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]