[{"id":1729,"web_url":"https://patchwork.libcamera.org/comment/1729/","msgid":"","date":"2019-05-29T22:50:47","subject":"Re: [libcamera-devel] [PATCH 16/17] cam: Add --info option to print\n\tinformation about stream(s)","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 27/05/2019 01:15, Niklas Söderlund wrote:\n> Add a new option to cam tool which prints information about the\n> configuration supplied by the user.\n\n\n\n> If specified information is printed\n> about the configuration after its been verified and possibly adjusted by\n> the camera and information about each stream in the camera\n> configuration.\n\nThat paragraph is hard to interpret. But it's late so perhaps I'm just\ntired.\n\nDo you mean something like:\n\nIf provided by the pipeline handler, information is printed about the\nconfiguration after it has been verified (and potentially adjusted) by\nthe camera and information about each stream in the camera configuration\nis presented.\n\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/cam/info.cpp | 44 ++++++++++++++++++++++++++++++++++++++++++++\n> src/cam/info.h | 18 ++++++++++++++++++\n> src/cam/main.cpp | 8 ++++++++\n> src/cam/main.h | 1 +\n> src/cam/meson.build | 1 +\n> 5 files changed, 72 insertions(+)\n> create mode 100644 src/cam/info.cpp\n> create mode 100644 src/cam/info.h\n> \n> diff --git a/src/cam/info.cpp b/src/cam/info.cpp\n> new file mode 100644\n> index 0000000000000000..35271942600494c7\n> --- /dev/null\n> +++ b/src/cam/info.cpp\n> @@ -0,0 +1,44 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * info.cpp - Displat stream information\n> + */\n> +\n> +#include \n> +#include \n> +\n> +#include \"info.h\"\n> +\n> +using namespace libcamera;\n> +\n> +int Info::run(const CameraConfiguration *config)\n> +{\n> +\tif (!config) {\n> +\t\tstd::cout\n> +\t\t\t<< \"Can't display information, no configuration\"\n> +\t\t\t<< std::endl;\n> +\t\treturn -ENODEV;\n> +\t}\n> +\n> +\tunsigned int index = 0;\n> +\tfor (const StreamConfiguration cfg : *config) {\n> +\t\tstd::cout << index << \": \" << cfg.toString() << std::endl;\n> +\n> +\t\tconst StreamFormats &formats = cfg.formats();\n> +\t\tfor (unsigned int pixelformat : formats.pixelformats()) {\n> +\t\t\tstd::cout << \" * Pixelformat: 0x\" << std::hex\n> +\t\t\t\t << std::setw(8) << pixelformat << \" \"\n> +\t\t\t\t << formats.range(pixelformat).toString()\n> +\t\t\t\t << std::endl;\n> +\n> +\t\t\tfor (const Size &size : formats.sizes(pixelformat))\n> +\t\t\t\tstd::cout << \" - \" << size.toString()\n> +\t\t\t\t\t << std::endl;\n> +\t\t}\n\nThis looks quite nice:\n\n./build/src/cam/cam -c \"HP Wide Vision FHD Camera: HP W\" -i\nUsing camera HP Wide Vision FHD Camera: HP W\n0: 1920x1080-0x47504a4d\n * Pixelformat: 0x47504a4d Width: 176-1920 Height: 144-1080 hStep: 1\nvStep: 1\n - 176x144\n - 320x240\n - 352x288\n - 640x360\n - 640x480\n - 1280x720\n - 1920x1080\n\nExcept for this bit:\n * Pixelformat: 0x47504a4d Width: 176-1920 Height: 144-1080 hStep: 1\nvStep: 1\n\n - 176-1920 ?\n\nPerhaps should we format this as\n * Pixelformat 0x47504a4d 176x144 -> 1920x1080 ?\n\nInfact, that's a print option in the formats.range() ...\n\n\n> +\n> +\t\tindex++;\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> diff --git a/src/cam/info.h b/src/cam/info.h\n> new file mode 100644\n> index 0000000000000000..72fd446491f95033\n> --- /dev/null\n> +++ b/src/cam/info.h\n> @@ -0,0 +1,18 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * info.h - Displat stream information\n> + */\n> +#ifndef __CAM_INFO_H__\n> +#define __CAM_INFO_H__\n> +\n> +#include \n> +\n> +class Info\n> +{\n> +public:\n> +\tint run(const libcamera::CameraConfiguration *config);\n> +};\n> +\n> +#endif /* __CAM_INFO_H__ */\n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index 25538f5ba95552d6..bf7a92b51d27c890 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -13,6 +13,7 @@\n> \n> #include \"capture.h\"\n> #include \"event_loop.h\"\n> +#include \"info.h\"\n> #include \"main.h\"\n> #include \"options.h\"\n> \n> @@ -162,6 +163,8 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \t\t\t \"Set configuration of a camera stream\", \"stream\", true);\n> \tparser.addOption(OptHelp, OptionNone, \"Display this help message\",\n> \t\t\t \"help\");\n> +\tparser.addOption(OptInfo, OptionNone,\n> +\t\t\t \"Display information about stream(s)\", \"info\");\n> \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n> \n> \toptions_ = parser.parse(argc, argv);\n> @@ -259,6 +262,11 @@ int CamApp::run()\n> \t\t\tstd::cout << \"- \" << cam->name() << std::endl;\n> \t}\n> \n> +\tif (options_.isSet(OptInfo)) {\n> +\t\tInfo info;\n> +\t\tinfo.run(config_.get());\n> +\t}\n> +\n> \tif (options_.isSet(OptCapture)) {\n> \t\tCapture capture(camera_.get(), config_.get());\n> \t\treturn capture.run(loop_, options_);\n> diff --git a/src/cam/main.h b/src/cam/main.h\n> index fff81b1f6c860b57..6324c042f89e7396 100644\n> --- a/src/cam/main.h\n> +++ b/src/cam/main.h\n> @@ -12,6 +12,7 @@ enum {\n> \tOptCapture = 'C',\n> \tOptFile = 'F',\n> \tOptHelp = 'h',\n> +\tOptInfo = 'i',\n> \tOptList = 'l',\n> \tOptStream = 's',\n> };\n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index 478346c59590631d..ee5b28421e4c1235 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -2,6 +2,7 @@ cam_sources = files([\n> 'buffer_writer.cpp',\n> 'capture.cpp',\n> 'event_loop.cpp',\n> + 'info.cpp',\n> 'main.cpp',\n> 'options.cpp',\n> ])\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5437C60E46\n\tfor ;\n\tThu, 30 May 2019 00:50:51 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F44A524;\n\tThu, 30 May 2019 00:50:50 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559170250;\n\tbh=iAdpGcFkHBFK9T/0b3eO45enlG5YBPP60Oz8s/hlk8Q=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=kYLII9NR5qmkrslMv4g1S8J8u7WJdJd3brHtGcwzlxQqrBq3dwSiRhqbMuGkIMeq9\n\ty0HgBGCYvkDrF+OuAGpyUS97axBCuYkCcmuYbwINCBo1JgDFyehjAVzAnP/WzVXRR6\n\t3vJpQFq81MFBNQLixFQijI09wq4Tl4hmHc2TP714=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190527001543.13593-1-niklas.soderlund@ragnatech.se>\n\t<20190527001543.13593-17-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 29 May 2019 23:50:47 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190527001543.13593-17-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 16/17] cam: Add --info option to print\n\tinformation about stream(s)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 May 2019 22:50:51 -0000"}},{"id":1814,"web_url":"https://patchwork.libcamera.org/comment/1814/","msgid":"<20190610071048.GF4806@pendragon.ideasonboard.com>","date":"2019-06-10T07:10:48","subject":"Re: [libcamera-devel] [PATCH 16/17] cam: Add --info option to print\n\tinformation about stream(s)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Wed, May 29, 2019 at 11:50:47PM +0100, Kieran Bingham wrote:\n> On 27/05/2019 01:15, Niklas Söderlund wrote:\n> > Add a new option to cam tool which prints information about the\n\ns/to cam tool/to the cam tool/\ns/which/that/\n\n> > configuration supplied by the user.\n> \n> \n> \n> > If specified information is printed\n> > about the configuration after its been verified and possibly adjusted by\n> > the camera and information about each stream in the camera\n> > configuration.\n> \n> That paragraph is hard to interpret. But it's late so perhaps I'm just\n> tired.\n> \n> Do you mean something like:\n> \n> If provided by the pipeline handler, information is printed about the\n> configuration after it has been verified (and potentially adjusted) by\n> the camera and information about each stream in the camera configuration\n> is presented.\n\nIt was hard to parse for me indeed. I think Niklas meant \"If the option\nis specified, information about the configuration is printed after the\nconfiguration has been verified ...\"\n\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/cam/info.cpp | 44 ++++++++++++++++++++++++++++++++++++++++++++\n> > src/cam/info.h | 18 ++++++++++++++++++\n> > src/cam/main.cpp | 8 ++++++++\n> > src/cam/main.h | 1 +\n> > src/cam/meson.build | 1 +\n> > 5 files changed, 72 insertions(+)\n> > create mode 100644 src/cam/info.cpp\n> > create mode 100644 src/cam/info.h\n> > \n> > diff --git a/src/cam/info.cpp b/src/cam/info.cpp\n> > new file mode 100644\n> > index 0000000000000000..35271942600494c7\n> > --- /dev/null\n> > +++ b/src/cam/info.cpp\n> > @@ -0,0 +1,44 @@\n> > +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > +/*\n> > + * Copyright (C) 2019, Google Inc.\n> > + *\n> > + * info.cpp - Displat stream information\n\ns/Displat/Display/\n\n> > + */\n> > +\n> > +#include \n> > +#include \n> > +\n> > +#include \"info.h\"\n> > +\n> > +using namespace libcamera;\n> > +\n> > +int Info::run(const CameraConfiguration *config)\n> > +{\n> > +\tif (!config) {\n> > +\t\tstd::cout\n> > +\t\t\t<< \"Can't display information, no configuration\"\n> > +\t\t\t<< std::endl;\n> > +\t\treturn -ENODEV;\n> > +\t}\n\nIs this possible ? I would remove this check and pass the configuration\nby const reference.\n\n> > +\n> > +\tunsigned int index = 0;\n> > +\tfor (const StreamConfiguration cfg : *config) {\n\n\t const StreamConfiguration &cfg\n\n> > +\t\tstd::cout << index << \": \" << cfg.toString() << std::endl;\n> > +\n> > +\t\tconst StreamFormats &formats = cfg.formats();\n> > +\t\tfor (unsigned int pixelformat : formats.pixelformats()) {\n> > +\t\t\tstd::cout << \" * Pixelformat: 0x\" << std::hex\n> > +\t\t\t\t << std::setw(8) << pixelformat << \" \"\n> > +\t\t\t\t << formats.range(pixelformat).toString()\n> > +\t\t\t\t << std::endl;\n> > +\n> > +\t\t\tfor (const Size &size : formats.sizes(pixelformat))\n> > +\t\t\t\tstd::cout << \" - \" << size.toString()\n> > +\t\t\t\t\t << std::endl;\n> > +\t\t}\n> \n> This looks quite nice:\n> \n> ./build/src/cam/cam -c \"HP Wide Vision FHD Camera: HP W\" -i\n> Using camera HP Wide Vision FHD Camera: HP W\n> 0: 1920x1080-0x47504a4d\n> * Pixelformat: 0x47504a4d Width: 176-1920 Height: 144-1080 hStep: 1\n> vStep: 1\n> - 176x144\n> - 320x240\n> - 352x288\n> - 640x360\n> - 640x480\n> - 1280x720\n> - 1920x1080\n> \n> Except for this bit:\n> * Pixelformat: 0x47504a4d Width: 176-1920 Height: 144-1080 hStep: 1\n> vStep: 1\n> \n> - 176-1920 ?\n> \n> Perhaps should we format this as\n> * Pixelformat 0x47504a4d 176x144 -> 1920x1080 ?\n> \n> Infact, that's a print option in the formats.range() ...\n> \n> > +\n> > +\t\tindex++;\n> > +\t}\n> > +\n> > +\treturn 0;\n> > +}\n> > diff --git a/src/cam/info.h b/src/cam/info.h\n> > new file mode 100644\n> > index 0000000000000000..72fd446491f95033\n> > --- /dev/null\n> > +++ b/src/cam/info.h\n> > @@ -0,0 +1,18 @@\n> > +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > +/*\n> > + * Copyright (C) 2019, Google Inc.\n> > + *\n> > + * info.h - Displat stream information\n> > + */\n> > +#ifndef __CAM_INFO_H__\n> > +#define __CAM_INFO_H__\n> > +\n> > +#include \n> > +\n> > +class Info\n> > +{\n> > +public:\n> > +\tint run(const libcamera::CameraConfiguration *config);\n> > +};\n\nYou don't need a class for this, you can create a global function.\n\n> > +\n> > +#endif /* __CAM_INFO_H__ */\n> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > index 25538f5ba95552d6..bf7a92b51d27c890 100644\n> > --- a/src/cam/main.cpp\n> > +++ b/src/cam/main.cpp\n> > @@ -13,6 +13,7 @@\n> > \n> > #include \"capture.h\"\n> > #include \"event_loop.h\"\n> > +#include \"info.h\"\n> > #include \"main.h\"\n> > #include \"options.h\"\n> > \n> > @@ -162,6 +163,8 @@ int CamApp::parseOptions(int argc, char *argv[])\n> > \t\t\t \"Set configuration of a camera stream\", \"stream\", true);\n> > \tparser.addOption(OptHelp, OptionNone, \"Display this help message\",\n> > \t\t\t \"help\");\n> > +\tparser.addOption(OptInfo, OptionNone,\n> > +\t\t\t \"Display information about stream(s)\", \"info\");\n> > \tparser.addOption(OptList, OptionNone, \"List all cameras\", \"list\");\n> > \n> > \toptions_ = parser.parse(argc, argv);\n> > @@ -259,6 +262,11 @@ int CamApp::run()\n> > \t\t\tstd::cout << \"- \" << cam->name() << std::endl;\n> > \t}\n> > \n> > +\tif (options_.isSet(OptInfo)) {\n> > +\t\tInfo info;\n> > +\t\tinfo.run(config_.get());\n> > +\t}\n> > +\n> > \tif (options_.isSet(OptCapture)) {\n> > \t\tCapture capture(camera_.get(), config_.get());\n> > \t\treturn capture.run(loop_, options_);\n> > diff --git a/src/cam/main.h b/src/cam/main.h\n> > index fff81b1f6c860b57..6324c042f89e7396 100644\n> > --- a/src/cam/main.h\n> > +++ b/src/cam/main.h\n> > @@ -12,6 +12,7 @@ enum {\n> > \tOptCapture = 'C',\n> > \tOptFile = 'F',\n> > \tOptHelp = 'h',\n> > +\tOptInfo = 'i',\n\n-i is usually used for input files, I wonder if it could make sense to\nreserve it for that purpose. One option could be to add a verbose\nargument instead, but one may argue that controlling the display of\nsupported formats explicitly could also be useful.\n\n> > \tOptList = 'l',\n> > \tOptStream = 's',\n> > };\n> > diff --git a/src/cam/meson.build b/src/cam/meson.build\n> > index 478346c59590631d..ee5b28421e4c1235 100644\n> > --- a/src/cam/meson.build\n> > +++ b/src/cam/meson.build\n> > @@ -2,6 +2,7 @@ cam_sources = files([\n> > 'buffer_writer.cpp',\n> > 'capture.cpp',\n> > 'event_loop.cpp',\n> > + 'info.cpp',\n> > 'main.cpp',\n> > 'options.cpp',\n> > ])","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F8DD6376E\n\tfor ;\n\tMon, 10 Jun 2019 09:11:06 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-134-17-nat.elisa-mobile.fi\n\t[85.76.134.17])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DFFF4569;\n\tMon, 10 Jun 2019 09:11:04 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560150665;\n\tbh=dvo6D8AF/zOJfqQi4pGc0ApjyjR3tbwIcmpxuHsktOE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mVwatXw+cW3RUBmO3Yj3X7ro72oKKDPcgeicSxq6MWStuVRy5j7/sQ5bvR10Km+tt\n\t0oAyAKiElJmZdabaLrGqwTjBLZiFfCGL+akQYuzJnb8Bdhsbyf7Wx9NhQ2q1lbs0lJ\n\t81uLEI+e2xZmI/KFhMwFVL8SNY2dvdcw9AlrxbTc=","Date":"Mon, 10 Jun 2019 10:10:48 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190610071048.GF4806@pendragon.ideasonboard.com>","References":"<20190527001543.13593-1-niklas.soderlund@ragnatech.se>\n\t<20190527001543.13593-17-niklas.soderlund@ragnatech.se>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 16/17] cam: Add --info option to print\n\tinformation about stream(s)","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 10 Jun 2019 07:11:06 -0000"}}]