[{"id":18248,"web_url":"https://patchwork.libcamera.org/comment/18248/","msgid":"<CAEmqJPrEyQJUV9ZW=2tTW7xrENtJUegVS6mvJztjCwpWfcF3zg@mail.gmail.com>","date":"2021-07-21T13:10:49","subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Add support for\n\timx378 sensor","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Wed, 21 Jul 2021 at 12:52, David Plowman <david.plowman@raspberrypi.com>\nwrote:\n\n> This commit adds a tuning file for the 12MP imx378 sensor. The sensor\n> actually shares the same driver (and CamHelper) as the imx477 so only\n> a new tuning file is required. The default choice of imx477.json can\n> be overridden by pointing LIBCAMERA_RPI_TUNING_FILE at a version of\n> the new imx378.json file.\n>\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n>\n\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n\n\n> ---\n>  src/ipa/raspberrypi/data/imx378.json | 338 +++++++++++++++++++++++++++\n>  src/ipa/raspberrypi/data/meson.build |   1 +\n>  2 files changed, 339 insertions(+)\n>  create mode 100644 src/ipa/raspberrypi/data/imx378.json\n>\n> diff --git a/src/ipa/raspberrypi/data/imx378.json\n> b/src/ipa/raspberrypi/data/imx378.json\n> new file mode 100644\n> index 00000000..3c2164e2\n> --- /dev/null\n> +++ b/src/ipa/raspberrypi/data/imx378.json\n> @@ -0,0 +1,338 @@\n> +{\n> +    \"rpi.black_level\":\n> +    {\n> +        \"black_level\": 4096\n> +    },\n> +    \"rpi.dpc\":\n> +    {\n> +    },\n> +    \"rpi.lux\":\n> +    {\n> +        \"reference_shutter_speed\": 9999,\n> +        \"reference_gain\": 1.95,\n> +        \"reference_aperture\": 1.0,\n> +        \"reference_lux\": 1000,\n> +        \"reference_Y\": 12996\n> +    },\n> +    \"rpi.noise\":\n> +    {\n> +        \"reference_constant\": 0,\n> +        \"reference_slope\": 2.641\n> +    },\n> +    \"rpi.geq\":\n> +    {\n> +        \"offset\": 235,\n> +        \"slope\": 0.00902\n> +    },\n> +    \"rpi.sdn\":\n> +    {\n> +    },\n> +    \"rpi.awb\":\n> +    {\n> +        \"priors\":\n> +        [\n> +            {\n> +                \"lux\": 0, \"prior\":\n> +                [\n> +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 800, \"prior\":\n> +                [\n> +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 1500, \"prior\":\n> +                [\n> +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000,\n> 1.0, 13000, 1.0\n> +                ]\n> +            }\n> +        ],\n> +        \"modes\":\n> +        {\n> +            \"auto\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 8000\n> +            },\n> +            \"incandescent\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 3000\n> +            },\n> +            \"tungsten\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 3500\n> +            },\n> +            \"fluorescent\":\n> +            {\n> +                \"lo\": 4000,\n> +                \"hi\": 4700\n> +            },\n> +            \"indoor\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 5000\n> +            },\n> +            \"daylight\":\n> +            {\n> +                \"lo\": 5500,\n> +                \"hi\": 6500\n> +            },\n> +            \"cloudy\":\n> +            {\n> +                \"lo\": 7000,\n> +                \"hi\": 8100\n> +            }\n> +        },\n> +        \"bayes\": 1,\n> +        \"ct_curve\":\n> +        [\n> +            2850.0, 0.6361, 0.3911, 3550.0, 0.5386, 0.5077, 4500.0,\n> 0.4472, 0.6171, 5600.0, 0.3906, 0.6848, 8000.0, 0.3412, 0.7441\n> +        ],\n> +        \"sensitivity_r\": 1.0,\n> +        \"sensitivity_b\": 1.0,\n> +        \"transverse_pos\": 0.01667,\n> +        \"transverse_neg\": 0.01195\n> +    },\n> +    \"rpi.agc\":\n> +    {\n> +        \"metering_modes\":\n> +        {\n> +            \"centre-weighted\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n> +                ]\n> +            },\n> +            \"spot\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n> +                ]\n> +            },\n> +            \"matrix\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> +                ]\n> +            }\n> +        },\n> +        \"exposure_modes\":\n> +        {\n> +            \"normal\":\n> +            {\n> +                \"shutter\":\n> +                [\n> +                    100, 10000, 30000, 60000, 120000\n> +                ],\n> +                \"gain\":\n> +                [\n> +                    1.0, 2.0, 4.0, 6.0, 6.0\n> +                ]\n> +            },\n> +            \"short\":\n> +            {\n> +                \"shutter\":\n> +                [\n> +                    100, 5000, 10000, 20000, 120000\n> +                ],\n> +                \"gain\":\n> +                [\n> +                    1.0, 2.0, 4.0, 6.0, 6.0\n> +                ]\n> +            }\n> +        },\n> +        \"constraint_modes\":\n> +        {\n> +            \"normal\":\n> +            [\n> +                {\n> +                    \"bound\": \"LOWER\", \"q_lo\": 0.98, \"q_hi\": 1.0,\n> \"y_target\":\n> +                    [\n> +                        0, 0.5, 1000, 0.5\n> +                    ]\n> +                }\n> +            ],\n> +            \"highlight\":\n> +            [\n> +                {\n> +                    \"bound\": \"LOWER\", \"q_lo\": 0.98, \"q_hi\": 1.0,\n> \"y_target\":\n> +                    [\n> +                        0, 0.5, 1000, 0.5\n> +                    ]\n> +                },\n> +                {\n> +                    \"bound\": \"UPPER\", \"q_lo\": 0.98, \"q_hi\": 1.0,\n> \"y_target\":\n> +                    [\n> +                        0, 0.8, 1000, 0.8\n> +                    ]\n> +                }\n> +            ]\n> +        },\n> +        \"y_target\":\n> +        [\n> +            0, 0.16, 1000, 0.165, 10000, 0.17\n> +        ]\n> +    },\n> +    \"rpi.alsc\":\n> +    {\n> +        \"omega\": 1.3,\n> +        \"n_iter\": 100,\n> +        \"luminance_strength\": 0.5,\n> +        \"calibrations_Cr\":\n> +        [\n> +            {\n> +                \"ct\": 2800, \"table\":\n> +                [\n> +                    1.604, 1.601, 1.593, 1.581, 1.568, 1.561, 1.561,\n> 1.561, 1.561, 1.567, 1.582, 1.596, 1.609, 1.622, 1.632, 1.636,\n> +                    1.601, 1.594, 1.586, 1.571, 1.555, 1.546, 1.543,\n> 1.543, 1.547, 1.555, 1.572, 1.584, 1.599, 1.614, 1.625, 1.632,\n> +                    1.599, 1.586, 1.571, 1.555, 1.542, 1.528, 1.518,\n> 1.518, 1.523, 1.537, 1.555, 1.572, 1.589, 1.607, 1.622, 1.629,\n> +                    1.597, 1.579, 1.561, 1.542, 1.528, 1.512, 1.493,\n> 1.493, 1.499, 1.523, 1.537, 1.563, 1.582, 1.601, 1.619, 1.629,\n> +                    1.597, 1.577, 1.557, 1.535, 1.512, 1.493, 1.481,\n> 1.479, 1.492, 1.499, 1.524, 1.555, 1.578, 1.599, 1.619, 1.629,\n> +                    1.597, 1.577, 1.557, 1.534, 1.508, 1.483, 1.476,\n> 1.476, 1.481, 1.496, 1.522, 1.554, 1.578, 1.599, 1.619, 1.629,\n> +                    1.597, 1.578, 1.557, 1.534, 1.508, 1.483, 1.481,\n> 1.479, 1.481, 1.496, 1.522, 1.554, 1.579, 1.601, 1.619, 1.631,\n> +                    1.597, 1.581, 1.562, 1.539, 1.517, 1.504, 1.483,\n> 1.481, 1.496, 1.511, 1.531, 1.561, 1.585, 1.607, 1.623, 1.632,\n> +                    1.601, 1.589, 1.569, 1.554, 1.539, 1.517, 1.504,\n> 1.504, 1.511, 1.531, 1.553, 1.573, 1.596, 1.614, 1.629, 1.636,\n> +                    1.609, 1.601, 1.586, 1.569, 1.554, 1.542, 1.535,\n> 1.535, 1.541, 1.553, 1.573, 1.592, 1.608, 1.625, 1.637, 1.645,\n> +                    1.617, 1.611, 1.601, 1.586, 1.574, 1.565, 1.564,\n> 1.564, 1.571, 1.579, 1.592, 1.608, 1.622, 1.637, 1.646, 1.654,\n> +                    1.619, 1.617, 1.611, 1.601, 1.588, 1.585, 1.585,\n> 1.585, 1.588, 1.592, 1.607, 1.622, 1.637, 1.645, 1.654, 1.655\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5500, \"table\":\n> +                [\n> +                    2.664, 2.658, 2.645, 2.629, 2.602, 2.602, 2.602,\n> 2.606, 2.617, 2.628, 2.649, 2.677, 2.699, 2.722, 2.736, 2.747,\n> +                    2.658, 2.653, 2.629, 2.605, 2.576, 2.575, 2.577,\n> 2.592, 2.606, 2.618, 2.629, 2.651, 2.678, 2.707, 2.727, 2.741,\n> +                    2.649, 2.631, 2.605, 2.576, 2.563, 2.552, 2.552,\n> 2.557, 2.577, 2.604, 2.619, 2.641, 2.669, 2.698, 2.721, 2.741,\n> +                    2.643, 2.613, 2.583, 2.563, 2.552, 2.531, 2.527,\n> 2.527, 2.551, 2.577, 2.604, 2.638, 2.665, 2.694, 2.721, 2.741,\n> +                    2.643, 2.606, 2.575, 2.558, 2.531, 2.516, 2.504,\n> 2.516, 2.527, 2.551, 2.596, 2.635, 2.665, 2.694, 2.721, 2.741,\n> +                    2.643, 2.606, 2.575, 2.558, 2.531, 2.503, 2.501,\n> 2.502, 2.522, 2.551, 2.592, 2.635, 2.669, 2.696, 2.727, 2.744,\n> +                    2.648, 2.611, 2.579, 2.558, 2.532, 2.511, 2.502,\n> 2.511, 2.522, 2.552, 2.592, 2.642, 2.673, 2.702, 2.731, 2.752,\n> +                    2.648, 2.619, 2.589, 2.571, 2.556, 2.532, 2.519,\n> 2.522, 2.552, 2.568, 2.605, 2.648, 2.683, 2.715, 2.743, 2.758,\n> +                    2.659, 2.637, 2.613, 2.589, 2.571, 2.556, 2.555,\n> 2.555, 2.568, 2.605, 2.641, 2.671, 2.699, 2.729, 2.758, 2.776,\n> +                    2.679, 2.665, 2.637, 2.613, 2.602, 2.599, 2.599,\n> 2.606, 2.619, 2.641, 2.671, 2.698, 2.723, 2.754, 2.776, 2.787,\n> +                    2.695, 2.684, 2.671, 2.646, 2.636, 2.636, 2.641,\n> 2.648, 2.661, 2.681, 2.698, 2.723, 2.751, 2.776, 2.788, 2.803,\n> +                    2.702, 2.699, 2.684, 2.671, 2.664, 2.664, 2.664,\n> 2.668, 2.681, 2.698, 2.723, 2.751, 2.773, 2.788, 2.803, 2.805\n> +                ]\n> +            }\n> +        ],\n> +        \"calibrations_Cb\":\n> +        [\n> +            {\n> +                \"ct\": 2800, \"table\":\n> +                [\n> +                    2.876, 2.868, 2.863, 2.851, 2.846, 2.846, 2.847,\n> 2.851, 2.851, 2.857, 2.867, 2.875, 2.889, 2.899, 2.913, 2.926,\n> +                    2.863, 2.861, 2.856, 2.846, 2.846, 2.847, 2.848,\n> 2.851, 2.857, 2.859, 2.875, 2.882, 2.886, 2.896, 2.909, 2.917,\n> +                    2.861, 2.856, 2.846, 2.841, 2.841, 2.855, 2.867,\n> 2.875, 2.888, 2.888, 2.885, 2.883, 2.886, 2.889, 2.901, 2.913,\n> +                    2.858, 2.851, 2.846, 2.846, 2.855, 2.867, 2.884,\n> 2.895, 2.902, 2.902, 2.901, 2.891, 2.891, 2.894, 2.901, 2.909,\n> +                    2.858, 2.851, 2.846, 2.846, 2.867, 2.884, 2.895,\n> 2.902, 2.909, 2.915, 2.911, 2.901, 2.895, 2.898, 2.904, 2.909,\n> +                    2.858, 2.851, 2.849, 2.853, 2.874, 2.888, 2.901,\n> 2.909, 2.917, 2.922, 2.917, 2.911, 2.901, 2.899, 2.905, 2.908,\n> +                    2.861, 2.855, 2.853, 2.855, 2.874, 2.888, 2.901,\n> 2.913, 2.918, 2.922, 2.921, 2.911, 2.901, 2.901, 2.907, 2.908,\n> +                    2.862, 2.859, 2.855, 2.856, 2.872, 2.885, 2.899,\n> 2.906, 2.915, 2.917, 2.911, 2.907, 2.907, 2.907, 2.908, 2.909,\n> +                    2.863, 2.863, 2.859, 2.864, 2.871, 2.881, 2.885,\n> 2.899, 2.905, 2.905, 2.904, 2.904, 2.907, 2.909, 2.913, 2.913,\n> +                    2.866, 2.865, 2.865, 2.867, 2.868, 2.872, 2.881,\n> 2.885, 2.889, 2.894, 2.895, 2.902, 2.906, 2.913, 2.914, 2.917,\n> +                    2.875, 2.875, 2.871, 2.871, 2.871, 2.871, 2.869,\n> 2.869, 2.878, 2.889, 2.894, 2.895, 2.906, 2.914, 2.917, 2.921,\n> +                    2.882, 2.879, 2.876, 2.874, 2.871, 2.871, 2.869,\n> 2.869, 2.869, 2.878, 2.891, 2.894, 2.905, 2.914, 2.919, 2.921\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5500, \"table\":\n> +                [\n> +                    1.488, 1.488, 1.488, 1.488, 1.491, 1.492, 1.492,\n> 1.491, 1.491, 1.491, 1.492, 1.495, 1.497, 1.499, 1.499, 1.503,\n> +                    1.482, 1.485, 1.485, 1.487, 1.489, 1.492, 1.492,\n> 1.492, 1.492, 1.492, 1.494, 1.494, 1.492, 1.491, 1.493, 1.494,\n> +                    1.482, 1.482, 1.484, 1.485, 1.487, 1.492, 1.496,\n> 1.498, 1.499, 1.498, 1.494, 1.492, 1.491, 1.491, 1.491, 1.491,\n> +                    1.481, 1.481, 1.482, 1.485, 1.491, 1.496, 1.498,\n> 1.499, 1.501, 1.499, 1.498, 1.493, 1.491, 1.488, 1.488, 1.488,\n> +                    1.481, 1.481, 1.481, 1.483, 1.491, 1.497, 1.498,\n> 1.499, 1.501, 1.499, 1.498, 1.492, 1.488, 1.485, 1.483, 1.483,\n> +                    1.479, 1.479, 1.481, 1.482, 1.489, 1.495, 1.497,\n> 1.498, 1.499, 1.499, 1.495, 1.492, 1.485, 1.482, 1.482, 1.481,\n> +                    1.479, 1.479, 1.479, 1.481, 1.489, 1.494, 1.496,\n> 1.497, 1.497, 1.496, 1.495, 1.489, 1.482, 1.481, 1.479, 1.477,\n> +                    1.478, 1.478, 1.479, 1.481, 1.487, 1.491, 1.494,\n> 1.496, 1.496, 1.495, 1.492, 1.487, 1.482, 1.479, 1.478, 1.476,\n> +                    1.478, 1.478, 1.479, 1.482, 1.486, 1.488, 1.491,\n> 1.493, 1.493, 1.492, 1.487, 1.484, 1.481, 1.479, 1.476, 1.476,\n> +                    1.477, 1.479, 1.481, 1.483, 1.485, 1.486, 1.488,\n> 1.488, 1.487, 1.487, 1.484, 1.483, 1.481, 1.479, 1.476, 1.476,\n> +                    1.477, 1.479, 1.482, 1.483, 1.484, 1.485, 1.484,\n> 1.482, 1.482, 1.484, 1.483, 1.482, 1.481, 1.479, 1.477, 1.476,\n> +                    1.477, 1.479, 1.482, 1.483, 1.484, 1.484, 1.482,\n> 1.482, 1.482, 1.482, 1.482, 1.481, 1.479, 1.479, 1.479, 1.479\n> +                ]\n> +            }\n> +        ],\n> +        \"luminance_lut\":\n> +        [\n> +            2.764, 2.654, 2.321, 2.043, 1.768, 1.594, 1.558, 1.558,\n> 1.558, 1.568, 1.661, 1.904, 2.193, 2.497, 2.888, 3.043,\n> +            2.654, 2.373, 2.049, 1.819, 1.569, 1.446, 1.381, 1.356,\n> 1.356, 1.403, 1.501, 1.679, 1.939, 2.218, 2.586, 2.888,\n> +            2.376, 2.154, 1.819, 1.569, 1.438, 1.301, 1.246, 1.224,\n> 1.224, 1.263, 1.349, 1.501, 1.679, 1.985, 2.359, 2.609,\n> +            2.267, 1.987, 1.662, 1.438, 1.301, 1.235, 1.132, 1.105,\n> 1.105, 1.164, 1.263, 1.349, 1.528, 1.808, 2.184, 2.491,\n> +            2.218, 1.876, 1.568, 1.367, 1.235, 1.132, 1.087, 1.022,\n> 1.023, 1.104, 1.164, 1.278, 1.439, 1.695, 2.066, 2.429,\n> +            2.218, 1.832, 1.533, 1.341, 1.206, 1.089, 1.013, 1.002,\n> 1.013, 1.026, 1.122, 1.246, 1.399, 1.642, 2.004, 2.426,\n> +            2.218, 1.832, 1.533, 1.341, 1.206, 1.089, 1.011, 1.001,\n> 1.009, 1.026, 1.122, 1.246, 1.399, 1.642, 2.004, 2.426,\n> +            2.224, 1.896, 1.584, 1.382, 1.248, 1.147, 1.088, 1.016,\n> 1.026, 1.118, 1.168, 1.283, 1.444, 1.697, 2.066, 2.428,\n> +            2.292, 2.019, 1.689, 1.462, 1.322, 1.247, 1.147, 1.118,\n> 1.118, 1.168, 1.275, 1.358, 1.532, 1.809, 2.189, 2.491,\n> +            2.444, 2.204, 1.856, 1.606, 1.462, 1.322, 1.257, 1.234,\n> 1.234, 1.275, 1.358, 1.516, 1.686, 1.993, 2.371, 2.622,\n> +            2.748, 2.444, 2.108, 1.856, 1.606, 1.476, 1.399, 1.376,\n> 1.376, 1.422, 1.516, 1.686, 1.968, 2.238, 2.611, 2.935,\n> +            2.862, 2.748, 2.395, 2.099, 1.811, 1.621, 1.582, 1.582,\n> 1.582, 1.592, 1.677, 1.919, 2.223, 2.534, 2.935, 3.078\n> +        ],\n> +        \"sigma\": 0.00428,\n> +        \"sigma_Cb\": 0.00363\n> +    },\n> +    \"rpi.contrast\":\n> +    {\n> +        \"ce_enable\": 1,\n> +        \"gamma_curve\":\n> +        [\n> +            0, 0, 1024, 5040, 2048, 9338, 3072, 12356, 4096, 15312, 5120,\n> 18051, 6144, 20790, 7168, 23193,\n> +            8192, 25744, 9216, 27942, 10240, 30035, 11264, 32005, 12288,\n> 33975, 13312, 35815, 14336, 37600, 15360, 39168,\n> +            16384, 40642, 18432, 43379, 20480, 45749, 22528, 47753,\n> 24576, 49621, 26624, 51253, 28672, 52698, 30720, 53796,\n> +            32768, 54876, 36864, 57012, 40960, 58656, 45056, 59954,\n> 49152, 61183, 53248, 62355, 57344, 63419, 61440, 64476,\n> +            65535, 65535\n> +        ]\n> +    },\n> +    \"rpi.ccm\":\n> +    {\n> +        \"ccms\":\n> +        [\n> +            {\n> +                \"ct\": 2850, \"ccm\":\n> +                [\n> +                    1.42601, -0.20537, -0.22063, -0.47682, 1.81987,\n> -0.34305, 0.01854, -0.86036, 1.84181\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2900, \"ccm\":\n> +                [\n> +                    1.29755, 0.04602, -0.34356, -0.41491, 1.73477,\n> -0.31987, -0.01345, -0.97115, 1.98459\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 3550, \"ccm\":\n> +                [\n> +                    1.49811, -0.33412, -0.16398, -0.40869, 1.72995,\n> -0.32127, -0.01924, -0.62181, 1.64105\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 4500, \"ccm\":\n> +                [\n> +                    1.47015, -0.29229, -0.17786, -0.36561, 1.88919,\n> -0.52358, -0.03552, -0.56717, 1.60269\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5600, \"ccm\":\n> +                [\n> +                    1.60962, -0.47434, -0.13528, -0.32701, 1.73797,\n> -0.41096, -0.07626, -0.40171, 1.47796\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 8000, \"ccm\":\n> +                [\n> +                    1.54642, -0.20396, -0.34246, -0.31748, 2.22559,\n> -0.90811, -0.10035, -0.65877, 1.75912\n> +                ]\n> +            }\n> +        ]\n> +    },\n> +    \"rpi.sharpen\":\n> +    {\n> +    }\n> +}\n> diff --git a/src/ipa/raspberrypi/data/meson.build\n> b/src/ipa/raspberrypi/data/meson.build\n> index abb1f928..68433fc2 100644\n> --- a/src/ipa/raspberrypi/data/meson.build\n> +++ b/src/ipa/raspberrypi/data/meson.build\n> @@ -3,6 +3,7 @@\n>  conf_files = files([\n>      'imx219.json',\n>      'imx290.json',\n> +    'imx378.json',\n>      'imx477.json',\n>      'ov5647.json',\n>      'ov9281.json',\n> --\n> 2.20.1\n>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD4ADC0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Jul 2021 13:11:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8612868542;\n\tWed, 21 Jul 2021 15:11:07 +0200 (CEST)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F65E60276\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jul 2021 15:11:06 +0200 (CEST)","by mail-lf1-x12f.google.com with SMTP id s13so3031773lfi.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jul 2021 06:11:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"NjIFd75o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=MRQxBezMTBhBtEOHl3Mwwt3YvC9u95gWFXSEVr9qy/4=;\n\tb=NjIFd75oiB0OTlKaxLqJTjwl4ygI9TNWFamp13N674aIfHM8ZdbPVL8Wfs7DmAcMYj\n\tn7H4yHKytsi3nD2lQJdNdXWuCFQ5zqqM5ncp3RLQDNspR3SQot12o3uKRcVA1DoZwyR3\n\tsnpwMejqp4btooeJ1sn0Rl3IosSaQQXdtyVBik2dSPGZNhCtk/3/5CW4QbQ8RdIeRw4E\n\tcqEQKDKF0Lycs/9MLd1rJt3xLfNl9+hTE7u7rHGHO6eeU9qjl5/cv5igr4YSvULYd/kX\n\tbeSWYvZmRJBnsmRHaJg2+AITU+I8UVhMxdgrvRNYcam9j9eLsM7QCmweqZmMMEt0wAjH\n\te9bA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=MRQxBezMTBhBtEOHl3Mwwt3YvC9u95gWFXSEVr9qy/4=;\n\tb=UZclbcJ7HQXtaHPdTIDOj69zKe6/y7wPcMi8rmqZ3hAyqMd1RZhKcxCrYJFMEtyp3E\n\td6t6X/8l0XgyPpXBEK2QYzqFLylebv3vI5kvBv/iC8mPAq3F67DPE9+WvW80SqZKbkd3\n\tvP/PEswd+5QRlWZEti7SzVHgWQEztpLj/nk1IZ01zN6p0Ggpq6Kab9ApBvjfuibj7qse\n\t0mcmQBIxUHu1MJYa7knqhAw1B6nBZlvKRAH/pTDguzf9qLiPvo3ystoJ5y0kwgbXaB/F\n\tmgY7UeF0sGIEMIxFEYOvcdrVY6m/c4nDq3a83C3/FwUDmzs6aGUpn6Gvr+I+ok+zL6BB\n\tFV8w==","X-Gm-Message-State":"AOAM532CXTTOwUi5sXucu2YSYRN1qs1y2PrRiRRIpeYts7DGZkq8j9cn\n\tW6JgV9n5R00kp+AnP+E6XwbQLUlfj9rH3vBHcLa93g==","X-Google-Smtp-Source":"ABdhPJyIPLlE+EB0mlYqXb5O0SticYBYPdJv6SzzDGNtoSuCQz4M6UMPqGxbQsKIr5c7mvrcu7gtylj3HpG3lZclnrs=","X-Received":"by 2002:a19:7716:: with SMTP id\n\ts22mr25540024lfc.272.1626873065601; \n\tWed, 21 Jul 2021 06:11:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-4-david.plowman@raspberrypi.com>","In-Reply-To":"<20210721115220.5090-4-david.plowman@raspberrypi.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Wed, 21 Jul 2021 14:10:49 +0100","Message-ID":"<CAEmqJPrEyQJUV9ZW=2tTW7xrENtJUegVS6mvJztjCwpWfcF3zg@mail.gmail.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Content-Type":"multipart/alternative; boundary=\"0000000000002b961b05c7a1e7d7\"","Subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Add support for\n\timx378 sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":18357,"web_url":"https://patchwork.libcamera.org/comment/18357/","msgid":"<3d637fe5-2fe3-203a-f546-6ddbf47fef3f@ideasonboard.com>","date":"2021-07-26T10:35:52","subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Add support for\n\timx378 sensor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 21/07/2021 12:52, David Plowman wrote:\n> This commit adds a tuning file for the 12MP imx378 sensor. The sensor\n> actually shares the same driver (and CamHelper) as the imx477 so only\n> a new tuning file is required. The default choice of imx477.json can\n> be overridden by pointing LIBCAMERA_RPI_TUNING_FILE at a version of\n> the new imx378.json file.\n> \n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/ipa/raspberrypi/data/imx378.json | 338 +++++++++++++++++++++++++++\n>  src/ipa/raspberrypi/data/meson.build |   1 +\n>  2 files changed, 339 insertions(+)\n>  create mode 100644 src/ipa/raspberrypi/data/imx378.json\n> \n> diff --git a/src/ipa/raspberrypi/data/imx378.json b/src/ipa/raspberrypi/data/imx378.json\n> new file mode 100644\n> index 00000000..3c2164e2\n> --- /dev/null\n> +++ b/src/ipa/raspberrypi/data/imx378.json\n> @@ -0,0 +1,338 @@\n> +{\n> +    \"rpi.black_level\":\n> +    {\n> +        \"black_level\": 4096\n> +    },\n> +    \"rpi.dpc\":\n> +    {\n> +    },\n> +    \"rpi.lux\":\n> +    {\n> +        \"reference_shutter_speed\": 9999,\n> +        \"reference_gain\": 1.95,\n> +        \"reference_aperture\": 1.0,\n> +        \"reference_lux\": 1000,\n> +        \"reference_Y\": 12996\n> +    },\n> +    \"rpi.noise\":\n> +    {\n> +        \"reference_constant\": 0,\n> +        \"reference_slope\": 2.641\n> +    },\n> +    \"rpi.geq\":\n> +    {\n> +        \"offset\": 235,\n> +        \"slope\": 0.00902\n> +    },\n> +    \"rpi.sdn\":\n> +    {\n> +    },\n> +    \"rpi.awb\":\n> +    {\n> +        \"priors\":\n> +        [\n> +            {\n> +                \"lux\": 0, \"prior\":\n> +                [\n> +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 800, \"prior\":\n> +                [\n> +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 1500, \"prior\":\n> +                [\n> +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000, 1.0, 13000, 1.0\n> +                ]\n> +            }\n> +        ],\n> +        \"modes\":\n> +        {\n> +            \"auto\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 8000\n> +            },\n> +            \"incandescent\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 3000\n> +            },\n> +            \"tungsten\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 3500\n> +            },\n> +            \"fluorescent\":\n> +            {\n> +                \"lo\": 4000,\n> +                \"hi\": 4700\n> +            },\n> +            \"indoor\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 5000\n> +            },\n> +            \"daylight\":\n> +            {\n> +                \"lo\": 5500,\n> +                \"hi\": 6500\n> +            },\n> +            \"cloudy\":\n> +            {\n> +                \"lo\": 7000,\n> +                \"hi\": 8100\n> +            }\n> +        },\n> +        \"bayes\": 1,\n> +        \"ct_curve\":\n> +        [\n> +            2850.0, 0.6361, 0.3911, 3550.0, 0.5386, 0.5077, 4500.0, 0.4472, 0.6171, 5600.0, 0.3906, 0.6848, 8000.0, 0.3412, 0.7441\n> +        ],\n> +        \"sensitivity_r\": 1.0,\n> +        \"sensitivity_b\": 1.0,\n> +        \"transverse_pos\": 0.01667,\n> +        \"transverse_neg\": 0.01195\n> +    },\n> +    \"rpi.agc\":\n> +    {\n> +        \"metering_modes\":\n> +        {\n> +            \"centre-weighted\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n> +                ]\n> +            },\n> +            \"spot\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n> +                ]\n> +            },\n> +            \"matrix\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> +                ]\n> +            }\n> +        },\n> +        \"exposure_modes\":\n> +        {\n> +            \"normal\":\n> +            {\n> +                \"shutter\":\n> +                [\n> +                    100, 10000, 30000, 60000, 120000\n> +                ],\n> +                \"gain\":\n> +                [\n> +                    1.0, 2.0, 4.0, 6.0, 6.0\n> +                ]\n> +            },\n> +            \"short\":\n> +            {\n> +                \"shutter\":\n> +                [\n> +                    100, 5000, 10000, 20000, 120000\n> +                ],\n> +                \"gain\":\n> +                [\n> +                    1.0, 2.0, 4.0, 6.0, 6.0\n> +                ]\n> +            }\n> +        },\n> +        \"constraint_modes\":\n> +        {\n> +            \"normal\":\n> +            [\n> +                {\n> +                    \"bound\": \"LOWER\", \"q_lo\": 0.98, \"q_hi\": 1.0, \"y_target\":\n> +                    [\n> +                        0, 0.5, 1000, 0.5\n> +                    ]\n> +                }\n> +            ],\n> +            \"highlight\":\n> +            [\n> +                {\n> +                    \"bound\": \"LOWER\", \"q_lo\": 0.98, \"q_hi\": 1.0, \"y_target\":\n> +                    [\n> +                        0, 0.5, 1000, 0.5\n> +                    ]\n> +                },\n> +                {\n> +                    \"bound\": \"UPPER\", \"q_lo\": 0.98, \"q_hi\": 1.0, \"y_target\":\n> +                    [\n> +                        0, 0.8, 1000, 0.8\n> +                    ]\n> +                }\n> +            ]\n> +        },\n> +        \"y_target\":\n> +        [\n> +            0, 0.16, 1000, 0.165, 10000, 0.17\n> +        ]\n> +    },\n> +    \"rpi.alsc\":\n> +    {\n> +        \"omega\": 1.3,\n> +        \"n_iter\": 100,\n> +        \"luminance_strength\": 0.5,\n> +        \"calibrations_Cr\":\n> +        [\n> +            {\n> +                \"ct\": 2800, \"table\":\n> +                [\n> +                    1.604, 1.601, 1.593, 1.581, 1.568, 1.561, 1.561, 1.561, 1.561, 1.567, 1.582, 1.596, 1.609, 1.622, 1.632, 1.636,\n> +                    1.601, 1.594, 1.586, 1.571, 1.555, 1.546, 1.543, 1.543, 1.547, 1.555, 1.572, 1.584, 1.599, 1.614, 1.625, 1.632,\n> +                    1.599, 1.586, 1.571, 1.555, 1.542, 1.528, 1.518, 1.518, 1.523, 1.537, 1.555, 1.572, 1.589, 1.607, 1.622, 1.629,\n> +                    1.597, 1.579, 1.561, 1.542, 1.528, 1.512, 1.493, 1.493, 1.499, 1.523, 1.537, 1.563, 1.582, 1.601, 1.619, 1.629,\n> +                    1.597, 1.577, 1.557, 1.535, 1.512, 1.493, 1.481, 1.479, 1.492, 1.499, 1.524, 1.555, 1.578, 1.599, 1.619, 1.629,\n> +                    1.597, 1.577, 1.557, 1.534, 1.508, 1.483, 1.476, 1.476, 1.481, 1.496, 1.522, 1.554, 1.578, 1.599, 1.619, 1.629,\n> +                    1.597, 1.578, 1.557, 1.534, 1.508, 1.483, 1.481, 1.479, 1.481, 1.496, 1.522, 1.554, 1.579, 1.601, 1.619, 1.631,\n> +                    1.597, 1.581, 1.562, 1.539, 1.517, 1.504, 1.483, 1.481, 1.496, 1.511, 1.531, 1.561, 1.585, 1.607, 1.623, 1.632,\n> +                    1.601, 1.589, 1.569, 1.554, 1.539, 1.517, 1.504, 1.504, 1.511, 1.531, 1.553, 1.573, 1.596, 1.614, 1.629, 1.636,\n> +                    1.609, 1.601, 1.586, 1.569, 1.554, 1.542, 1.535, 1.535, 1.541, 1.553, 1.573, 1.592, 1.608, 1.625, 1.637, 1.645,\n> +                    1.617, 1.611, 1.601, 1.586, 1.574, 1.565, 1.564, 1.564, 1.571, 1.579, 1.592, 1.608, 1.622, 1.637, 1.646, 1.654,\n> +                    1.619, 1.617, 1.611, 1.601, 1.588, 1.585, 1.585, 1.585, 1.588, 1.592, 1.607, 1.622, 1.637, 1.645, 1.654, 1.655\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5500, \"table\":\n> +                [\n> +                    2.664, 2.658, 2.645, 2.629, 2.602, 2.602, 2.602, 2.606, 2.617, 2.628, 2.649, 2.677, 2.699, 2.722, 2.736, 2.747,\n> +                    2.658, 2.653, 2.629, 2.605, 2.576, 2.575, 2.577, 2.592, 2.606, 2.618, 2.629, 2.651, 2.678, 2.707, 2.727, 2.741,\n> +                    2.649, 2.631, 2.605, 2.576, 2.563, 2.552, 2.552, 2.557, 2.577, 2.604, 2.619, 2.641, 2.669, 2.698, 2.721, 2.741,\n> +                    2.643, 2.613, 2.583, 2.563, 2.552, 2.531, 2.527, 2.527, 2.551, 2.577, 2.604, 2.638, 2.665, 2.694, 2.721, 2.741,\n> +                    2.643, 2.606, 2.575, 2.558, 2.531, 2.516, 2.504, 2.516, 2.527, 2.551, 2.596, 2.635, 2.665, 2.694, 2.721, 2.741,\n> +                    2.643, 2.606, 2.575, 2.558, 2.531, 2.503, 2.501, 2.502, 2.522, 2.551, 2.592, 2.635, 2.669, 2.696, 2.727, 2.744,\n> +                    2.648, 2.611, 2.579, 2.558, 2.532, 2.511, 2.502, 2.511, 2.522, 2.552, 2.592, 2.642, 2.673, 2.702, 2.731, 2.752,\n> +                    2.648, 2.619, 2.589, 2.571, 2.556, 2.532, 2.519, 2.522, 2.552, 2.568, 2.605, 2.648, 2.683, 2.715, 2.743, 2.758,\n> +                    2.659, 2.637, 2.613, 2.589, 2.571, 2.556, 2.555, 2.555, 2.568, 2.605, 2.641, 2.671, 2.699, 2.729, 2.758, 2.776,\n> +                    2.679, 2.665, 2.637, 2.613, 2.602, 2.599, 2.599, 2.606, 2.619, 2.641, 2.671, 2.698, 2.723, 2.754, 2.776, 2.787,\n> +                    2.695, 2.684, 2.671, 2.646, 2.636, 2.636, 2.641, 2.648, 2.661, 2.681, 2.698, 2.723, 2.751, 2.776, 2.788, 2.803,\n> +                    2.702, 2.699, 2.684, 2.671, 2.664, 2.664, 2.664, 2.668, 2.681, 2.698, 2.723, 2.751, 2.773, 2.788, 2.803, 2.805\n> +                ]\n> +            }\n> +        ],\n> +        \"calibrations_Cb\":\n> +        [\n> +            {\n> +                \"ct\": 2800, \"table\":\n> +                [\n> +                    2.876, 2.868, 2.863, 2.851, 2.846, 2.846, 2.847, 2.851, 2.851, 2.857, 2.867, 2.875, 2.889, 2.899, 2.913, 2.926,\n> +                    2.863, 2.861, 2.856, 2.846, 2.846, 2.847, 2.848, 2.851, 2.857, 2.859, 2.875, 2.882, 2.886, 2.896, 2.909, 2.917,\n> +                    2.861, 2.856, 2.846, 2.841, 2.841, 2.855, 2.867, 2.875, 2.888, 2.888, 2.885, 2.883, 2.886, 2.889, 2.901, 2.913,\n> +                    2.858, 2.851, 2.846, 2.846, 2.855, 2.867, 2.884, 2.895, 2.902, 2.902, 2.901, 2.891, 2.891, 2.894, 2.901, 2.909,\n> +                    2.858, 2.851, 2.846, 2.846, 2.867, 2.884, 2.895, 2.902, 2.909, 2.915, 2.911, 2.901, 2.895, 2.898, 2.904, 2.909,\n> +                    2.858, 2.851, 2.849, 2.853, 2.874, 2.888, 2.901, 2.909, 2.917, 2.922, 2.917, 2.911, 2.901, 2.899, 2.905, 2.908,\n> +                    2.861, 2.855, 2.853, 2.855, 2.874, 2.888, 2.901, 2.913, 2.918, 2.922, 2.921, 2.911, 2.901, 2.901, 2.907, 2.908,\n> +                    2.862, 2.859, 2.855, 2.856, 2.872, 2.885, 2.899, 2.906, 2.915, 2.917, 2.911, 2.907, 2.907, 2.907, 2.908, 2.909,\n> +                    2.863, 2.863, 2.859, 2.864, 2.871, 2.881, 2.885, 2.899, 2.905, 2.905, 2.904, 2.904, 2.907, 2.909, 2.913, 2.913,\n> +                    2.866, 2.865, 2.865, 2.867, 2.868, 2.872, 2.881, 2.885, 2.889, 2.894, 2.895, 2.902, 2.906, 2.913, 2.914, 2.917,\n> +                    2.875, 2.875, 2.871, 2.871, 2.871, 2.871, 2.869, 2.869, 2.878, 2.889, 2.894, 2.895, 2.906, 2.914, 2.917, 2.921,\n> +                    2.882, 2.879, 2.876, 2.874, 2.871, 2.871, 2.869, 2.869, 2.869, 2.878, 2.891, 2.894, 2.905, 2.914, 2.919, 2.921\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5500, \"table\":\n> +                [\n> +                    1.488, 1.488, 1.488, 1.488, 1.491, 1.492, 1.492, 1.491, 1.491, 1.491, 1.492, 1.495, 1.497, 1.499, 1.499, 1.503,\n> +                    1.482, 1.485, 1.485, 1.487, 1.489, 1.492, 1.492, 1.492, 1.492, 1.492, 1.494, 1.494, 1.492, 1.491, 1.493, 1.494,\n> +                    1.482, 1.482, 1.484, 1.485, 1.487, 1.492, 1.496, 1.498, 1.499, 1.498, 1.494, 1.492, 1.491, 1.491, 1.491, 1.491,\n> +                    1.481, 1.481, 1.482, 1.485, 1.491, 1.496, 1.498, 1.499, 1.501, 1.499, 1.498, 1.493, 1.491, 1.488, 1.488, 1.488,\n> +                    1.481, 1.481, 1.481, 1.483, 1.491, 1.497, 1.498, 1.499, 1.501, 1.499, 1.498, 1.492, 1.488, 1.485, 1.483, 1.483,\n> +                    1.479, 1.479, 1.481, 1.482, 1.489, 1.495, 1.497, 1.498, 1.499, 1.499, 1.495, 1.492, 1.485, 1.482, 1.482, 1.481,\n> +                    1.479, 1.479, 1.479, 1.481, 1.489, 1.494, 1.496, 1.497, 1.497, 1.496, 1.495, 1.489, 1.482, 1.481, 1.479, 1.477,\n> +                    1.478, 1.478, 1.479, 1.481, 1.487, 1.491, 1.494, 1.496, 1.496, 1.495, 1.492, 1.487, 1.482, 1.479, 1.478, 1.476,\n> +                    1.478, 1.478, 1.479, 1.482, 1.486, 1.488, 1.491, 1.493, 1.493, 1.492, 1.487, 1.484, 1.481, 1.479, 1.476, 1.476,\n> +                    1.477, 1.479, 1.481, 1.483, 1.485, 1.486, 1.488, 1.488, 1.487, 1.487, 1.484, 1.483, 1.481, 1.479, 1.476, 1.476,\n> +                    1.477, 1.479, 1.482, 1.483, 1.484, 1.485, 1.484, 1.482, 1.482, 1.484, 1.483, 1.482, 1.481, 1.479, 1.477, 1.476,\n> +                    1.477, 1.479, 1.482, 1.483, 1.484, 1.484, 1.482, 1.482, 1.482, 1.482, 1.482, 1.481, 1.479, 1.479, 1.479, 1.479\n> +                ]\n> +            }\n> +        ],\n> +        \"luminance_lut\":\n> +        [\n> +            2.764, 2.654, 2.321, 2.043, 1.768, 1.594, 1.558, 1.558, 1.558, 1.568, 1.661, 1.904, 2.193, 2.497, 2.888, 3.043,\n> +            2.654, 2.373, 2.049, 1.819, 1.569, 1.446, 1.381, 1.356, 1.356, 1.403, 1.501, 1.679, 1.939, 2.218, 2.586, 2.888,\n> +            2.376, 2.154, 1.819, 1.569, 1.438, 1.301, 1.246, 1.224, 1.224, 1.263, 1.349, 1.501, 1.679, 1.985, 2.359, 2.609,\n> +            2.267, 1.987, 1.662, 1.438, 1.301, 1.235, 1.132, 1.105, 1.105, 1.164, 1.263, 1.349, 1.528, 1.808, 2.184, 2.491,\n> +            2.218, 1.876, 1.568, 1.367, 1.235, 1.132, 1.087, 1.022, 1.023, 1.104, 1.164, 1.278, 1.439, 1.695, 2.066, 2.429,\n> +            2.218, 1.832, 1.533, 1.341, 1.206, 1.089, 1.013, 1.002, 1.013, 1.026, 1.122, 1.246, 1.399, 1.642, 2.004, 2.426,\n> +            2.218, 1.832, 1.533, 1.341, 1.206, 1.089, 1.011, 1.001, 1.009, 1.026, 1.122, 1.246, 1.399, 1.642, 2.004, 2.426,\n> +            2.224, 1.896, 1.584, 1.382, 1.248, 1.147, 1.088, 1.016, 1.026, 1.118, 1.168, 1.283, 1.444, 1.697, 2.066, 2.428,\n> +            2.292, 2.019, 1.689, 1.462, 1.322, 1.247, 1.147, 1.118, 1.118, 1.168, 1.275, 1.358, 1.532, 1.809, 2.189, 2.491,\n> +            2.444, 2.204, 1.856, 1.606, 1.462, 1.322, 1.257, 1.234, 1.234, 1.275, 1.358, 1.516, 1.686, 1.993, 2.371, 2.622,\n> +            2.748, 2.444, 2.108, 1.856, 1.606, 1.476, 1.399, 1.376, 1.376, 1.422, 1.516, 1.686, 1.968, 2.238, 2.611, 2.935,\n> +            2.862, 2.748, 2.395, 2.099, 1.811, 1.621, 1.582, 1.582, 1.582, 1.592, 1.677, 1.919, 2.223, 2.534, 2.935, 3.078\n> +        ],\n> +        \"sigma\": 0.00428,\n> +        \"sigma_Cb\": 0.00363\n> +    },\n> +    \"rpi.contrast\":\n> +    {\n> +        \"ce_enable\": 1,\n> +        \"gamma_curve\":\n> +        [\n> +            0, 0, 1024, 5040, 2048, 9338, 3072, 12356, 4096, 15312, 5120, 18051, 6144, 20790, 7168, 23193,\n> +            8192, 25744, 9216, 27942, 10240, 30035, 11264, 32005, 12288, 33975, 13312, 35815, 14336, 37600, 15360, 39168,\n> +            16384, 40642, 18432, 43379, 20480, 45749, 22528, 47753, 24576, 49621, 26624, 51253, 28672, 52698, 30720, 53796,\n> +            32768, 54876, 36864, 57012, 40960, 58656, 45056, 59954, 49152, 61183, 53248, 62355, 57344, 63419, 61440, 64476,\n> +            65535, 65535\n> +        ]\n> +    },\n> +    \"rpi.ccm\":\n> +    {\n> +        \"ccms\":\n> +        [\n> +            {\n> +                \"ct\": 2850, \"ccm\":\n> +                [\n> +                    1.42601, -0.20537, -0.22063, -0.47682, 1.81987, -0.34305, 0.01854, -0.86036, 1.84181\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2900, \"ccm\":\n> +                [\n> +                    1.29755, 0.04602, -0.34356, -0.41491, 1.73477, -0.31987, -0.01345, -0.97115, 1.98459\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 3550, \"ccm\":\n> +                [\n> +                    1.49811, -0.33412, -0.16398, -0.40869, 1.72995, -0.32127, -0.01924, -0.62181, 1.64105\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 4500, \"ccm\":\n> +                [\n> +                    1.47015, -0.29229, -0.17786, -0.36561, 1.88919, -0.52358, -0.03552, -0.56717, 1.60269\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5600, \"ccm\":\n> +                [\n> +                    1.60962, -0.47434, -0.13528, -0.32701, 1.73797, -0.41096, -0.07626, -0.40171, 1.47796\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 8000, \"ccm\":\n> +                [\n> +                    1.54642, -0.20396, -0.34246, -0.31748, 2.22559, -0.90811, -0.10035, -0.65877, 1.75912\n> +                ]\n> +            }\n> +        ]\n> +    },\n> +    \"rpi.sharpen\":\n> +    {\n> +    }\n> +}\n> diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build\n> index abb1f928..68433fc2 100644\n> --- a/src/ipa/raspberrypi/data/meson.build\n> +++ b/src/ipa/raspberrypi/data/meson.build\n> @@ -3,6 +3,7 @@\n>  conf_files = files([\n>      'imx219.json',\n>      'imx290.json',\n> +    'imx378.json',\n>      'imx477.json',\n>      'ov5647.json',\n>      'ov9281.json',\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A18FC0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Jul 2021 10:35:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E0B2687B3;\n\tMon, 26 Jul 2021 12:35:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DCB068536\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Jul 2021 12:35:55 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C1BD332;\n\tMon, 26 Jul 2021 12:35:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q8eYNYty\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627295755;\n\tbh=xRYZRhiWbXmTEEwCBywtuvqmTePblnKtQqx5YRHIaY4=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Q8eYNYtyjvYv2CZyFFVyMifyn87W5gHmhWWPA9I/8L2ky4XkPXcZOrEvt4Q38gcnV\n\t0E1VVmR6QhqKZNsTFXPO5/kIp4kiYTGHijxLZMYl8N9ErFOx9OkhhMIlCjI2DCtg74\n\tUhnTog2SwVpWpyB4UYmoEJJIbbqsfWNme3jLo51Q=","To":"David Plowman <david.plowman@raspberrypi.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-4-david.plowman@raspberrypi.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<3d637fe5-2fe3-203a-f546-6ddbf47fef3f@ideasonboard.com>","Date":"Mon, 26 Jul 2021 11:35:52 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210721115220.5090-4-david.plowman@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Add support for\n\timx378 sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":18470,"web_url":"https://patchwork.libcamera.org/comment/18470/","msgid":"<YQc/uJlJL3dHV/KN@pendragon.ideasonboard.com>","date":"2021-08-02T00:43:36","subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Add support for\n\timx378 sensor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Wed, Jul 21, 2021 at 12:52:20PM +0100, David Plowman wrote:\n> This commit adds a tuning file for the 12MP imx378 sensor. The sensor\n> actually shares the same driver (and CamHelper) as the imx477 so only\n> a new tuning file is required. The default choice of imx477.json can\n> be overridden by pointing LIBCAMERA_RPI_TUNING_FILE at a version of\n> the new imx378.json file.\n\nThe IMX378 and IMX477 should ideally have different compatible string in\nDT, and the driver should set the subdev name accordingly. This will\nallow selection of the right tuning file. The drawback is that the\nsensor helper selection would need to be updated.\n\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/ipa/raspberrypi/data/imx378.json | 338 +++++++++++++++++++++++++++\n>  src/ipa/raspberrypi/data/meson.build |   1 +\n>  2 files changed, 339 insertions(+)\n>  create mode 100644 src/ipa/raspberrypi/data/imx378.json\n> \n> diff --git a/src/ipa/raspberrypi/data/imx378.json b/src/ipa/raspberrypi/data/imx378.json\n> new file mode 100644\n> index 00000000..3c2164e2\n> --- /dev/null\n> +++ b/src/ipa/raspberrypi/data/imx378.json\n> @@ -0,0 +1,338 @@\n> +{\n> +    \"rpi.black_level\":\n> +    {\n> +        \"black_level\": 4096\n> +    },\n> +    \"rpi.dpc\":\n> +    {\n> +    },\n> +    \"rpi.lux\":\n> +    {\n> +        \"reference_shutter_speed\": 9999,\n> +        \"reference_gain\": 1.95,\n> +        \"reference_aperture\": 1.0,\n> +        \"reference_lux\": 1000,\n> +        \"reference_Y\": 12996\n> +    },\n> +    \"rpi.noise\":\n> +    {\n> +        \"reference_constant\": 0,\n> +        \"reference_slope\": 2.641\n> +    },\n> +    \"rpi.geq\":\n> +    {\n> +        \"offset\": 235,\n> +        \"slope\": 0.00902\n> +    },\n> +    \"rpi.sdn\":\n> +    {\n> +    },\n> +    \"rpi.awb\":\n> +    {\n> +        \"priors\":\n> +        [\n> +            {\n> +                \"lux\": 0, \"prior\":\n> +                [\n> +                    2000, 1.0, 3000, 0.0, 13000, 0.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 800, \"prior\":\n> +                [\n> +                    2000, 0.0, 6000, 2.0, 13000, 2.0\n> +                ]\n> +            },\n> +            {\n> +                \"lux\": 1500, \"prior\":\n> +                [\n> +                    2000, 0.0, 4000, 1.0, 6000, 6.0, 6500, 7.0, 7000, 1.0, 13000, 1.0\n> +                ]\n> +            }\n> +        ],\n> +        \"modes\":\n> +        {\n> +            \"auto\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 8000\n> +            },\n> +            \"incandescent\":\n> +            {\n> +                \"lo\": 2500,\n> +                \"hi\": 3000\n> +            },\n> +            \"tungsten\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 3500\n> +            },\n> +            \"fluorescent\":\n> +            {\n> +                \"lo\": 4000,\n> +                \"hi\": 4700\n> +            },\n> +            \"indoor\":\n> +            {\n> +                \"lo\": 3000,\n> +                \"hi\": 5000\n> +            },\n> +            \"daylight\":\n> +            {\n> +                \"lo\": 5500,\n> +                \"hi\": 6500\n> +            },\n> +            \"cloudy\":\n> +            {\n> +                \"lo\": 7000,\n> +                \"hi\": 8100\n> +            }\n> +        },\n> +        \"bayes\": 1,\n> +        \"ct_curve\":\n> +        [\n> +            2850.0, 0.6361, 0.3911, 3550.0, 0.5386, 0.5077, 4500.0, 0.4472, 0.6171, 5600.0, 0.3906, 0.6848, 8000.0, 0.3412, 0.7441\n> +        ],\n> +        \"sensitivity_r\": 1.0,\n> +        \"sensitivity_b\": 1.0,\n> +        \"transverse_pos\": 0.01667,\n> +        \"transverse_neg\": 0.01195\n> +    },\n> +    \"rpi.agc\":\n> +    {\n> +        \"metering_modes\":\n> +        {\n> +            \"centre-weighted\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n> +                ]\n> +            },\n> +            \"spot\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n> +                ]\n> +            },\n> +            \"matrix\":\n> +            {\n> +                \"weights\":\n> +                [\n> +                    1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> +                ]\n> +            }\n> +        },\n> +        \"exposure_modes\":\n> +        {\n> +            \"normal\":\n> +            {\n> +                \"shutter\":\n> +                [\n> +                    100, 10000, 30000, 60000, 120000\n> +                ],\n> +                \"gain\":\n> +                [\n> +                    1.0, 2.0, 4.0, 6.0, 6.0\n> +                ]\n> +            },\n> +            \"short\":\n> +            {\n> +                \"shutter\":\n> +                [\n> +                    100, 5000, 10000, 20000, 120000\n> +                ],\n> +                \"gain\":\n> +                [\n> +                    1.0, 2.0, 4.0, 6.0, 6.0\n> +                ]\n> +            }\n> +        },\n> +        \"constraint_modes\":\n> +        {\n> +            \"normal\":\n> +            [\n> +                {\n> +                    \"bound\": \"LOWER\", \"q_lo\": 0.98, \"q_hi\": 1.0, \"y_target\":\n> +                    [\n> +                        0, 0.5, 1000, 0.5\n> +                    ]\n> +                }\n> +            ],\n> +            \"highlight\":\n> +            [\n> +                {\n> +                    \"bound\": \"LOWER\", \"q_lo\": 0.98, \"q_hi\": 1.0, \"y_target\":\n> +                    [\n> +                        0, 0.5, 1000, 0.5\n> +                    ]\n> +                },\n> +                {\n> +                    \"bound\": \"UPPER\", \"q_lo\": 0.98, \"q_hi\": 1.0, \"y_target\":\n> +                    [\n> +                        0, 0.8, 1000, 0.8\n> +                    ]\n> +                }\n> +            ]\n> +        },\n> +        \"y_target\":\n> +        [\n> +            0, 0.16, 1000, 0.165, 10000, 0.17\n> +        ]\n> +    },\n> +    \"rpi.alsc\":\n> +    {\n> +        \"omega\": 1.3,\n> +        \"n_iter\": 100,\n> +        \"luminance_strength\": 0.5,\n> +        \"calibrations_Cr\":\n> +        [\n> +            {\n> +                \"ct\": 2800, \"table\":\n> +                [\n> +                    1.604, 1.601, 1.593, 1.581, 1.568, 1.561, 1.561, 1.561, 1.561, 1.567, 1.582, 1.596, 1.609, 1.622, 1.632, 1.636,\n> +                    1.601, 1.594, 1.586, 1.571, 1.555, 1.546, 1.543, 1.543, 1.547, 1.555, 1.572, 1.584, 1.599, 1.614, 1.625, 1.632,\n> +                    1.599, 1.586, 1.571, 1.555, 1.542, 1.528, 1.518, 1.518, 1.523, 1.537, 1.555, 1.572, 1.589, 1.607, 1.622, 1.629,\n> +                    1.597, 1.579, 1.561, 1.542, 1.528, 1.512, 1.493, 1.493, 1.499, 1.523, 1.537, 1.563, 1.582, 1.601, 1.619, 1.629,\n> +                    1.597, 1.577, 1.557, 1.535, 1.512, 1.493, 1.481, 1.479, 1.492, 1.499, 1.524, 1.555, 1.578, 1.599, 1.619, 1.629,\n> +                    1.597, 1.577, 1.557, 1.534, 1.508, 1.483, 1.476, 1.476, 1.481, 1.496, 1.522, 1.554, 1.578, 1.599, 1.619, 1.629,\n> +                    1.597, 1.578, 1.557, 1.534, 1.508, 1.483, 1.481, 1.479, 1.481, 1.496, 1.522, 1.554, 1.579, 1.601, 1.619, 1.631,\n> +                    1.597, 1.581, 1.562, 1.539, 1.517, 1.504, 1.483, 1.481, 1.496, 1.511, 1.531, 1.561, 1.585, 1.607, 1.623, 1.632,\n> +                    1.601, 1.589, 1.569, 1.554, 1.539, 1.517, 1.504, 1.504, 1.511, 1.531, 1.553, 1.573, 1.596, 1.614, 1.629, 1.636,\n> +                    1.609, 1.601, 1.586, 1.569, 1.554, 1.542, 1.535, 1.535, 1.541, 1.553, 1.573, 1.592, 1.608, 1.625, 1.637, 1.645,\n> +                    1.617, 1.611, 1.601, 1.586, 1.574, 1.565, 1.564, 1.564, 1.571, 1.579, 1.592, 1.608, 1.622, 1.637, 1.646, 1.654,\n> +                    1.619, 1.617, 1.611, 1.601, 1.588, 1.585, 1.585, 1.585, 1.588, 1.592, 1.607, 1.622, 1.637, 1.645, 1.654, 1.655\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5500, \"table\":\n> +                [\n> +                    2.664, 2.658, 2.645, 2.629, 2.602, 2.602, 2.602, 2.606, 2.617, 2.628, 2.649, 2.677, 2.699, 2.722, 2.736, 2.747,\n> +                    2.658, 2.653, 2.629, 2.605, 2.576, 2.575, 2.577, 2.592, 2.606, 2.618, 2.629, 2.651, 2.678, 2.707, 2.727, 2.741,\n> +                    2.649, 2.631, 2.605, 2.576, 2.563, 2.552, 2.552, 2.557, 2.577, 2.604, 2.619, 2.641, 2.669, 2.698, 2.721, 2.741,\n> +                    2.643, 2.613, 2.583, 2.563, 2.552, 2.531, 2.527, 2.527, 2.551, 2.577, 2.604, 2.638, 2.665, 2.694, 2.721, 2.741,\n> +                    2.643, 2.606, 2.575, 2.558, 2.531, 2.516, 2.504, 2.516, 2.527, 2.551, 2.596, 2.635, 2.665, 2.694, 2.721, 2.741,\n> +                    2.643, 2.606, 2.575, 2.558, 2.531, 2.503, 2.501, 2.502, 2.522, 2.551, 2.592, 2.635, 2.669, 2.696, 2.727, 2.744,\n> +                    2.648, 2.611, 2.579, 2.558, 2.532, 2.511, 2.502, 2.511, 2.522, 2.552, 2.592, 2.642, 2.673, 2.702, 2.731, 2.752,\n> +                    2.648, 2.619, 2.589, 2.571, 2.556, 2.532, 2.519, 2.522, 2.552, 2.568, 2.605, 2.648, 2.683, 2.715, 2.743, 2.758,\n> +                    2.659, 2.637, 2.613, 2.589, 2.571, 2.556, 2.555, 2.555, 2.568, 2.605, 2.641, 2.671, 2.699, 2.729, 2.758, 2.776,\n> +                    2.679, 2.665, 2.637, 2.613, 2.602, 2.599, 2.599, 2.606, 2.619, 2.641, 2.671, 2.698, 2.723, 2.754, 2.776, 2.787,\n> +                    2.695, 2.684, 2.671, 2.646, 2.636, 2.636, 2.641, 2.648, 2.661, 2.681, 2.698, 2.723, 2.751, 2.776, 2.788, 2.803,\n> +                    2.702, 2.699, 2.684, 2.671, 2.664, 2.664, 2.664, 2.668, 2.681, 2.698, 2.723, 2.751, 2.773, 2.788, 2.803, 2.805\n> +                ]\n> +            }\n> +        ],\n> +        \"calibrations_Cb\":\n> +        [\n> +            {\n> +                \"ct\": 2800, \"table\":\n> +                [\n> +                    2.876, 2.868, 2.863, 2.851, 2.846, 2.846, 2.847, 2.851, 2.851, 2.857, 2.867, 2.875, 2.889, 2.899, 2.913, 2.926,\n> +                    2.863, 2.861, 2.856, 2.846, 2.846, 2.847, 2.848, 2.851, 2.857, 2.859, 2.875, 2.882, 2.886, 2.896, 2.909, 2.917,\n> +                    2.861, 2.856, 2.846, 2.841, 2.841, 2.855, 2.867, 2.875, 2.888, 2.888, 2.885, 2.883, 2.886, 2.889, 2.901, 2.913,\n> +                    2.858, 2.851, 2.846, 2.846, 2.855, 2.867, 2.884, 2.895, 2.902, 2.902, 2.901, 2.891, 2.891, 2.894, 2.901, 2.909,\n> +                    2.858, 2.851, 2.846, 2.846, 2.867, 2.884, 2.895, 2.902, 2.909, 2.915, 2.911, 2.901, 2.895, 2.898, 2.904, 2.909,\n> +                    2.858, 2.851, 2.849, 2.853, 2.874, 2.888, 2.901, 2.909, 2.917, 2.922, 2.917, 2.911, 2.901, 2.899, 2.905, 2.908,\n> +                    2.861, 2.855, 2.853, 2.855, 2.874, 2.888, 2.901, 2.913, 2.918, 2.922, 2.921, 2.911, 2.901, 2.901, 2.907, 2.908,\n> +                    2.862, 2.859, 2.855, 2.856, 2.872, 2.885, 2.899, 2.906, 2.915, 2.917, 2.911, 2.907, 2.907, 2.907, 2.908, 2.909,\n> +                    2.863, 2.863, 2.859, 2.864, 2.871, 2.881, 2.885, 2.899, 2.905, 2.905, 2.904, 2.904, 2.907, 2.909, 2.913, 2.913,\n> +                    2.866, 2.865, 2.865, 2.867, 2.868, 2.872, 2.881, 2.885, 2.889, 2.894, 2.895, 2.902, 2.906, 2.913, 2.914, 2.917,\n> +                    2.875, 2.875, 2.871, 2.871, 2.871, 2.871, 2.869, 2.869, 2.878, 2.889, 2.894, 2.895, 2.906, 2.914, 2.917, 2.921,\n> +                    2.882, 2.879, 2.876, 2.874, 2.871, 2.871, 2.869, 2.869, 2.869, 2.878, 2.891, 2.894, 2.905, 2.914, 2.919, 2.921\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5500, \"table\":\n> +                [\n> +                    1.488, 1.488, 1.488, 1.488, 1.491, 1.492, 1.492, 1.491, 1.491, 1.491, 1.492, 1.495, 1.497, 1.499, 1.499, 1.503,\n> +                    1.482, 1.485, 1.485, 1.487, 1.489, 1.492, 1.492, 1.492, 1.492, 1.492, 1.494, 1.494, 1.492, 1.491, 1.493, 1.494,\n> +                    1.482, 1.482, 1.484, 1.485, 1.487, 1.492, 1.496, 1.498, 1.499, 1.498, 1.494, 1.492, 1.491, 1.491, 1.491, 1.491,\n> +                    1.481, 1.481, 1.482, 1.485, 1.491, 1.496, 1.498, 1.499, 1.501, 1.499, 1.498, 1.493, 1.491, 1.488, 1.488, 1.488,\n> +                    1.481, 1.481, 1.481, 1.483, 1.491, 1.497, 1.498, 1.499, 1.501, 1.499, 1.498, 1.492, 1.488, 1.485, 1.483, 1.483,\n> +                    1.479, 1.479, 1.481, 1.482, 1.489, 1.495, 1.497, 1.498, 1.499, 1.499, 1.495, 1.492, 1.485, 1.482, 1.482, 1.481,\n> +                    1.479, 1.479, 1.479, 1.481, 1.489, 1.494, 1.496, 1.497, 1.497, 1.496, 1.495, 1.489, 1.482, 1.481, 1.479, 1.477,\n> +                    1.478, 1.478, 1.479, 1.481, 1.487, 1.491, 1.494, 1.496, 1.496, 1.495, 1.492, 1.487, 1.482, 1.479, 1.478, 1.476,\n> +                    1.478, 1.478, 1.479, 1.482, 1.486, 1.488, 1.491, 1.493, 1.493, 1.492, 1.487, 1.484, 1.481, 1.479, 1.476, 1.476,\n> +                    1.477, 1.479, 1.481, 1.483, 1.485, 1.486, 1.488, 1.488, 1.487, 1.487, 1.484, 1.483, 1.481, 1.479, 1.476, 1.476,\n> +                    1.477, 1.479, 1.482, 1.483, 1.484, 1.485, 1.484, 1.482, 1.482, 1.484, 1.483, 1.482, 1.481, 1.479, 1.477, 1.476,\n> +                    1.477, 1.479, 1.482, 1.483, 1.484, 1.484, 1.482, 1.482, 1.482, 1.482, 1.482, 1.481, 1.479, 1.479, 1.479, 1.479\n> +                ]\n> +            }\n> +        ],\n> +        \"luminance_lut\":\n> +        [\n> +            2.764, 2.654, 2.321, 2.043, 1.768, 1.594, 1.558, 1.558, 1.558, 1.568, 1.661, 1.904, 2.193, 2.497, 2.888, 3.043,\n> +            2.654, 2.373, 2.049, 1.819, 1.569, 1.446, 1.381, 1.356, 1.356, 1.403, 1.501, 1.679, 1.939, 2.218, 2.586, 2.888,\n> +            2.376, 2.154, 1.819, 1.569, 1.438, 1.301, 1.246, 1.224, 1.224, 1.263, 1.349, 1.501, 1.679, 1.985, 2.359, 2.609,\n> +            2.267, 1.987, 1.662, 1.438, 1.301, 1.235, 1.132, 1.105, 1.105, 1.164, 1.263, 1.349, 1.528, 1.808, 2.184, 2.491,\n> +            2.218, 1.876, 1.568, 1.367, 1.235, 1.132, 1.087, 1.022, 1.023, 1.104, 1.164, 1.278, 1.439, 1.695, 2.066, 2.429,\n> +            2.218, 1.832, 1.533, 1.341, 1.206, 1.089, 1.013, 1.002, 1.013, 1.026, 1.122, 1.246, 1.399, 1.642, 2.004, 2.426,\n> +            2.218, 1.832, 1.533, 1.341, 1.206, 1.089, 1.011, 1.001, 1.009, 1.026, 1.122, 1.246, 1.399, 1.642, 2.004, 2.426,\n> +            2.224, 1.896, 1.584, 1.382, 1.248, 1.147, 1.088, 1.016, 1.026, 1.118, 1.168, 1.283, 1.444, 1.697, 2.066, 2.428,\n> +            2.292, 2.019, 1.689, 1.462, 1.322, 1.247, 1.147, 1.118, 1.118, 1.168, 1.275, 1.358, 1.532, 1.809, 2.189, 2.491,\n> +            2.444, 2.204, 1.856, 1.606, 1.462, 1.322, 1.257, 1.234, 1.234, 1.275, 1.358, 1.516, 1.686, 1.993, 2.371, 2.622,\n> +            2.748, 2.444, 2.108, 1.856, 1.606, 1.476, 1.399, 1.376, 1.376, 1.422, 1.516, 1.686, 1.968, 2.238, 2.611, 2.935,\n> +            2.862, 2.748, 2.395, 2.099, 1.811, 1.621, 1.582, 1.582, 1.582, 1.592, 1.677, 1.919, 2.223, 2.534, 2.935, 3.078\n> +        ],\n> +        \"sigma\": 0.00428,\n> +        \"sigma_Cb\": 0.00363\n> +    },\n> +    \"rpi.contrast\":\n> +    {\n> +        \"ce_enable\": 1,\n> +        \"gamma_curve\":\n> +        [\n> +            0, 0, 1024, 5040, 2048, 9338, 3072, 12356, 4096, 15312, 5120, 18051, 6144, 20790, 7168, 23193,\n> +            8192, 25744, 9216, 27942, 10240, 30035, 11264, 32005, 12288, 33975, 13312, 35815, 14336, 37600, 15360, 39168,\n> +            16384, 40642, 18432, 43379, 20480, 45749, 22528, 47753, 24576, 49621, 26624, 51253, 28672, 52698, 30720, 53796,\n> +            32768, 54876, 36864, 57012, 40960, 58656, 45056, 59954, 49152, 61183, 53248, 62355, 57344, 63419, 61440, 64476,\n> +            65535, 65535\n> +        ]\n> +    },\n> +    \"rpi.ccm\":\n> +    {\n> +        \"ccms\":\n> +        [\n> +            {\n> +                \"ct\": 2850, \"ccm\":\n> +                [\n> +                    1.42601, -0.20537, -0.22063, -0.47682, 1.81987, -0.34305, 0.01854, -0.86036, 1.84181\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 2900, \"ccm\":\n> +                [\n> +                    1.29755, 0.04602, -0.34356, -0.41491, 1.73477, -0.31987, -0.01345, -0.97115, 1.98459\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 3550, \"ccm\":\n> +                [\n> +                    1.49811, -0.33412, -0.16398, -0.40869, 1.72995, -0.32127, -0.01924, -0.62181, 1.64105\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 4500, \"ccm\":\n> +                [\n> +                    1.47015, -0.29229, -0.17786, -0.36561, 1.88919, -0.52358, -0.03552, -0.56717, 1.60269\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 5600, \"ccm\":\n> +                [\n> +                    1.60962, -0.47434, -0.13528, -0.32701, 1.73797, -0.41096, -0.07626, -0.40171, 1.47796\n> +                ]\n> +            },\n> +            {\n> +                \"ct\": 8000, \"ccm\":\n> +                [\n> +                    1.54642, -0.20396, -0.34246, -0.31748, 2.22559, -0.90811, -0.10035, -0.65877, 1.75912\n> +                ]\n> +            }\n> +        ]\n> +    },\n> +    \"rpi.sharpen\":\n> +    {\n> +    }\n> +}\n> diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build\n> index abb1f928..68433fc2 100644\n> --- a/src/ipa/raspberrypi/data/meson.build\n> +++ b/src/ipa/raspberrypi/data/meson.build\n> @@ -3,6 +3,7 @@\n>  conf_files = files([\n>      'imx219.json',\n>      'imx290.json',\n> +    'imx378.json',\n>      'imx477.json',\n>      'ov5647.json',\n>      'ov9281.json',","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99693C3232\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  2 Aug 2021 00:43:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06080687C3;\n\tMon,  2 Aug 2021 02:43:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C116687B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  2 Aug 2021 02:43:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9D5787C;\n\tMon,  2 Aug 2021 02:43:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mWYu3ayh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627865026;\n\tbh=kcMMSsgouYghZ6v/kIkjwasJWlX9sdTrUefUhvkxlPc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mWYu3ayhDPl3xA2DMF/ujFezrNr+uXSHj1XBsIxrZXm/LDEKkW+g9PQND2up1o+gD\n\tFDuGiy0NC0iU4bdUm5hWC9f0aOws0Vuz34IzfA6st6mc+Hka/gz8SvAuPxCJbrOApF\n\tHjgc+/h0iWgBLr7Z+wWK4Szd38v6Hpk3MFzlrK9c=","Date":"Mon, 2 Aug 2021 03:43:36 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Message-ID":"<YQc/uJlJL3dHV/KN@pendragon.ideasonboard.com>","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-4-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210721115220.5090-4-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Add support for\n\timx378 sensor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]