[{"id":18246,"web_url":"https://patchwork.libcamera.org/comment/18246/","msgid":"","date":"2021-07-21T13:08:50","subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for fixing this!\n\nOn Wed, 21 Jul 2021 at 12:52, David Plowman \nwrote:\n\n> The NearestCentroid function is now in the sklearn.neighbors\n> namespace.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> utils/raspberrypi/ctt/ctt_tools.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/utils/raspberrypi/ctt/ctt_tools.py\n> b/utils/raspberrypi/ctt/ctt_tools.py\n> index 48e0aac2..8728ff16 100644\n> --- a/utils/raspberrypi/ctt/ctt_tools.py\n> +++ b/utils/raspberrypi/ctt/ctt_tools.py\n> @@ -14,7 +14,7 @@ import imutils\n> import sys\n> import matplotlib.pyplot as plt\n> from sklearn import cluster as cluster\n> -from sklearn.neighbors.nearest_centroid import NearestCentroid as\n> get_centroids\n> +from sklearn.neighbors import NearestCentroid as get_centroids\n>\n> \"\"\"\n> This file contains some useful tools, the details of which aren't\n> important to\n> --\n> 2.20.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC5BDC0109\n\tfor ;\n\tWed, 21 Jul 2021 13:09:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C5EF68542;\n\tWed, 21 Jul 2021 15:09:08 +0200 (CEST)","from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB6F460276\n\tfor ;\n\tWed, 21 Jul 2021 15:09:06 +0200 (CEST)","by mail-lj1-x236.google.com with SMTP id e14so2936787ljo.7\n\tfor ;\n\tWed, 21 Jul 2021 06:09:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RiE+9Foh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=RK8y4CWUEQHvacErdMhHXDxP5kd1MrAESqog53SONtQ=;\n\tb=RiE+9FohO2pGDgi6s/xIma89LspKJymRIbCuyRCBmw1X2zeYgR9ek/C0aE2ilkMLIS\n\twV6mFDX3qw7Df35eT2FBdZbkhcW8W97XO5ZnAkgXbfSeQFaT95n7QhhKjBLc2/lMdPOl\n\t0d7p3H4grHJdMsM65S9/Oc3UGPmvzU9TcJSpleDIT4SlomfG1rtCCxrwWtk/OCZ2vY+q\n\tsBpIIiQQfu0Rb/zKV/ug1sYTIGjwStwT1Q7BjJB2qLTCckCABdxLlfEIS/pgoiHo8Co9\n\t5bLlQN2Td0qTd73M4NSEJucnCj9SLbOjvU6vy4Hy9Tu4xDkbAo/B6xPfjmZ73ubJDMdj\n\trAag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=RK8y4CWUEQHvacErdMhHXDxP5kd1MrAESqog53SONtQ=;\n\tb=Q2M8J6JVBXKBbuQV8EVT/yjSijXJavbsLIrzcKiVec0doClwDrOoaR/4tPT0Se2H4E\n\tSAb3tSIUVyX0/oUJdqi1tc2QSgwt8hajt9ATRFMXfcQH16ak3VVnqPhG+v3QRMsHwOLc\n\tYvAXzkpr8+3xDA2t84Ke4ZGZixpT0/ahLbEuUye1w7ZzmBRbGpodENKekNtWfAl1dW9r\n\ttR8vYxkRR5jsBZePce/LmBNygjZtDxyd1/iQLAUebx0lWQ8lgHWD1QWQqtNYZGvgTe2B\n\tYvT3HENZypoSKQ3d7y1A9w4tStba2iqF+dBah8mYxL2V5pUKfp81+sdBhw4dHi0Mk+zH\n\tJrQw==","X-Gm-Message-State":"AOAM533Mw5SY0yM2m46x5KEhyXfcsRjM1mpTu8m/1Et6HjVCNu5WyZvU\n\tIuzVGvrRJSlp9bcuGkswIQqneRkr+SjqTfqjLk13Wg==","X-Google-Smtp-Source":"ABdhPJyy9v80ahvb8LagnSn4JTOAsdrmBeQ1wawgU4qW4fNkPCAull6ju9Svxnu+ta0NqTwBIx8O5o8hj7hHm2TGxDM=","X-Received":"by 2002:a2e:a0d8:: with SMTP id\n\tf24mr4786660ljm.299.1626872945933; \n\tWed, 21 Jul 2021 06:09:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20210721115220.5090-2-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Wed, 21 Jul 2021 14:08:50 +0100","Message-ID":"","To":"David Plowman ","Content-Type":"multipart/alternative; boundary=\"00000000000009929605c7a1e0b9\"","Subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18355,"web_url":"https://patchwork.libcamera.org/comment/18355/","msgid":"<162fecf4-0c65-7960-2ef4-79d09804db5c@ideasonboard.com>","date":"2021-07-26T10:31:55","subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 21/07/2021 12:52, David Plowman wrote:\n> The NearestCentroid function is now in the sklearn.neighbors\n> namespace.\n> \n\nDoes this have requirements of a specific version of the external\nimport? It would probably be helpful to mention the version that it\nbecame required or ensure that the newest version is now a required\nversion somehow.\n\nBut otherwise,\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: David Plowman \n> ---\n> utils/raspberrypi/ctt/ctt_tools.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/raspberrypi/ctt/ctt_tools.py b/utils/raspberrypi/ctt/ctt_tools.py\n> index 48e0aac2..8728ff16 100644\n> --- a/utils/raspberrypi/ctt/ctt_tools.py\n> +++ b/utils/raspberrypi/ctt/ctt_tools.py\n> @@ -14,7 +14,7 @@ import imutils\n> import sys\n> import matplotlib.pyplot as plt\n> from sklearn import cluster as cluster\n> -from sklearn.neighbors.nearest_centroid import NearestCentroid as get_centroids\n> +from sklearn.neighbors import NearestCentroid as get_centroids\n> \n> \"\"\"\n> This file contains some useful tools, the details of which aren't important to\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5A54C322C\n\tfor ;\n\tMon, 26 Jul 2021 10:32:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60A48687B3;\n\tMon, 26 Jul 2021 12:32:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A49268536\n\tfor ;\n\tMon, 26 Jul 2021 12:31:58 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5E02332;\n\tMon, 26 Jul 2021 12:31:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LjhUXXxu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627295518;\n\tbh=tbXvm99OCOU/r9WIo2LpptV7bXGp0zyKx7JB++pJMCQ=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=LjhUXXxu0kqjfq4v1yU7PaUr5R5xT4ZRbR/Irpdf+rzGysX5Ozo8jAWXAmfNc5y/f\n\tVabSianFj3OuTpob0N1F5QGhRZcl1yOtT9EH/EGr+OrRV/0r+Zx9Xc+Sfm1QrWeBbm\n\t52DZqf+n9mMwDBr6IT4UR2FyfFSu/cIFSjVtmH4c=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-2-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Message-ID":"<162fecf4-0c65-7960-2ef4-79d09804db5c@ideasonboard.com>","Date":"Mon, 26 Jul 2021 11:31:55 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210721115220.5090-2-david.plowman@raspberrypi.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18402,"web_url":"https://patchwork.libcamera.org/comment/18402/","msgid":"","date":"2021-07-28T08:27:49","subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Kieran\n\nI did go looking for the version when this changed, but even trawling\nthrough the release notes didn't really enlighten me. I found a commit\nhere (https://github.com/scikit-learn/scikit-learn/commit/62aee0666e8803f20ecf0f6214621367e50f3961#diff-9f63dcf8f128db106a66cc33db9816f91db51e286f5f13af3f87405468b3df2b)\nthat clearly has some bearing on this, from back in October 2019, but\nthere doesn't seem to be anything older there. So unless anyone else\ncan enlighten me, I've thrown in the towel... :(\n\nThanks anyway!\nDavid\n\nOn Mon, 26 Jul 2021 at 11:31, Kieran Bingham\n wrote:\n>\n> Hi David,\n>\n> On 21/07/2021 12:52, David Plowman wrote:\n> > The NearestCentroid function is now in the sklearn.neighbors\n> > namespace.\n> >\n>\n> Does this have requirements of a specific version of the external\n> import? It would probably be helpful to mention the version that it\n> became required or ensure that the newest version is now a required\n> version somehow.\n>\n> But otherwise,\n>\n> Reviewed-by: Kieran Bingham \n>\n> > Signed-off-by: David Plowman \n> > ---\n> > utils/raspberrypi/ctt/ctt_tools.py | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/utils/raspberrypi/ctt/ctt_tools.py b/utils/raspberrypi/ctt/ctt_tools.py\n> > index 48e0aac2..8728ff16 100644\n> > --- a/utils/raspberrypi/ctt/ctt_tools.py\n> > +++ b/utils/raspberrypi/ctt/ctt_tools.py\n> > @@ -14,7 +14,7 @@ import imutils\n> > import sys\n> > import matplotlib.pyplot as plt\n> > from sklearn import cluster as cluster\n> > -from sklearn.neighbors.nearest_centroid import NearestCentroid as get_centroids\n> > +from sklearn.neighbors import NearestCentroid as get_centroids\n> >\n> > \"\"\"\n> > This file contains some useful tools, the details of which aren't important to\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64B8DC322E\n\tfor ;\n\tWed, 28 Jul 2021 08:28:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF0AC687BD;\n\tWed, 28 Jul 2021 10:28:01 +0200 (CEST)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B534687B6\n\tfor ;\n\tWed, 28 Jul 2021 10:28:00 +0200 (CEST)","by mail-wr1-x42a.google.com with SMTP id e2so1459865wrq.6\n\tfor ;\n\tWed, 28 Jul 2021 01:28:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"hAdcctzY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=CIbR9Az10lwjpZG9cSUkQD00NKGjhHt8JGmHdmnF0Bo=;\n\tb=hAdcctzYixXvJit6QDCaTZOJ6B/kC/5ZaGoPJYZVT0HGH3qDKjp1l0OuckzTPA9zLb\n\tfspuNcuEQxfc6H6Mlj9RLElgiHJjoEq3aWbuVL3c36BrJAw6tQhoyVNQetAgGREEZJ7j\n\tPOVm54JGxgNhgnQq3rcmt3WHHBqVozQvpDMrFWqTTVlMDEAktsP3l0GjvXq9QAdOqjCV\n\taYoOpOUzheyGvSXpY2oKc0vWSBfMb+rI+hMSWzBrAL4NKsydJI6+We8mc3MoFvS1pvWf\n\tp/3/DD1q0vIInwz5O5bPQ2vhasAs9/0eD4E5v3BnMKTd9SAoJBGxxVLV0A78smTsMreq\n\tSBLg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=CIbR9Az10lwjpZG9cSUkQD00NKGjhHt8JGmHdmnF0Bo=;\n\tb=mj1O/GFD1cd8t5GFF+hCbUA7mRqXHdkpjTEPr5K6GDf39EUpnV4wB/2gnUvIk1ObCY\n\tgVACYcF4EN3RLbTvZqg7tljCAjCUF8QJqprV4/mKEG33tRtTq4VPay9dR4lIwZjeg690\n\tlL8JgW6H7DKnCmcWUsw+1G4pRkI6yRMRxNVzLGbCg816gxUZtnqrXj+sO8RwbNvfUzp3\n\twb8OPLeT813PFsPOsuXG3ZJxygwEIfGstPJDdD6f/DpRRrKH+Ot82QrFcjvJmvxDpLBP\n\tDPoN3uF4wmMiOLLYnMFY6JmksKYSGkHG9O4Uesk5gUBqSZnpMnz0i6ABc5tc8gasegUy\n\txu/w==","X-Gm-Message-State":"AOAM530rTEaXohVsSx4XGWHTQOjnydLI3Rs9pKVgsgcAeH5Ng28Bc0ju\n\tJl4hO0rJKXU3CoH4ZFAgrZVr4+NFxMNkA8QIobU43Q==","X-Google-Smtp-Source":"ABdhPJxYyOrrdrwAzBUrx6Ngi2ouZkbFAOe8ko38p30F0StsTj6cIF6ikneXGLUHWsz2WQY+HXWZpaNDwxogQlMAqOM=","X-Received":"by 2002:adf:ed4a:: with SMTP id u10mr9789185wro.86.1627460879804;\n\tWed, 28 Jul 2021 01:27:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-2-david.plowman@raspberrypi.com>\n\t<162fecf4-0c65-7960-2ef4-79d09804db5c@ideasonboard.com>","In-Reply-To":"<162fecf4-0c65-7960-2ef4-79d09804db5c@ideasonboard.com>","From":"David Plowman ","Date":"Wed, 28 Jul 2021 09:27:49 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18468,"web_url":"https://patchwork.libcamera.org/comment/18468/","msgid":"","date":"2021-08-02T00:38:58","subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Wed, Jul 28, 2021 at 09:27:49AM +0100, David Plowman wrote:\n> Hi Kieran\n> \n> I did go looking for the version when this changed, but even trawling\n> through the release notes didn't really enlighten me. I found a commit\n> here (https://github.com/scikit-learn/scikit-learn/commit/62aee0666e8803f20ecf0f6214621367e50f3961#diff-9f63dcf8f128db106a66cc33db9816f91db51e286f5f13af3f87405468b3df2b)\n> that clearly has some bearing on this, from back in October 2019, but\n> there doesn't seem to be anything older there. So unless anyone else\n> can enlighten me, I've thrown in the towel... :(\n\n$ git tag --contains 62aee0666e8803f20ecf0f6214621367e50f3961\n0.22\n0.22.1\n0.22.2\n0.22.2.post1\n0.22rc1\n0.22rc2\n0.22rc2.post1\n0.22rc3\n0.23.0\n0.23.0rc1\n0.23.1\n0.23.2\n0.24.0\n0.24.0rc1\n0.24.1\n0.24.2\n\nI think we can reasonably conclude that the change appeared in 0.22 :-)\nChanging the API like this isn't nice :-S\n\nIs there value in trying to preserve backward compatibility ? If that's\nof any interest, Debian ships 0.20.2 in the latest stable, while Ubuntu\nstarted shipping 0.22.2 in 20.04LTS.\n\nIf backward compatibility isn't worth it, we should at least document\nthe minimal version somewhere (a README.rst in utils/raspberrypi/ctt/\nmaybe ?).\n\n> On Mon, 26 Jul 2021 at 11:31, Kieran Bingham wrote:\n> > On 21/07/2021 12:52, David Plowman wrote:\n> > > The NearestCentroid function is now in the sklearn.neighbors\n> > > namespace.\n> >\n> > Does this have requirements of a specific version of the external\n> > import? It would probably be helpful to mention the version that it\n> > became required or ensure that the newest version is now a required\n> > version somehow.\n> >\n> > But otherwise,\n> >\n> > Reviewed-by: Kieran Bingham \n> >\n> > > Signed-off-by: David Plowman \n> > > ---\n> > > utils/raspberrypi/ctt/ctt_tools.py | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/utils/raspberrypi/ctt/ctt_tools.py b/utils/raspberrypi/ctt/ctt_tools.py\n> > > index 48e0aac2..8728ff16 100644\n> > > --- a/utils/raspberrypi/ctt/ctt_tools.py\n> > > +++ b/utils/raspberrypi/ctt/ctt_tools.py\n> > > @@ -14,7 +14,7 @@ import imutils\n> > > import sys\n> > > import matplotlib.pyplot as plt\n> > > from sklearn import cluster as cluster\n> > > -from sklearn.neighbors.nearest_centroid import NearestCentroid as get_centroids\n> > > +from sklearn.neighbors import NearestCentroid as get_centroids\n> > >\n> > > \"\"\"\n> > > This file contains some useful tools, the details of which aren't important to","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51F1FBD878\n\tfor ;\n\tMon, 2 Aug 2021 00:39:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5726687B6;\n\tMon, 2 Aug 2021 02:39:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27ECB687B6\n\tfor ;\n\tMon, 2 Aug 2021 02:39:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A8A387C;\n\tMon, 2 Aug 2021 02:39:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BVJrKOi1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627864747;\n\tbh=vmiF1ZOpz5SxWdbDvjZQGfIu39kDi7Da0Y1g4vcwDDQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BVJrKOi1PEnayi2b+0PK+5WDj+MLbeems7cJuxChJmErFja73n0yhHr9W5PovTvpv\n\tEPAX3DKuXqrApdXk3JcMPfAxTR32LsO3fn2wLS6BkLnAyQL1vIIB0zrk8uDjvNkTjD\n\tMRrJabGpKOE2cPN6BjSL73ADCm0mYxANZ3WCu8Bw=","Date":"Mon, 2 Aug 2021 03:38:58 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-2-david.plowman@raspberrypi.com>\n\t<162fecf4-0c65-7960-2ef4-79d09804db5c@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18485,"web_url":"https://patchwork.libcamera.org/comment/18485/","msgid":"","date":"2021-08-02T07:50:38","subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nThanks for the info, didn't know I could do that!\n\nGiven that our documentation for tuning is all elsewhere, maybe it's\neasier just to handle the change in the code. Let me submit a new\nversion of this commit which does that!\n\nThanks\nDavid\n\nOn Mon, 2 Aug 2021 at 01:39, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> On Wed, Jul 28, 2021 at 09:27:49AM +0100, David Plowman wrote:\n> > Hi Kieran\n> >\n> > I did go looking for the version when this changed, but even trawling\n> > through the release notes didn't really enlighten me. I found a commit\n> > here (https://github.com/scikit-learn/scikit-learn/commit/62aee0666e8803f20ecf0f6214621367e50f3961#diff-9f63dcf8f128db106a66cc33db9816f91db51e286f5f13af3f87405468b3df2b)\n> > that clearly has some bearing on this, from back in October 2019, but\n> > there doesn't seem to be anything older there. So unless anyone else\n> > can enlighten me, I've thrown in the towel... :(\n>\n> $ git tag --contains 62aee0666e8803f20ecf0f6214621367e50f3961\n> 0.22\n> 0.22.1\n> 0.22.2\n> 0.22.2.post1\n> 0.22rc1\n> 0.22rc2\n> 0.22rc2.post1\n> 0.22rc3\n> 0.23.0\n> 0.23.0rc1\n> 0.23.1\n> 0.23.2\n> 0.24.0\n> 0.24.0rc1\n> 0.24.1\n> 0.24.2\n>\n> I think we can reasonably conclude that the change appeared in 0.22 :-)\n> Changing the API like this isn't nice :-S\n>\n> Is there value in trying to preserve backward compatibility ? If that's\n> of any interest, Debian ships 0.20.2 in the latest stable, while Ubuntu\n> started shipping 0.22.2 in 20.04LTS.\n>\n> If backward compatibility isn't worth it, we should at least document\n> the minimal version somewhere (a README.rst in utils/raspberrypi/ctt/\n> maybe ?).\n>\n> > On Mon, 26 Jul 2021 at 11:31, Kieran Bingham wrote:\n> > > On 21/07/2021 12:52, David Plowman wrote:\n> > > > The NearestCentroid function is now in the sklearn.neighbors\n> > > > namespace.\n> > >\n> > > Does this have requirements of a specific version of the external\n> > > import? It would probably be helpful to mention the version that it\n> > > became required or ensure that the newest version is now a required\n> > > version somehow.\n> > >\n> > > But otherwise,\n> > >\n> > > Reviewed-by: Kieran Bingham \n> > >\n> > > > Signed-off-by: David Plowman \n> > > > ---\n> > > > utils/raspberrypi/ctt/ctt_tools.py | 2 +-\n> > > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > >\n> > > > diff --git a/utils/raspberrypi/ctt/ctt_tools.py b/utils/raspberrypi/ctt/ctt_tools.py\n> > > > index 48e0aac2..8728ff16 100644\n> > > > --- a/utils/raspberrypi/ctt/ctt_tools.py\n> > > > +++ b/utils/raspberrypi/ctt/ctt_tools.py\n> > > > @@ -14,7 +14,7 @@ import imutils\n> > > > import sys\n> > > > import matplotlib.pyplot as plt\n> > > > from sklearn import cluster as cluster\n> > > > -from sklearn.neighbors.nearest_centroid import NearestCentroid as get_centroids\n> > > > +from sklearn.neighbors import NearestCentroid as get_centroids\n> > > >\n> > > > \"\"\"\n> > > > This file contains some useful tools, the details of which aren't important to\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1424C3232\n\tfor ;\n\tMon, 2 Aug 2021 07:50:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F96C687C3;\n\tMon, 2 Aug 2021 09:50:51 +0200 (CEST)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 367A66026E\n\tfor ;\n\tMon, 2 Aug 2021 09:50:49 +0200 (CEST)","by mail-wr1-x434.google.com with SMTP id m12so15549394wru.12\n\tfor ;\n\tMon, 02 Aug 2021 00:50:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"NnMW/+hA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=YoD6hcYiF40iszCpmoTh011lyZaWIqK8VlUdJYR8WjA=;\n\tb=NnMW/+hAIoEKGo9I7nz0jPKrMqutNooJt/Exg/as8/a+e/2hAa1W2csBOFN8gV4dW9\n\t5m1NAb6HHdtHg3F7V1Eq+oV8AqdQOYMCatT8D0N+wcOeCzpg/8ydT1KpfjK1wrhdPu1g\n\tSdUrvsla5MVFQQqdWl93l9YoALjpWeXB1zNBvee5+PLATR3f9S9B1zqWBD1xP2Owvt16\n\tqBqECzSi1i7+KrWvIyrFQkC4lm2qT03+OLGyAKwcvJN/8cIDzMiWnv51/BTFrewDh8mI\n\tkLLEqs58FyEswC0cvyEQFc0kgIc1Eqwp5w4K+OduYE0ZUkN0cjC94QWZKLKRwBn/uCrW\n\t7uRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=YoD6hcYiF40iszCpmoTh011lyZaWIqK8VlUdJYR8WjA=;\n\tb=oQzjytRtF0206qKmm5SgE5iNg7CmgqCqsB5NRAk83YKLuwAkPqMdVGoJLnC/MRldIV\n\tu7adlyfIezFiRwl+yo+ydtl3m8d99ToeBSSVqXZ4nzhaLK8IdJCJrtjiWf7l8+AgM3DW\n\tfXXGDgStD5SIUT3QyuaZwjckOU9TMr61AvkZN99uWtlkyVaNpN8khdCZ8EOHyYwp4sZv\n\tsbfqEbVkHXz9VO833LsGfsPtTwhfFQp3Hm/E/mHpfvGbpESmDE5z9YVPG7ZKoC2wt7JF\n\t0qL31OYEwohzSbhkktIol5FKVMN5x0hFcU8k78a+k1TL4bW3xAMoyxeelthGZduQim81\n\tfo3g==","X-Gm-Message-State":"AOAM530B8OF4sCHrPtIbMxoIhq0LYCkMewdqjmiLH8tgB7qvf8RthwIs\n\tJRdTV17bEOE2yYKFZjrxfH5RatFJ+o56LQszZgcgBw==","X-Google-Smtp-Source":"ABdhPJwIej/0tH6QptPzkRB+BFvPIl6p4mJWKBbeecFVB7YoZSIwW4+fiMmW//cy2h9a1EjouMCOMKycUs7i7oKXlNs=","X-Received":"by 2002:a05:6000:1b02:: with SMTP id\n\tf2mr15840136wrz.274.1627890648798; \n\tMon, 02 Aug 2021 00:50:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20210721115220.5090-1-david.plowman@raspberrypi.com>\n\t<20210721115220.5090-2-david.plowman@raspberrypi.com>\n\t<162fecf4-0c65-7960-2ef4-79d09804db5c@ideasonboard.com>\n\t\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Mon, 2 Aug 2021 08:50:38 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/3] utils: raspberrypi: ctt: Fix\n\tnamespace for sklearn NearestCentroid function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]