{"id":13063,"url":"https://patchwork.libcamera.org/api/patches/13063/?format=json","web_url":"https://patchwork.libcamera.org/patch/13063/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210720173548.313901-2-vedantparanjape160201@gmail.com>","date":"2021-07-20T17:35:48","name":"[libcamera-devel,RFC,v1,2/2] gstreamer: Replace code to push the stream start with factored out function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ab58b6311b12137eb0bea2e477aa95ad52185d16","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/?format=json","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13063/mbox/","series":[{"id":2262,"url":"https://patchwork.libcamera.org/api/series/2262/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2262","date":"2021-07-20T17:35:47","name":"[libcamera-devel,RFC,v1,1/2] gstreamer: Factor out _pad_push_stream_start from _task_enter","version":1,"mbox":"https://patchwork.libcamera.org/series/2262/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13063/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13063/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19F55C322B\n\tfor ;\n\tTue, 20 Jul 2021 17:36:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C78366852A;\n\tTue, 20 Jul 2021 19:36:15 +0200 (CEST)","from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C952168521\n\tfor ;\n\tTue, 20 Jul 2021 19:36:14 +0200 (CEST)","by mail-pj1-x1029.google.com with SMTP id\n\tp4-20020a17090a9304b029016f3020d867so13741pjo.3\n\tfor ;\n\tTue, 20 Jul 2021 10:36:14 -0700 (PDT)","from localhost.localdomain ([1.186.165.221])\n\tby smtp.googlemail.com with ESMTPSA id\n\tcp8sm8271113pjb.27.2021.07.20.10.36.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Jul 2021 10:36:12 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SzKuJh7N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hk0FDmlWPCvHCNDSgXUbYjreQYjOCPgDYaZf1XT8LW8=;\n\tb=SzKuJh7NUuMSW7srn2LOG7a8ZCjbcuF0FZ8R3a9VnfmZOplhkBCYLuZell2e3R0xQs\n\tfKQk0cC3ckJDOw7vNkpNUh8355WzDwReOzVuf27NKliHZWbQD7B+XSnNUArjXQa4y7wb\n\tuSQenTP61LK0GnPin3/rW35IKkvbfqSQm2PrOL5Ubl4aYH9bya8QhaS3BA19bFsPscCM\n\tv1jWp+ENcGykIwAoo1ZQXivS6F4Oa0p/ANtgJ2wU4gwIjFiLHDJNQaLV890dJKlPVL8S\n\tvnRlfOfTanID0bhhFNqAg6XYiWV+W4v7eZYpjx8R8bPbzyeO6q+HXUN0L2AQA6V+SFkT\n\tWilQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=hk0FDmlWPCvHCNDSgXUbYjreQYjOCPgDYaZf1XT8LW8=;\n\tb=JfCM7eHgefSL3ar9mQcAVOctF4S8jOIe6UjpeJZWm6/oge+aH6oD3gHErQaVTOqJ6c\n\tyETWCFnmPbB2S0PaC8884JPYXeW1x9vva9TMOzjCXNF4H3NZTxxydTeNWrrY24e4nwpK\n\tuTDX5CcVfvf5PeXJFpd5zit1wu8cmcdVjmkaMs3FLmBvS0l7BOq0hZhbwCnRp39oT0T2\n\tUdyTA+O5fjFbcbjipWtRu30QLUEisV8ox2Iz18wGaq1T41Fc+C3qebDxAnUBM7GHgePF\n\tYVNvdP9g/VfMCGjkmOgxqTEU4URTYNj/Vurgd6xbVXoL910B/B9pv/V9Z3r/bvUCQkr1\n\tbX8g==","X-Gm-Message-State":"AOAM530cRbWVt5D0clrOp2uHqzix486jgQuPxtTTtE9VpLEwizJr3odv\n\ttmjW/fXMthtVTUw7tdvbGYpXSzObqv2/cQ==","X-Google-Smtp-Source":"ABdhPJx1/u+dgeSbuRG3oxQ/WaNIKgCjUQmAxnQGm45qZAM3W6rR87QTCKUKmIM4Hu7YmwEvngLDOQ==","X-Received":"by 2002:a17:90a:2f63:: with SMTP id\n\ts90mr36035988pjd.168.1626802573068; \n\tTue, 20 Jul 2021 10:36:13 -0700 (PDT)","From":"Vedant Paranjape ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Jul 2021 23:05:48 +0530","Message-Id":"<20210720173548.313901-2-vedantparanjape160201@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210720173548.313901-1-vedantparanjape160201@gmail.com>","References":"<20210720173548.313901-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v1 2/2] gstreamer: Replace code to\n\tpush the stream start with factored out function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Vedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Update functional code in gst_libcamera_src_task_enter(), which creates stream\nid and pushes the stream start with the refactored function\ngst_libcamera_pad_push_stream_start().\n\nSigned-off-by: Vedant Paranjape \n---\n src/gstreamer/gstlibcamerasrc.cpp | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex b18f1efb..bb8ea07a 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -361,15 +361,10 @@ gst_libcamera_src_task_enter(GstTask *task, [[maybe_unused]] GThread *thread,\n \n \tGST_DEBUG_OBJECT(self, \"Streaming thread has started\");\n \n-\tgint stream_id_num = 0;\n \tStreamRoles roles;\n \tfor (GstPad *srcpad : state->srcpads_) {\n \t\t/* Create stream-id and push stream-start. */\n-\t\tg_autofree gchar *stream_id_intermediate = g_strdup_printf(\"%i%i\", state->group_id_, stream_id_num++);\n-\t\tg_autofree gchar *stream_id = gst_pad_create_stream_id(srcpad, GST_ELEMENT(self), stream_id_intermediate);\n-\t\tGstEvent *event = gst_event_new_stream_start(stream_id);\n-\t\tgst_event_set_group_id(event, state->group_id_);\n-\t\tgst_pad_push_event(srcpad, event);\n+\t\tgst_libcamera_pad_push_stream_start(srcpad, state->group_id_);\n \n \t\t/* Collect the streams roles for the next iteration. */\n \t\troles.push_back(gst_libcamera_pad_get_role(srcpad));\n","prefixes":["libcamera-devel","RFC","v1","2/2"]}