[{"id":18241,"web_url":"https://patchwork.libcamera.org/comment/18241/","msgid":"","date":"2021-07-20T18:00:30","subject":"Re: [libcamera-devel] [PATCH v2] Documentation: guides:\n\tapplication-developer: update pkgconfig name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jul 20, 2021 at 07:17:43PM +0900, Paul Elder wrote:\n> The pkgconfig name was changed from camera to libcamera, but the\n> application developer guide wasn't updated. Update it to refer to the\n> new name.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=65\n> Fixes: ec7afef6 (\"libcamera: Rename libcamera pkg-config generation\")\n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v2:\n> - fix another line that went unnoticed\n> ---\n> Documentation/guides/application-developer.rst | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index e3430f03..e0bbbad4 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -596,12 +596,12 @@ has been installed in your system.\n> \n> export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/\n> \n> -Verify that ``pkg-config`` can identify the ``camera`` library with\n> +Verify that ``pkg-config`` can identify the ``libcamera`` library with\n> \n> .. code:: shell\n> \n> - $ pkg-config --libs --cflags camera\n> - -I/usr/local/include/libcamera -L/usr/local/lib -lcamera\n> + $ pkg-config --libs --cflags libcamera\n> + -I/usr/local/include/libcamera -L/usr/local/lib -lcamera -lcamera-base\n> \n> ``meson`` can alternatively use ``cmake`` to locate packages, please refer to\n> the ``meson`` documentation if you prefer to use it in place of ``pkgconfig``\n> @@ -621,11 +621,11 @@ accordingly. In this example, the application file has been named\n> \n> simpler_cam = executable('simple-cam',\n> 'simple-cam.cpp',\n> - dependencies: dependency('camera', required : true))\n> + dependencies: dependency('libcamera', required : true))\n> \n> The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to\n> -locate the ``camera`` library, (libcamera without the lib prefix) which the test\n> -application will be dynamically linked against.\n> +locate the ``libcamera`` library, which the test application will be\n> +dynamically linked against.\n> \n> With the build file in place, compile and run the application with:\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 728AAC0109\n\tfor ;\n\tTue, 20 Jul 2021 18:00:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFB596853F;\n\tTue, 20 Jul 2021 20:00:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 470DD68521\n\tfor ;\n\tTue, 20 Jul 2021 20:00:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF97951D;\n\tTue, 20 Jul 2021 20:00:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lXTMyd+r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626804034;\n\tbh=5rIo7r+SpaOJ0HFKszJ5HgIfOQup1uzvA53AY39d1PY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lXTMyd+rksBbbdhKYeUR/xliGDT/13wiLNPs3t7zfgcxS5WJ00UjUa2JdJ1/XPxpI\n\tI4JXRcOdc+yDIiwcpuEBwzL+QahPtSRDW1ihlKwWrwudo2V3rimJSwStv3L8vZzgyh\n\tl9RU+n9VDJFeETA6xFuMRgEKIVK6jK0TmKdBxlIU=","Date":"Tue, 20 Jul 2021 21:00:30 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210720101743.26676-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210720101743.26676-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] Documentation: guides:\n\tapplication-developer: update pkgconfig name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"carl_wikstrom@hotmail.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18354,"web_url":"https://patchwork.libcamera.org/comment/18354/","msgid":"<9f83ed89-1cbf-08b6-61ca-ee1b37c562a1@ideasonboard.com>","date":"2021-07-26T10:29:08","subject":"Re: [libcamera-devel] [PATCH v2] Documentation: guides:\n\tapplication-developer: update pkgconfig name","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 20/07/2021 11:17, Paul Elder wrote:\n> The pkgconfig name was changed from camera to libcamera, but the\n> application developer guide wasn't updated. Update it to refer to the\n> new name.\n\nOops. Sorry :-(\n\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=65\n> Fixes: ec7afef6 (\"libcamera: Rename libcamera pkg-config generation\")\n> Signed-off-by: Paul Elder \n> \n\nReviewed-by: Kieran Bingham \n\n> ---\n> Changes in v2:\n> - fix another line that went unnoticed\n> ---\n> Documentation/guides/application-developer.rst | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index e3430f03..e0bbbad4 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -596,12 +596,12 @@ has been installed in your system.\n> \n> export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/\n> \n> -Verify that ``pkg-config`` can identify the ``camera`` library with\n> +Verify that ``pkg-config`` can identify the ``libcamera`` library with\n> \n> .. code:: shell\n> \n> - $ pkg-config --libs --cflags camera\n> - -I/usr/local/include/libcamera -L/usr/local/lib -lcamera\n> + $ pkg-config --libs --cflags libcamera\n> + -I/usr/local/include/libcamera -L/usr/local/lib -lcamera -lcamera-base\n> \n> ``meson`` can alternatively use ``cmake`` to locate packages, please refer to\n> the ``meson`` documentation if you prefer to use it in place of ``pkgconfig``\n> @@ -621,11 +621,11 @@ accordingly. In this example, the application file has been named\n> \n> simpler_cam = executable('simple-cam',\n> 'simple-cam.cpp',\n> - dependencies: dependency('camera', required : true))\n> + dependencies: dependency('libcamera', required : true))\n> \n> The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to\n> -locate the ``camera`` library, (libcamera without the lib prefix) which the test\n> -application will be dynamically linked against.\n> +locate the ``libcamera`` library, which the test application will be\n> +dynamically linked against.\n> \n> With the build file in place, compile and run the application with:\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BEDABC0109\n\tfor ;\n\tMon, 26 Jul 2021 10:29:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F27DA687B9;\n\tMon, 26 Jul 2021 12:29:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FAEA68536\n\tfor ;\n\tMon, 26 Jul 2021 12:29:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CACA9332;\n\tMon, 26 Jul 2021 12:29:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f5JXivx5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627295351;\n\tbh=gKBPod+JYtAPZWu0Oaf4AuzTGtjAn0YZHriN0SA2vX4=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=f5JXivx5lYehduDnB++iUp8heVkUl5pM1Eon18Ogl8ra4Jlu1ZJ0s7cLWhjoA4SzJ\n\tIuqSE77+qK2ksPc7Ezf8Wnag1MsLWbWR6qiUh+riKR+ua5Z8XZ1X+e36tnZ8pS7CqC\n\txlokdAf9ihemDWq0xWu1nmF6lfVRccJlZ9Frd5Vg=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210720101743.26676-1-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<9f83ed89-1cbf-08b6-61ca-ee1b37c562a1@ideasonboard.com>","Date":"Mon, 26 Jul 2021 11:29:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210720101743.26676-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] Documentation: guides:\n\tapplication-developer: update pkgconfig name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"carl_wikstrom@hotmail.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]