[{"id":18327,"web_url":"https://patchwork.libcamera.org/comment/18327/","msgid":"","date":"2021-07-25T00:38:24","subject":"Re: [libcamera-devel] [PATCH v5 3/9] android: metadata: Fix\n\taddEntry template type","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jul 20, 2021 at 07:13:01PM +0900, Paul Elder wrote:\n> Since we set entries with android tags directly, which are enums and not\n> arithmetic types, the addEntry template fails to match. Fix this by also\n> allowing enum values in addEntry.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> New in v4\n> ---\n> src/android/camera_metadata.h | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 72ba4db2..6e51efb5 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -44,7 +44,8 @@ public:\n> \tbool hasEntry(uint32_t tag) const;\n> \n> \ttemplate -\t\t std::enable_if_t> * = nullptr>\n> +\t\t std::enable_if_t ||\n> +\t\t\t\t std::is_enum_v> * = nullptr>\n> \tbool addEntry(uint32_t tag, const T &data)\n> \t{\n> \t\treturn addEntry(tag, &data, 1, sizeof(T));","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EA37C0109\n\tfor ;\n\tSun, 25 Jul 2021 00:38:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6339687B5;\n\tSun, 25 Jul 2021 02:38:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBF7660274\n\tfor ;\n\tSun, 25 Jul 2021 02:38:27 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68BF7255;\n\tSun, 25 Jul 2021 02:38:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IN4n/dZH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627173507;\n\tbh=yBcT2+q5GG8XfmFQjlRmBKfCZgS5c82LVHF3Pq0+ibM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IN4n/dZHQkLVab0nmQ9F8vVZcyrBtdIoYzBpgW2RqslgpGpe5QH+HHFbi++xgzLHs\n\tlJm4S3PdE3j59p1twhd4zzDd0Ga/brwbEp3UUbtQCmWLKpKiZbhxE3Ekze8AuPs0mg\n\t+oCx2J302e6zSiGPca9Z3YFi5yXhkk7Da+oqFM1E=","Date":"Sun, 25 Jul 2021 03:38:24 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210720101307.26010-1-paul.elder@ideasonboard.com>\n\t<20210720101307.26010-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210720101307.26010-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 3/9] android: metadata: Fix\n\taddEntry template type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]