{"id":13051,"url":"https://patchwork.libcamera.org/api/patches/13051/?format=json","web_url":"https://patchwork.libcamera.org/patch/13051/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210720101307.26010-3-paul.elder@ideasonboard.com>","date":"2021-07-20T10:13:00","name":"[libcamera-devel,v5,2/9] android: metadata: Add hasEntry and entryContains","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d63f3a27cb25545cd97bdd02fec7a3e1088c6102","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13051/mbox/","series":[{"id":2258,"url":"https://patchwork.libcamera.org/api/series/2258/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2258","date":"2021-07-20T10:12:58","name":"android: Support capability and hardware level detection","version":5,"mbox":"https://patchwork.libcamera.org/series/2258/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13051/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13051/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D99BC0109\n\tfor ;\n\tTue, 20 Jul 2021 10:13:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10FAF68536;\n\tTue, 20 Jul 2021 12:13:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DC8968545\n\tfor ;\n\tTue, 20 Jul 2021 12:13:23 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F40D51D;\n\tTue, 20 Jul 2021 12:13:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XYLtAY93\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626776003;\n\tbh=xj6Q2s9ieFwnt/fu+W8h11HgI+xs6p4AmUSCqNLCLcY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XYLtAY93XLW8o2B1ahgnozPMj3n+TJ+wDvRybZd9gEHvOYnACu+9Pw+1yMUVSmWAs\n\tcA5pD6eQU0VuElZkO1TzSjKfspEOv8r3e/Q9LvDXsoXxVjIKty4zL5/69mRalK4sJT\n\tI7rhjV+QgXsvYG/zZots53sdy7EnPFHjFjnlVc5Q=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Jul 2021 19:13:00 +0900","Message-Id":"<20210720101307.26010-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210720101307.26010-1-paul.elder@ideasonboard.com>","References":"<20210720101307.26010-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 2/9] android: metadata: Add hasEntry\n\tand entryContains","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add convenience functions for checking if an entry is present in a\nCameraMetadata instance, and to check if an array entry includes a\nspecific value.\n\nSigned-off-by: Paul Elder \n\n---\nChanges in v5:\n- refactor template code to reduce the footprint of specialized template\n code\n\nNew in v4\n---\n src/android/camera_metadata.cpp | 18 ++++++++++++++++++\n src/android/camera_metadata.h | 14 ++++++++++++++\n 2 files changed, 32 insertions(+)","diff":"diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex 3fc7cf27..ac86c5fc 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -121,6 +121,24 @@ bool CameraMetadata::resize(size_t count, size_t size)\n \treturn true;\n }\n \n+template<>\n+bool CameraMetadata::entryContainsOne(const camera_metadata_ro_entry_t &entry,\n+\t\t\t\t\t uint8_t value) const\n+{\n+\tfor (unsigned int i = 0; i < entry.count; i++) {\n+\t\tif (entry.data.u8[i] == value)\n+\t\t\treturn true;\n+\t}\n+\n+\treturn false;\n+}\n+\n+bool CameraMetadata::hasEntry(uint32_t tag) const\n+{\n+\tcamera_metadata_ro_entry_t entry;\n+\treturn getEntry(tag, &entry);\n+}\n+\n bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count,\n \t\t\t size_t elementSize)\n {\ndiff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 3b7c9e24..72ba4db2 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -29,6 +29,20 @@ public:\n \tbool isValid() const { return valid_; }\n \tbool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n \n+\ttemplate\n+\tbool entryContainsOne(const camera_metadata_ro_entry_t &entry, T value) const;\n+\n+\ttemplate bool entryContains(uint32_t tag, T value) const\n+\t{\n+\t\tcamera_metadata_ro_entry_t entry;\n+\t\tif (!getEntry(tag, &entry))\n+\t\t\treturn false;\n+\n+\t\treturn entryContainsOne(entry, value);\n+\t}\n+\n+\tbool hasEntry(uint32_t tag) const;\n+\n \ttemplate> * = nullptr>\n \tbool addEntry(uint32_t tag, const T &data)\n","prefixes":["libcamera-devel","v5","2/9"]}