[{"id":18236,"web_url":"https://patchwork.libcamera.org/comment/18236/","msgid":"","date":"2021-07-20T09:26:09","subject":"Re: [libcamera-devel] [PATCH] Documentation: guides:\n\tapplication-developer: update pkgconfig name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jul 20, 2021 at 01:16:09PM +0900, Paul Elder wrote:\n> The pkgconfig name was changed from camera to libcamera, but the\n> application developer guide wasn't updated. Update it to refer to the\n> new name.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=65\n> Fixes: ec7afef6 (\"libcamera: Rename libcamera pkg-config generation\")\n> Signed-off-by: Paul Elder \n> ---\n> Documentation/guides/application-developer.rst | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\n> index e3430f03..9c7b1bb0 100644\n> --- a/Documentation/guides/application-developer.rst\n> +++ b/Documentation/guides/application-developer.rst\n> @@ -596,12 +596,12 @@ has been installed in your system.\n> \n> export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/\n> \n> -Verify that ``pkg-config`` can identify the ``camera`` library with\n> +Verify that ``pkg-config`` can identify the ``libcamera`` library with\n> \n> .. code:: shell\n> \n> - $ pkg-config --libs --cflags camera\n> - -I/usr/local/include/libcamera -L/usr/local/lib -lcamera\n> + $ pkg-config --libs --cflags libcamera\n> + -I/usr/local/include/libcamera -L/usr/local/lib -lcamera -lcamera-base\n> \n> ``meson`` can alternatively use ``cmake`` to locate packages, please refer to\n> the ``meson`` documentation if you prefer to use it in place of ``pkgconfig``\n> @@ -621,7 +621,7 @@ accordingly. In this example, the application file has been named\n> \n> simpler_cam = executable('simple-cam',\n> 'simple-cam.cpp',\n> - dependencies: dependency('camera', required : true))\n> + dependencies: dependency('libcamera', required : true))\n> \n> The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to\n> locate the ``camera`` library, (libcamera without the lib prefix) which the test\n\nThis should be updated too. There may be other occurences I have missed.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4AF3C322B\n\tfor ;\n\tTue, 20 Jul 2021 09:26:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 395B468543;\n\tTue, 20 Jul 2021 11:26:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F03A160278\n\tfor ;\n\tTue, 20 Jul 2021 11:26:13 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 605FF443;\n\tTue, 20 Jul 2021 11:26:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IKdER6GX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626773173;\n\tbh=A6F+IRuNQFHTt1O6YHaI5rmRhobeM7nher7+9XVKNnA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IKdER6GXBeqm7ergDfuU2V0ghQ7Z2FDB9mT32MduQKtTG724xvoUyQcP0yCaaD2Ai\n\t5pM7lkeNjYSUv6B8NLAO/Uea3gQeDzONGBZ6Cn4+dM4y0WaZ8oAxP/Jzl+Y5FnsmTG\n\thEvyGnUDukZt4+cqTROcIzy/pVLI+dHs9Gt5XZjQ=","Date":"Tue, 20 Jul 2021 12:26:09 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210720041609.6460-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210720041609.6460-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] Documentation: guides:\n\tapplication-developer: update pkgconfig name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"carl_wikstrom@hotmail.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]