[{"id":18251,"web_url":"https://patchwork.libcamera.org/comment/18251/","msgid":"","date":"2021-07-22T06:37:05","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Tidy-up includes","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 7/16/21 8:02 PM, Jacopo Mondi wrote:\n> Tidy-up a bit the inclusions directive in the IPU3 IPA module.\n>\n> In detail:\n> - ipu3.cpp is missing inclusions for:\n> std::abs from \n> std::map from \n> std::min/max from \n> std::numeric_limits from \n> std::unique_ptr from \n> std::vector from \n>\n> and does not require \n>\n> - ipu3_agc has two not used inclusions in the header file and one the cpp file\n> and is missing for std::literals::chrono_literals\n\nThe comes from included in ipu3_agc.h, \nsince we use `Duration` wrapper in class IPU3Agc. Should be again \nincluding the header in ipu3_agc.cpp for chrono_literals?\n\n\n>\n> - ipu3_awb is missing for std::sort and does not use\n> or \n>\n> Signed-off-by: Jacopo Mondi \n\nRest good looks so,\n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 7 ++++++-\n> src/ipa/ipu3/ipu3_agc.cpp | 2 +-\n> src/ipa/ipu3/ipu3_agc.h | 3 ---\n> src/ipa/ipu3/ipu3_awb.cpp | 3 +--\n> 4 files changed, 8 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index d3c69bc07bd0..dc22acd4fd08 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -5,10 +5,15 @@\n> * ipu3.cpp - IPU3 Image Processing Algorithms\n> */\n> \n> +#include \n> #include \n> +#include \n> +#include \n> +#include \n> +#include \n> #include \n> -#include \n> #include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp\n> index 6253ab94cff1..408eb849b428 100644\n> --- a/src/ipa/ipu3/ipu3_agc.cpp\n> +++ b/src/ipa/ipu3/ipu3_agc.cpp\n> @@ -8,8 +8,8 @@\n> #include \"ipu3_agc.h\"\n> \n> #include \n> +#include \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\n> index 3deca3ae6933..9f3d4257d945 100644\n> --- a/src/ipa/ipu3/ipu3_agc.h\n> +++ b/src/ipa/ipu3/ipu3_agc.h\n> @@ -7,9 +7,6 @@\n> #ifndef __LIBCAMERA_IPU3_AGC_H__\n> #define __LIBCAMERA_IPU3_AGC_H__\n> \n> -#include \n> -#include \n> -\n> #include \n> \n> #include \n> diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\n> index 9b409c8ffad9..4bb321b377a2 100644\n> --- a/src/ipa/ipu3/ipu3_awb.cpp\n> +++ b/src/ipa/ipu3/ipu3_awb.cpp\n> @@ -6,9 +6,8 @@\n> */\n> #include \"ipu3_awb.h\"\n> \n> +#include \n> #include \n> -#include \n> -#include \n> \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D09FC0109\n\tfor ;\n\tThu, 22 Jul 2021 06:37:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED32368545;\n\tThu, 22 Jul 2021 08:37:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B37A560275\n\tfor ;\n\tThu, 22 Jul 2021 08:37:10 +0200 (CEST)","from [192.168.0.107] (unknown [103.238.109.21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD2B5465;\n\tThu, 22 Jul 2021 08:37:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U3T5cWUp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626935830;\n\tbh=vYKasep2YSXvDCNGYQbRLzKaEkfj7BNq+tTXPGIVZ0I=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=U3T5cWUp/wOkKeZrdlkixIjO9h3vKOQQoL6h/K0WF+IbFvfcJuaTulwja/55hWuSr\n\t+7gc+1191KwGoD0OMV6NituNcgN2D0QODbxCR9oRXaToq7viwlAXPHN0ZintQQ+3mY\n\tkjMTeDGIEFCIti9eAnmBFjZ1XzWoHoYLzBLArzdI=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210716143215.67454-1-jacopo@jmondi.org>\n\t<20210716143215.67454-3-jacopo@jmondi.org>","From":"Umang Jain ","Message-ID":"","Date":"Thu, 22 Jul 2021 12:07:05 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210716143215.67454-3-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Tidy-up includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18331,"web_url":"https://patchwork.libcamera.org/comment/18331/","msgid":"","date":"2021-07-25T01:29:52","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Tidy-up includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Jul 16, 2021 at 04:32:15PM +0200, Jacopo Mondi wrote:\n> Tidy-up a bit the inclusions directive in the IPU3 IPA module.\n> \n> In detail:\n> - ipu3.cpp is missing inclusions for:\n> std::abs from \n> std::map from \n> std::min/max from \n> std::numeric_limits from \n> std::unique_ptr from \n> std::vector from \n> \n> and does not require \n> \n> - ipu3_agc has two not used inclusions in the header file and one the cpp file\n> and is missing for std::literals::chrono_literals\n> \n> - ipu3_awb is missing for std::sort and does not use\n> or \n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 7 ++++++-\n> src/ipa/ipu3/ipu3_agc.cpp | 2 +-\n> src/ipa/ipu3/ipu3_agc.h | 3 ---\n> src/ipa/ipu3/ipu3_awb.cpp | 3 +--\n> 4 files changed, 8 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index d3c69bc07bd0..dc22acd4fd08 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -5,10 +5,15 @@\n> * ipu3.cpp - IPU3 Image Processing Algorithms\n> */\n> \n> +#include \n> #include \n> +#include \n> +#include \n> +#include \n> +#include \n> #include \n> -#include \n> #include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp\n> index 6253ab94cff1..408eb849b428 100644\n> --- a/src/ipa/ipu3/ipu3_agc.cpp\n> +++ b/src/ipa/ipu3/ipu3_agc.cpp\n> @@ -8,8 +8,8 @@\n> #include \"ipu3_agc.h\"\n> \n> #include \n> +#include \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\n> index 3deca3ae6933..9f3d4257d945 100644\n> --- a/src/ipa/ipu3/ipu3_agc.h\n> +++ b/src/ipa/ipu3/ipu3_agc.h\n> @@ -7,9 +7,6 @@\n> #ifndef __LIBCAMERA_IPU3_AGC_H__\n> #define __LIBCAMERA_IPU3_AGC_H__\n> \n> -#include \n> -#include \n> -\n> #include \n> \n> #include \n> diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\n> index 9b409c8ffad9..4bb321b377a2 100644\n> --- a/src/ipa/ipu3/ipu3_awb.cpp\n> +++ b/src/ipa/ipu3/ipu3_awb.cpp\n> @@ -6,9 +6,8 @@\n> */\n> #include \"ipu3_awb.h\"\n> \n> +#include \n> #include \n> -#include \n> -#include \n> \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58135C322C\n\tfor ;\n\tSun, 25 Jul 2021 01:29:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1BC6687B5;\n\tSun, 25 Jul 2021 03:29:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FF3B60274\n\tfor ;\n\tSun, 25 Jul 2021 03:29:56 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4035255;\n\tSun, 25 Jul 2021 03:29:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B+tebPR2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627176595;\n\tbh=M52Z/nsEVDpGg43/kLkqDXI6q3eH9lDxiUuvZ/hRHNc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=B+tebPR2f566fO4i3kqRUYSuLmhcBiO6gNFarumF6HsuYIbkpFqpa4XID6u4w1Kle\n\tc5UuCFFudydO68K/0gnoNYwMgHbHz3Do17lgXhdHZnvZA4v/Ujm+t87MxAdXtpE5/V\n\tUMoBro8bd32IfZpxcpGK3Mb9zGdpfhp9BPT2byMo=","Date":"Sun, 25 Jul 2021 04:29:52 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210716143215.67454-1-jacopo@jmondi.org>\n\t<20210716143215.67454-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210716143215.67454-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Tidy-up includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18339,"web_url":"https://patchwork.libcamera.org/comment/18339/","msgid":"<20210726082012.vwtxouawett6mw57@uno.localdomain>","date":"2021-07-26T08:20:12","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Tidy-up includes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello Umang,\n\nOn Thu, Jul 22, 2021 at 12:07:05PM +0530, Umang Jain wrote:\n> Hi Jacopo,\n>\n> On 7/16/21 8:02 PM, Jacopo Mondi wrote:\n> > Tidy-up a bit the inclusions directive in the IPU3 IPA module.\n> >\n> > In detail:\n> > - ipu3.cpp is missing inclusions for:\n> > std::abs from \n> > std::map from \n> > std::min/max from \n> > std::numeric_limits from \n> > std::unique_ptr from \n> > std::vector from \n> >\n> > and does not require \n> >\n> > - ipu3_agc has two not used inclusions in the header file and one the cpp file\n> > and is missing for std::literals::chrono_literals\n>\n> The comes from included in ipu3_agc.h,\n> since we use `Duration` wrapper in class IPU3Agc. Should be again including\n> the header in ipu3_agc.cpp for chrono_literals?\n>\n\nI think it's always good not to resort on indirect inclusions. It\nguarantees the file is valid regardless of what's included in the one\nit relies on, and there's no penalty to pay in terms of additional\nfile size thanks for headers' inclusion guards.\n\n>\n> >\n> > - ipu3_awb is missing for std::sort and does not use\n> > or \n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> Rest good looks so,\n>\n> Reviewed-by: Umang Jain \n>\n\nThanks\n j\n\n> > ---\n> > src/ipa/ipu3/ipu3.cpp | 7 ++++++-\n> > src/ipa/ipu3/ipu3_agc.cpp | 2 +-\n> > src/ipa/ipu3/ipu3_agc.h | 3 ---\n> > src/ipa/ipu3/ipu3_awb.cpp | 3 +--\n> > 4 files changed, 8 insertions(+), 7 deletions(-)\n> >\n> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > index d3c69bc07bd0..dc22acd4fd08 100644\n> > --- a/src/ipa/ipu3/ipu3.cpp\n> > +++ b/src/ipa/ipu3/ipu3.cpp\n> > @@ -5,10 +5,15 @@\n> > * ipu3.cpp - IPU3 Image Processing Algorithms\n> > */\n> > +#include \n> > #include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > #include \n> > -#include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > diff --git a/src/ipa/ipu3/ipu3_agc.cpp b/src/ipa/ipu3/ipu3_agc.cpp\n> > index 6253ab94cff1..408eb849b428 100644\n> > --- a/src/ipa/ipu3/ipu3_agc.cpp\n> > +++ b/src/ipa/ipu3/ipu3_agc.cpp\n> > @@ -8,8 +8,8 @@\n> > #include \"ipu3_agc.h\"\n> > #include \n> > +#include \n> > #include \n> > -#include \n> > #include \n> > diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h\n> > index 3deca3ae6933..9f3d4257d945 100644\n> > --- a/src/ipa/ipu3/ipu3_agc.h\n> > +++ b/src/ipa/ipu3/ipu3_agc.h\n> > @@ -7,9 +7,6 @@\n> > #ifndef __LIBCAMERA_IPU3_AGC_H__\n> > #define __LIBCAMERA_IPU3_AGC_H__\n> > -#include \n> > -#include \n> > -\n> > #include \n> > #include \n> > diff --git a/src/ipa/ipu3/ipu3_awb.cpp b/src/ipa/ipu3/ipu3_awb.cpp\n> > index 9b409c8ffad9..4bb321b377a2 100644\n> > --- a/src/ipa/ipu3/ipu3_awb.cpp\n> > +++ b/src/ipa/ipu3/ipu3_awb.cpp\n> > @@ -6,9 +6,8 @@\n> > */\n> > #include \"ipu3_awb.h\"\n> > +#include \n> > #include \n> > -#include \n> > -#include \n> > #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1513AC322C\n\tfor ;\n\tMon, 26 Jul 2021 08:19:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75732687B8;\n\tMon, 26 Jul 2021 10:19:37 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABD1A687B3\n\tfor ;\n\tMon, 26 Jul 2021 10:19:36 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 2D9B92000F;\n\tMon, 26 Jul 2021 08:19:24 +0000 (UTC)"],"Date":"Mon, 26 Jul 2021 10:20:12 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210726082012.vwtxouawett6mw57@uno.localdomain>","References":"<20210716143215.67454-1-jacopo@jmondi.org>\n\t<20210716143215.67454-3-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: ipu3: Tidy-up includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]