{"id":13024,"url":"https://patchwork.libcamera.org/api/patches/13024/?format=json","web_url":"https://patchwork.libcamera.org/patch/13024/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210716105631.158153-19-paul.elder@ideasonboard.com>","date":"2021-07-16T10:56:28","name":"[libcamera-devel,RFC,v4,18/21] pipeline: ipu3: Set AeEnable ControlInfo","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e1fceaa728d0efcb6d2e57374b6c8490dc7e914f","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13024/mbox/","series":[{"id":2244,"url":"https://patchwork.libcamera.org/api/series/2244/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2244","date":"2021-07-16T10:56:10","name":"Preliminary FULL plumbing","version":4,"mbox":"https://patchwork.libcamera.org/series/2244/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13024/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13024/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83FB2C3228\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Jul 2021 10:57:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E1A968542;\n\tFri, 16 Jul 2021 12:57:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F9406854F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Jul 2021 12:57:26 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A7B213F0;\n\tFri, 16 Jul 2021 12:57:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pz5ZFpcK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626433045;\n\tbh=689GpRHTcGieCMwZvgmguQSZpIdDimKjdEG9VkNldWU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pz5ZFpcKCHipAfXPifLXAiL6md/PkYey/5O/27rdDExciPmZlaPGL4TfZ5hjvatLh\n\tnSUymSW1pjvrvXSjf5grdusdsfs9Au/zo2oXVbmPrOe1rtdkI2xOfqU1DQWzgaHOfk\n\tfd2bJnzqeOqvAOZFv1mIMldZf0xB06qhuE9CqL9c=","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 16 Jul 2021 19:56:28 +0900","Message-Id":"<20210716105631.158153-19-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210716105631.158153-1-paul.elder@ideasonboard.com>","References":"<20210716105631.158153-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v4 18/21] pipeline: ipu3: Set AeEnable\n\tControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"We want the IPU3 IPA to support enabling and disabling AE, so initialize\nthe AeEnable ControlInfo in the IPU3 pipeline handler.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=42\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v4:\n- use the actual new boolean ControlInfo constructor\n\nChanges in v3:\n- use boolean ControlInfo constructor\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex d3dafd98..0057c250 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -49,6 +49,7 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n static constexpr Size IPU3ViewfinderSize(1280, 720);\n \n static const ControlInfoMap::Map IPU3Controls = {\n+\t{ &controls::AeEnable, ControlInfo({ false, true }, true) },\n \t{ &controls::draft::MaxLatency, ControlInfo(0, 0, 0) },\n \t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n };\n","prefixes":["libcamera-devel","RFC","v4","18/21"]}