[{"id":18213,"web_url":"https://patchwork.libcamera.org/comment/18213/","msgid":"<20210717102510.k7r4vdycf5rpnt76@uno.localdomain>","date":"2021-07-17T10:25:10","subject":"Re: [libcamera-devel] [RFC PATCH v4 09/21] android,\n\tcontrols: Add and plumb MaxLatency control","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Jul 16, 2021 at 07:56:19PM +0900, Paul Elder wrote:\n> Add a MaxLatency control, and plumb it into the HAL accordingly.\n>\n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n>\n> ---\n> Changes in v3:\n> - use v3 setMetadata\n> - add comment to explain 4\n> - remove todo\n>\n> Changes in v2:\n> - use new setMetadata\n> - rebase on camera capabilities refactor\n> ---\n> src/android/camera_capabilities.cpp | 7 +++++--\n> src/libcamera/control_ids.yaml | 10 ++++++++++\n> 2 files changed, 15 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 21e31cf2..c333b329 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1127,8 +1127,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t}\n>\n> \t/* Sync static metadata. */\n> -\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n> -\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n> +\tsetMetadata(\n> +\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n\nAs I've read this, I thought if\n\n staticMetadata->setMetadata()\n\nwouldn't be a nicer API\n\n> +\t\tcontrolsInfo, &controls::draft::MaxLatency,\n> +\t\tControlRange::Def,\n\nIf ::Def serves to get which ControlValue to get from ControlInfo,\ncan't we pass the ControlValue in directly ?\n\nAnyway, these comments are not on this patch\n\n> +\t\tANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n>\n> \t/* Flash static metadata. */\n> \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index d92f29f5..9d4638ae 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -622,6 +622,16 @@ controls:\n> detection, additional format conversions etc) count as an additional\n> pipeline stage.\n>\n> + - MaxLatency:\n> + type: int32_t\n> + draft: true\n> + description: |\n> + The maximum number of frames that can occur after a request (different\n> + than the previous) has been submitted, and before the result's state\n> + becomes synchronized. A value of -1 indicates unknown latency, and 0\n> + indicates per-frame control. Currently identical to\n> + ANDROID_SYNC_MAX_LATENCY.\n> +\n\nDo we have a sorting order for controls ? It seems we don't...\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> - TestPatternMode:\n> type: int32_t\n> draft: true\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44200C3228\n\tfor ;\n\tSat, 17 Jul 2021 10:24:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A478368536;\n\tSat, 17 Jul 2021 12:24:24 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FBF66027B\n\tfor ;\n\tSat, 17 Jul 2021 12:24:23 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 110ED100002;\n\tSat, 17 Jul 2021 10:24:22 +0000 (UTC)"],"Date":"Sat, 17 Jul 2021 12:25:10 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210717102510.k7r4vdycf5rpnt76@uno.localdomain>","References":"<20210716105631.158153-1-paul.elder@ideasonboard.com>\n\t<20210716105631.158153-10-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210716105631.158153-10-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v4 09/21] android,\n\tcontrols: Add and plumb MaxLatency control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18224,"web_url":"https://patchwork.libcamera.org/comment/18224/","msgid":"<20210719055038.GK2395@pyrite.rasen.tech>","date":"2021-07-19T05:50:38","subject":"Re: [libcamera-devel] [RFC PATCH v4 09/21] android,\n\tcontrols: Add and plumb MaxLatency control","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Sat, Jul 17, 2021 at 12:25:10PM +0200, Jacopo Mondi wrote:\n> Hi Paul,\n> \n> On Fri, Jul 16, 2021 at 07:56:19PM +0900, Paul Elder wrote:\n> > Add a MaxLatency control, and plumb it into the HAL accordingly.\n> >\n> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=50\n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Laurent Pinchart \n> >\n> > ---\n> > Changes in v3:\n> > - use v3 setMetadata\n> > - add comment to explain 4\n> > - remove todo\n> >\n> > Changes in v2:\n> > - use new setMetadata\n> > - rebase on camera capabilities refactor\n> > ---\n> > src/android/camera_capabilities.cpp | 7 +++++--\n> > src/libcamera/control_ids.yaml | 10 ++++++++++\n> > 2 files changed, 15 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > index 21e31cf2..c333b329 100644\n> > --- a/src/android/camera_capabilities.cpp\n> > +++ b/src/android/camera_capabilities.cpp\n> > @@ -1127,8 +1127,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> > \t}\n> >\n> > \t/* Sync static metadata. */\n> > -\tint32_t maxLatency = ANDROID_SYNC_MAX_LATENCY_UNKNOWN;\n> > -\tstaticMetadata_->addEntry(ANDROID_SYNC_MAX_LATENCY, maxLatency);\n> > +\tsetMetadata(\n> > +\t\tstaticMetadata_.get(), ANDROID_SYNC_MAX_LATENCY,\n> \n> As I've read this, I thought if\n> \n> staticMetadata->setMetadata()\n> \n> wouldn't be a nicer API\n\nsetMetadata() reconciles (?) libcamera controls into android controls.\nstaticMetadata (CameraMetadata) is a wrapper around the android\nmetadata, so it shouldn't be dealing with libcamera controls.\n\n> \n> > +\t\tcontrolsInfo, &controls::draft::MaxLatency,\n> > +\t\tControlRange::Def,\n> \n> If ::Def serves to get which ControlValue to get from ControlInfo,\n> can't we pass the ControlValue in directly ?\n\nThen we have to do find() and if (it != end()), and that's what I want\nto avoid :D Don't you remember how much copy&pasting there was of\nexactly that?\n\n> \n> Anyway, these comments are not on this patch\n> \n> > +\t\tANDROID_SYNC_MAX_LATENCY_UNKNOWN);\n> >\n> > \t/* Flash static metadata. */\n> > \tchar flashAvailable = ANDROID_FLASH_INFO_AVAILABLE_FALSE;\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index d92f29f5..9d4638ae 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -622,6 +622,16 @@ controls:\n> > detection, additional format conversions etc) count as an additional\n> > pipeline stage.\n> >\n> > + - MaxLatency:\n> > + type: int32_t\n> > + draft: true\n> > + description: |\n> > + The maximum number of frames that can occur after a request (different\n> > + than the previous) has been submitted, and before the result's state\n> > + becomes synchronized. A value of -1 indicates unknown latency, and 0\n> > + indicates per-frame control. Currently identical to\n> > + ANDROID_SYNC_MAX_LATENCY.\n> > +\n> \n> Do we have a sorting order for controls ? It seems we don't...\n\nApparently not.\n\n> Reviewed-by: Jacopo Mondi \n\n\nThanks,\n\nPaul\n\n> \n> > - TestPatternMode:\n> > type: int32_t\n> > draft: true\n> > --\n> > 2.27.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75991C322B\n\tfor ;\n\tMon, 19 Jul 2021 05:50:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E62BB6853A;\n\tMon, 19 Jul 2021 07:50:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9139D60278\n\tfor ;\n\tMon, 19 Jul 2021 07:50:46 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9B03465;\n\tMon, 19 Jul 2021 07:50:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mk1Ch7+g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626673846;\n\tbh=rzBArItCW4G29UIS8g9bgc5WHCY25E+4Fzi1RpYEc8Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mk1Ch7+gNB6D9PAUKQGlelOwUBsIrup2xNtGbP8WsOHuywTBXUroMVkiB+3b3GOcs\n\tutxCUqWwpOWsK5JtHsf8WUvHLaUD4YDabn38ggrDpyXWnKhmsAyKEVVD6WmQOx0q+n\n\tagjZVog2nL2/LKlOFx8vB37qJ8ol5KqGvcwKf1ss=","Date":"Mon, 19 Jul 2021 14:50:38 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210719055038.GK2395@pyrite.rasen.tech>","References":"<20210716105631.158153-1-paul.elder@ideasonboard.com>\n\t<20210716105631.158153-10-paul.elder@ideasonboard.com>\n\t<20210717102510.k7r4vdycf5rpnt76@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210717102510.k7r4vdycf5rpnt76@uno.localdomain>","Subject":"Re: [libcamera-devel] [RFC PATCH v4 09/21] android,\n\tcontrols: Add and plumb MaxLatency control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]