[{"id":18209,"web_url":"https://patchwork.libcamera.org/comment/18209/","msgid":"<20210717100036.a4i3chfwfywyxfwd@uno.localdomain>","date":"2021-07-17T10:00:36","subject":"Re: [libcamera-devel] [RFC PATCH v4 04/21] android: jpeg: get ISO\n\tfrom SENSOR_SENSITIVITY","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Jul 16, 2021 at 07:56:14PM +0900, Paul Elder wrote:\n> The data for the exif ISO tag needs to come from SENSOR_SENSITIVITY. Set\n> it.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n>\n> ---\n> This on its own doesn't fix any CTS tests, but it prevents a test\n> failure later on when we add the proper static metadata for the FULL\n> hardware level.\n\nIt doesn't hurt indeed!\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/jpeg/post_processor_jpeg.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 0e93f365..3160a784 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -119,7 +119,10 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \tret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);\n> \tif (ret)\n> \t\texif.setAperture(*entry.data.f);\n> -\texif.setISO(100);\n> +\n> +\tret = resultMetadata->getEntry(ANDROID_SENSOR_SENSITIVITY, &entry);\n> +\texif.setISO(ret ? *entry.data.i32 : 100);\n> +\n> \texif.setFlash(Exif::Flash::FlashNotPresent);\n> \texif.setWhiteBalance(Exif::WhiteBalance::Auto);\n>\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C594C0109\n\tfor ;\n\tSat, 17 Jul 2021 09:59:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52D536853B;\n\tSat, 17 Jul 2021 11:59:51 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E47706027F\n\tfor ;\n\tSat, 17 Jul 2021 11:59:49 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 75ACF100005;\n\tSat, 17 Jul 2021 09:59:49 +0000 (UTC)"],"Date":"Sat, 17 Jul 2021 12:00:36 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210717100036.a4i3chfwfywyxfwd@uno.localdomain>","References":"<20210716105631.158153-1-paul.elder@ideasonboard.com>\n\t<20210716105631.158153-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210716105631.158153-5-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v4 04/21] android: jpeg: get ISO\n\tfrom SENSOR_SENSITIVITY","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]