[{"id":18208,"web_url":"https://patchwork.libcamera.org/comment/18208/","msgid":"<20210717095953.v2kstpk4h2dzitta@uno.localdomain>","date":"2021-07-17T09:59:53","subject":"Re: [libcamera-devel] [RFC PATCH v4 03/21] android: metadata: Fix\n\taddEntry template type","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Jul 16, 2021 at 07:56:13PM +0900, Paul Elder wrote:\n> Since we set entries with android tags directly, which are enums and not\n> arithmetic types, the addEntry template fails to match. Fix this by also\n> allowing enum values in addEntry.\n>\n> Signed-off-by: Paul Elder \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> New in v4\n> ---\n> src/android/camera_metadata.h | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 03b3e701..60be416c 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -34,7 +34,8 @@ public:\n> \tbool hasEntry(uint32_t tag) const;\n>\n> \ttemplate -\t\t std::enable_if_t> * = nullptr>\n> +\t\t std::enable_if_t ||\n> +\t\t\t\t std::is_enum_v> * = nullptr>\n> \tbool addEntry(uint32_t tag, const T &data)\n> \t{\n> \t\treturn addEntry(tag, &data, 1, sizeof(T));\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF313C0109\n\tfor ;\n\tSat, 17 Jul 2021 09:59:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FB1E6853B;\n\tSat, 17 Jul 2021 11:59:07 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72AB56027F\n\tfor ;\n\tSat, 17 Jul 2021 11:59:06 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 01D1660002;\n\tSat, 17 Jul 2021 09:59:05 +0000 (UTC)"],"Date":"Sat, 17 Jul 2021 11:59:53 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210717095953.v2kstpk4h2dzitta@uno.localdomain>","References":"<20210716105631.158153-1-paul.elder@ideasonboard.com>\n\t<20210716105631.158153-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210716105631.158153-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v4 03/21] android: metadata: Fix\n\taddEntry template type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]