[{"id":18207,"web_url":"https://patchwork.libcamera.org/comment/18207/","msgid":"<20210717094939.4r3ifoc7xlvlakq4@uno.localdomain>","date":"2021-07-17T09:49:39","subject":"Re: [libcamera-devel] [RFC PATCH v4 02/21] android: metadata: Add\n\thasEntry and entryContains","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Jul 16, 2021 at 07:56:12PM +0900, Paul Elder wrote:\n> Add convenience functions for checking if the an entry is present in a\n\ns/if the an/if an/\n\n> CameraMetadata instance, and to check if an array entry includes a\n> specific value.\n>\nNice\n\n> Signed-off-by: Paul Elder \n>\n> ---\n> New in v4\n> ---\n> src/android/camera_metadata.cpp | 21 +++++++++++++++++++++\n> src/android/camera_metadata.h | 4 ++++\n> 2 files changed, 25 insertions(+)\n>\n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index 3fc7cf27..47199b68 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -121,6 +121,27 @@ bool CameraMetadata::resize(size_t count, size_t size)\n> \treturn true;\n> }\n>\n> +template<> bool CameraMetadata::entryContains(uint32_t tag, uint8_t value) const\n> +{\n> +\tcamera_metadata_ro_entry_t entry;\n> +\n> +\tif (!getEntry(tag, &entry))\n> +\t\treturn false;\n> +\n\nI would specialize only the part here below with spcializations of\n\nprivate\n template\n bool entryContainsOne(const camera_metadata_ro_entry_t &entry, T value) const;\n\nTo be specialized in the C++ file as\n template<>\n bool entryContainsOne(const camera_metadata_ro_entry_t &entry,\n uint8_t value) const\n {\n for (unsigned int i = 0; i < entry.count; i++) {\n if (entry.data.u8[i] == value)\n return true;\n }\n\n return false;\n }\n\n template<>\n bool entryContainsOne(const camera_metadata_ro_entry_t &entry,\n int32_t value) const\n {\n for (unsigned int i = 0; i < entry.count; i++) {\n if (entry.data.i32[i] == value)\n return true;\n }\n\n return false;\n }\n ...\n\nAnd keep the main function in-line as\n template\n bool entryContains(uint32_t tag, T value) const\n {\n camera_metadata_ro_entry_t entry;\n if (!getEntry(tag, &entry))\n return false;\n\n return entryContainsOne(entry, value);\n }\n\nDisclaimer: not compiled\nIs it worth it in your opinion ?\n\n\n> +\tfor (unsigned int i = 0; i < entry.count; i++)\n> +\t\tif (entry.data.u8[i] == value)\n> +\t\t\treturn true;\n\nbraces please if the block is two levels nested\n\n> +\n> +\treturn false;\n> +}\n> +\n> +\n\nDouble empy line\n\n> +bool CameraMetadata::hasEntry(uint32_t tag) const\n> +{\n> +\tcamera_metadata_ro_entry_t entry;\n> +\treturn getEntry(tag, &entry);\n> +}\n> +\n> bool CameraMetadata::addEntry(uint32_t tag, const void *data, size_t count,\n> \t\t\t size_t elementSize)\n> {\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 3b7c9e24..03b3e701 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -29,6 +29,10 @@ public:\n> \tbool isValid() const { return valid_; }\n> \tbool getEntry(uint32_t tag, camera_metadata_ro_entry_t *entry) const;\n>\n> +\ttemplate bool entryContains(uint32_t tag, T value) const;\n> +\n> +\tbool hasEntry(uint32_t tag) const;\n> +\n> \ttemplate \t\t std::enable_if_t> * = nullptr>\n> \tbool addEntry(uint32_t tag, const T &data)\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F756C3228\n\tfor ;\n\tSat, 17 Jul 2021 09:48:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2923368539;\n\tSat, 17 Jul 2021 11:48:55 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F15026027F\n\tfor ;\n\tSat, 17 Jul 2021 11:48:52 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 65E5DC0003;\n\tSat, 17 Jul 2021 09:48:51 +0000 (UTC)"],"Date":"Sat, 17 Jul 2021 11:49:39 +0200","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210717094939.4r3ifoc7xlvlakq4@uno.localdomain>","References":"<20210716105631.158153-1-paul.elder@ideasonboard.com>\n\t<20210716105631.158153-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210716105631.158153-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH v4 02/21] android: metadata: Add\n\thasEntry and entryContains","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]