[{"id":18203,"web_url":"https://patchwork.libcamera.org/comment/18203/","msgid":"","date":"2021-07-16T07:52:12","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix minor error\n\tin documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 16/07/2021 08:31, Jacopo Mondi wrote:\n> Fix a small spelling mistake in the ControlInfoMap documentation.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/controls.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 34317fa0f65d..78109f4130a8 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -592,7 +592,7 @@ std::string ControlInfo::toString() const\n> *\n> * The ControlInfoMap class describes controls supported by an object as an\n> * unsorted map of ControlId pointers to ControlInfo instances. Unlike the\n> - * standard std::unsorted_map<> class, it is designed the be immutable once\n> + * standard std::unsorted_map<> class, it is designed to be immutable once\n> * constructed, and thus only exposes the read accessors of the\n> * std::unsorted_map<> base class.\n> *\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1CD0C3226\n\tfor ;\n\tFri, 16 Jul 2021 07:52:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1704A68539;\n\tFri, 16 Jul 2021 09:52:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC8BE60280\n\tfor ;\n\tFri, 16 Jul 2021 09:52:15 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D7F43F0;\n\tFri, 16 Jul 2021 09:52:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I1IQLOjm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626421935;\n\tbh=fonLrsfhyBeZPPdW51futyRGxhOUSI5bFS72eymm/34=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=I1IQLOjmkbw1VKoC6rOciko4E5GTXEaD4xtdDJT7uPkECP2OGwG+X6DdFM74h2k0P\n\tVhXif9v4Sp9z9LbqyMBqsUdjNoi0cSL5Om/rRRmiAu8Z8MCDNqSmLlmY76Ycpy9yId\n\tIDG0qfIUp1LtsnwxJ2gUbjF1bwU3u4U1uQwI1OHY=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210716073126.1949-1-jacopo@jmondi.org>","From":"Kieran Bingham ","Message-ID":"","Date":"Fri, 16 Jul 2021 08:52:12 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210716073126.1949-1-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix minor error\n\tin documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18205,"web_url":"https://patchwork.libcamera.org/comment/18205/","msgid":"<20210716090727.GF2395@pyrite.rasen.tech>","date":"2021-07-16T09:07:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix minor error\n\tin documentation","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Jul 16, 2021 at 09:31:26AM +0200, Jacopo Mondi wrote:\n> Fix a small spelling mistake in the ControlInfoMap documentation.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/controls.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 34317fa0f65d..78109f4130a8 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -592,7 +592,7 @@ std::string ControlInfo::toString() const\n> *\n> * The ControlInfoMap class describes controls supported by an object as an\n> * unsorted map of ControlId pointers to ControlInfo instances. Unlike the\n> - * standard std::unsorted_map<> class, it is designed the be immutable once\n> + * standard std::unsorted_map<> class, it is designed to be immutable once\n> * constructed, and thus only exposes the read accessors of the\n> * std::unsorted_map<> base class.\n> *\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D26FC3226\n\tfor ;\n\tFri, 16 Jul 2021 09:07:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 885FC68539;\n\tFri, 16 Jul 2021 11:07:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACAB860280\n\tfor ;\n\tFri, 16 Jul 2021 11:07:35 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E8EF3F0;\n\tFri, 16 Jul 2021 11:07:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FGuqOjUP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626426455;\n\tbh=08MmKFfZFetFgnHRMKUTbOd7i2RlDTUXWFs6QBb7ZzQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FGuqOjUPIu6pZ+wd+xOSwmKDWmhWxRfst1wsTzzuSC2WAcSqj1JxP4jo6h3TqhodX\n\tpFoGQDM/gTp/Qij400jBnDwJmf0ZWGU3mGduZDytVje0vnKXhzrkKgcf6QRBJhaMnK\n\tUnZ/6SNfUxhoZPU/7atP6kWn4obBy4/4YXKMPn3Y=","Date":"Fri, 16 Jul 2021 18:07:27 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210716090727.GF2395@pyrite.rasen.tech>","References":"<20210716073126.1949-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210716073126.1949-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix minor error\n\tin documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18217,"web_url":"https://patchwork.libcamera.org/comment/18217/","msgid":"<2f509556-6174-4aef-f882-f753effc9797@ideasonboard.com>","date":"2021-07-18T14:39:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix minor error\n\tin documentation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThanks for the patch.\n\nOn 7/16/21 1:01 PM, Jacopo Mondi wrote:\n> Fix a small spelling mistake in the ControlInfoMap documentation.\n>\n> Signed-off-by: Jacopo Mondi \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/controls.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 34317fa0f65d..78109f4130a8 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -592,7 +592,7 @@ std::string ControlInfo::toString() const\n> *\n> * The ControlInfoMap class describes controls supported by an object as an\n> * unsorted map of ControlId pointers to ControlInfo instances. Unlike the\n> - * standard std::unsorted_map<> class, it is designed the be immutable once\n> + * standard std::unsorted_map<> class, it is designed to be immutable once\n> * constructed, and thus only exposes the read accessors of the\n> * std::unsorted_map<> base class.\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0103C0109\n\tfor ;\n\tSun, 18 Jul 2021 14:39:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14CEA6853A;\n\tSun, 18 Jul 2021 16:39:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CD9860280\n\tfor ;\n\tSun, 18 Jul 2021 16:39:50 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A68F4FB;\n\tSun, 18 Jul 2021 16:39:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FdXJv0kj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626619189;\n\tbh=vAMKkQecI7SChWl7dQ9EtODpHaDZ0Ow2WTwUzTpylTk=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=FdXJv0kjZKOSlSRe2SLLdP0GluA9KuZrhb8Q+f3UbEQ1IUXzKQ75qXHslk3OtMCi6\n\t+l9Pwsmgu+WLUY44DOPHVlt32/Ze0hBqy009J/qxIO3OVPZtWZlVurv6MhsCVMBPvx\n\tCMED2aJHwmedmzLNa7u9XQANCBy2yjzsY1+GcNys=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210716073126.1949-1-jacopo@jmondi.org>","From":"Umang Jain ","Message-ID":"<2f509556-6174-4aef-f882-f753effc9797@ideasonboard.com>","Date":"Sun, 18 Jul 2021 20:09:44 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210716073126.1949-1-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix minor error\n\tin documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]