[{"id":178,"web_url":"https://patchwork.libcamera.org/comment/178/","msgid":"<3432758.ZeDEHOlCzD@avalon>","date":"2019-01-02T11:11:31","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: media_device: Tiny\n\tvalid() documentation improvement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wednesday, 2 January 2019 13:00:15 EET Jacopo Mondi wrote:\n> Mention in the valid() method documentation, that a media graph has to\n> be populated to be valid.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nPlease push.\n\n> ---\n>  src/libcamera/media_device.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 1bd4f43..9fbc5a7 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -216,7 +216,7 @@ int MediaDevice::populate()\n> \n>  /**\n>   * \\fn MediaDevice::valid()\n> - * \\brief Query whether the media graph is valid\n> + * \\brief Query whether the media graph has been populated and is valid\n>   * \\return true if the media graph is valid, false otherwise\n>   */","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 954A060B0C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  2 Jan 2019 12:10:31 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21771505;\n\tWed,  2 Jan 2019 12:10:31 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546427431;\n\tbh=ZJIk5yAb/CCLbZHhAUEx2exrQKsZiZmHRjtWr3mf9RE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KUMiU4aPWrpo2xvFQFoW7nyDt9nNPn9Y17nGSouPl9T7EvJXdKQ3pKj66grRIZFq7\n\tiV+6ZgV4KElqtdBYvYe1M+RjMvzT6V+cGwUpyrcCs8ggCQRUt45cavFMUdOspytNxZ\n\tSXVXaUgnvNjFEWN+ZqFBzQQoaYvWKsD74CmJdn6Q=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 02 Jan 2019 13:11:31 +0200","Message-ID":"<3432758.ZeDEHOlCzD@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190102110016.5489-1-jacopo@jmondi.org>","References":"<20190102110016.5489-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: media_device: Tiny\n\tvalid() documentation improvement","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 02 Jan 2019 11:10:31 -0000"}}]