[{"id":18261,"web_url":"https://patchwork.libcamera.org/comment/18261/","msgid":"<20210722125623.ez2pnlzurxeil7oo@uno.localdomain>","date":"2021-07-22T12:56:23","subject":"Re: [libcamera-devel] [PATCH v3 14/33] cam: options: Fail parsing\n\twhen non-option arguments are found","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Jul 16, 2021 at 12:14:40AM +0300, Laurent Pinchart wrote:\n> The options parser currently ignores non-option arguments silently,\n> which is confusing. It's a common error to run 'cam -c1 -C 10' and\n> expect only 10 frames to be captured. As the -C option takes an optional\n> argument, the number 10 is interpreted as a non-option argument instead\n> of the argument to the -C option.\n\nI've been fooled by that a few times :)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Fail parsing with an appropriate message and print usage information\n> when a non-option argument is found. The parser may be extended later to\n> accept non-option arguments when the application has a use for them.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/options.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 6e0d802cb986..33bc512e6571 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -945,6 +945,13 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)\n> \t\t}\n> \t}\n>\n> +\tif (optind < argc) {\n> +\t\tstd::cerr << \"Invalid non-option argument '\" << argv[optind]\n> +\t\t\t << \"'\" << std::endl;\n> +\t\tusage();\n> +\t\treturn options;\n> +\t}\n> +\n> \toptions.valid_ = true;\n> \treturn options;\n> }\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37A07C0109\n\tfor ;\n\tThu, 22 Jul 2021 12:55:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF1DA68543;\n\tThu, 22 Jul 2021 14:55:36 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37DB86027A\n\tfor ;\n\tThu, 22 Jul 2021 14:55:36 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C2FFB60003;\n\tThu, 22 Jul 2021 12:55:35 +0000 (UTC)"],"Date":"Thu, 22 Jul 2021 14:56:23 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210722125623.ez2pnlzurxeil7oo@uno.localdomain>","References":"<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>\n\t<20210715211459.19373-15-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210715211459.19373-15-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 14/33] cam: options: Fail parsing\n\twhen non-option arguments are found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]