[{"id":18258,"web_url":"https://patchwork.libcamera.org/comment/18258/","msgid":"<20210722125126.j4yqwxqbnlvhakal@uno.localdomain>","date":"2021-07-22T12:51:26","subject":"Re: [libcamera-devel] [PATCH v3 11/33] cam: options: Add empty()\n\tfunction to OptionValue class","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Jul 16, 2021 at 12:14:37AM +0300, Laurent Pinchart wrote:\n> Add a convenience helper to check if an option value is empty, based on\n> the value type. This is useful as a shortcut syntax to check if an\n> option has been set.\n\nLooks good!\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/options.cpp | 7 +++++++\n> src/cam/options.h | 1 +\n> 2 files changed, 8 insertions(+)\n>\n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index fda6d9764ac5..481ac189f115 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -583,6 +583,13 @@ void OptionValue::addValue(const OptionValue &value)\n> * \\return The value type\n> */\n>\n> +/**\n> + * \\fn OptionValue::empty()\n> + * \\brief Check if the value is empty\n> + * \\return True if the value is empty (type set to ValueType::ValueNone), or\n> + * false otherwise\n> + */\n> +\n> /**\n> * \\brief Cast the value to an int\n> * \\return The option value as an int, or 0 if the value type isn't\n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 210e502a24e1..83c409ae4d28 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -135,6 +135,7 @@ public:\n> \tvoid addValue(const OptionValue &value);\n>\n> \tValueType type() const { return type_; }\n> +\tbool empty() const { return type_ == ValueType::ValueNone; }\n>\n> \toperator int() const;\n> \toperator std::string() const;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88E18C322B\n\tfor ;\n\tThu, 22 Jul 2021 12:50:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D0FE6027F;\n\tThu, 22 Jul 2021 14:50:41 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6ADB36027A\n\tfor ;\n\tThu, 22 Jul 2021 14:50:39 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id DDD3DC0014;\n\tThu, 22 Jul 2021 12:50:38 +0000 (UTC)"],"Date":"Thu, 22 Jul 2021 14:51:26 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210722125126.j4yqwxqbnlvhakal@uno.localdomain>","References":"<20210715211459.19373-1-laurent.pinchart@ideasonboard.com>\n\t<20210715211459.19373-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210715211459.19373-12-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 11/33] cam: options: Add empty()\n\tfunction to OptionValue class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]