[{"id":1708,"web_url":"https://patchwork.libcamera.org/comment/1708/","msgid":"<20190527093634.vld2zix6c5hjmmpw@uno.localdomain>","date":"2019-05-27T09:36:34","subject":"Re: [libcamera-devel] [PATCH 04/17] libcamera: geometry: SizeRange:\n\tAdd toString()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Mon, May 27, 2019 at 02:15:30AM +0200, Niklas Söderlund wrote:\n> It's useful to be able to print a string representation of a SizeRange\n> to the log or console, add a toString() method. While at it turn the\n> structure into a class as it contains functions as well as data.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/geometry.h | 6 +++++-\n> src/libcamera/geometry.cpp | 22 ++++++++++++++++++++++\n> 2 files changed, 27 insertions(+), 1 deletion(-)\n>\n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 1c9267b14274cb5d..ca920a1e16817860 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -67,7 +67,9 @@ static inline bool operator>=(const Size &lhs, const Size &rhs)\n> \treturn !(lhs < rhs);\n> }\n>\n> -struct SizeRange {\n> +class SizeRange\n> +{\n> +public:\n> \tSizeRange()\n> \t{\n> \t}\n> @@ -90,6 +92,8 @@ struct SizeRange {\n> \t{\n> \t}\n>\n> +\tconst std::string toString() const;\n> +\n\ndo we want the below fields private, now that SizeRange is a class?\n\nOtherwise:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \tSize min;\n> \tSize max;\n> \tunsigned int hStep;\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index e7f1bafd40e944f5..337f2efa828ba996 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -259,6 +259,28 @@ bool operator<(const Size &lhs, const Size &rhs)\n> * \\brief The vertical step\n> */\n>\n> +/**\n> + * \\brief Assemble and return a string describing the size range\n> + * \\return A string describing the SizeRange\n> + */\n> +const std::string SizeRange::toString() const\n> +{\n> +\tstd::stringstream ss;\n> +\n> +\tif (min == max)\n> +\t\tss << \"Width: \" << min.width\n> +\t\t << \" Height: \" << min.height\n> +\t\t << \" hStep: \" << hStep\n> +\t\t << \" vStep: \" << vStep;\n> +\telse\n> +\t\tss << \"Width: \" << min.width << \"-\" << max.width\n> +\t\t << \" Height: \" << min.height << \"-\" << max.height\n> +\t\t << \" hStep: \" << hStep\n> +\t\t << \" vStep: \" << vStep;\n> +\n> +\treturn ss.str();\n> +}\n> +\n> /**\n> * \\brief Compare size ranges for equality\n> * \\return True if the two size ranges are equal, false otherwise\n> --\n> 2.21.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 701B4600EA\n\tfor ;\n\tMon, 27 May 2019 11:35:27 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D625D4001A;\n\tMon, 27 May 2019 09:35:26 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 27 May 2019 11:36:34 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190527093634.vld2zix6c5hjmmpw@uno.localdomain>","References":"<20190527001543.13593-1-niklas.soderlund@ragnatech.se>\n\t<20190527001543.13593-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ekqa2d3vlrpoh4w7\"","Content-Disposition":"inline","In-Reply-To":"<20190527001543.13593-5-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 04/17] libcamera: geometry: SizeRange:\n\tAdd toString()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 May 2019 09:35:27 -0000"}},{"id":1730,"web_url":"https://patchwork.libcamera.org/comment/1730/","msgid":"<8b93f260-0573-f61c-738e-17e58d44edec@ideasonboard.com>","date":"2019-05-29T23:00:13","subject":"Re: [libcamera-devel] [PATCH 04/17] libcamera: geometry: SizeRange:\n\tAdd toString()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 27/05/2019 01:15, Niklas Söderlund wrote:\n> It's useful to be able to print a string representation of a SizeRange\n> to the log or console, add a toString() method. While at it turn the\n> structure into a class as it contains functions as well as data.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/geometry.h | 6 +++++-\n> src/libcamera/geometry.cpp | 22 ++++++++++++++++++++++\n> 2 files changed, 27 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 1c9267b14274cb5d..ca920a1e16817860 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -67,7 +67,9 @@ static inline bool operator>=(const Size &lhs, const Size &rhs)\n> \treturn !(lhs < rhs);\n> }\n> \n> -struct SizeRange {\n> +class SizeRange\n> +{\n> +public:\n> \tSizeRange()\n> \t{\n> \t}\n> @@ -90,6 +92,8 @@ struct SizeRange {\n> \t{\n> \t}\n> \n> +\tconst std::string toString() const;\n> +\n> \tSize min;\n> \tSize max;\n> \tunsigned int hStep;\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index e7f1bafd40e944f5..337f2efa828ba996 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -259,6 +259,28 @@ bool operator<(const Size &lhs, const Size &rhs)\n> * \\brief The vertical step\n> */\n> \n> +/**\n> + * \\brief Assemble and return a string describing the size range\n> + * \\return A string describing the SizeRange\n> + */\n> +const std::string SizeRange::toString() const\n> +{\n> +\tstd::stringstream ss;\n\nSeeing the output of this in the cam --info option:\n\n * Pixelformat: 0x47504a4d Width: 176-1920 Height: 144-1080 hStep: 1\nvStep: 1\n\nSeems a bit convoluted to read.\n\n\n> +\n> +\tif (min == max)\n> +\t\tss << \"Width: \" << min.width\n> +\t\t << \" Height: \" << min.height\n\nCan't we just do the following ?:\n\t\tss << min.toString\n\n\n> +\t\t << \" hStep: \" << hStep\n> +\t\t << \" vStep: \" << vStep;> +\telse\n> +\t\tss << \"Width: \" << min.width << \"-\" << max.width\n> +\t\t << \" Height: \" << min.height << \"-\" << max.height\n> +\t\t << \" hStep: \" << hStep\n> +\t\t << \" vStep: \" << vStep;\n\n\n\nHow about:\n\nconst std::string SizeRange::toString() const\n{\n\tstd::stringstream ss;\n\n\tss << min.toString;\n\n\tif (min != max)\n\t\tss << \" -> \" << max.toString();\n\n\tss << \" hStep: \" << hStep << \" vStep: \" << vStep;\n\n\treturn ss.str();\n}\n\n> +\n> +\treturn ss.str();\n> +}\n> +\n> /**\n> * \\brief Compare size ranges for equality\n> * \\return True if the two size ranges are equal, false otherwise\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1E0160E46\n\tfor ;\n\tThu, 30 May 2019 01:00:16 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0228F524;\n\tThu, 30 May 2019 01:00:15 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559170816;\n\tbh=Mv4xv/RtltAYColOqZhdDxiyWlA7+SUtGarP0qn+Z90=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=gBJmvUgMSwdxXv09HgoFSWBDVJSTmYcYLgFYWk4Wq01/A1yEVJzfcXQAhauEK/fGt\n\trzWl4Ns/0NQMXyFMUf3HtiUgNiaGIPNGjJWU/zDUy+wbGESix98qmkQS66xPFUMAX3\n\tfC2XvnMoaW6cWxQ1Rp9+7wpgpmvxLnJpTDzGUCuU=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190527001543.13593-1-niklas.soderlund@ragnatech.se>\n\t<20190527001543.13593-5-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<8b93f260-0573-f61c-738e-17e58d44edec@ideasonboard.com>","Date":"Thu, 30 May 2019 00:00:13 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190527001543.13593-5-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 04/17] libcamera: geometry: SizeRange:\n\tAdd toString()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 29 May 2019 23:00:16 -0000"}},{"id":1795,"web_url":"https://patchwork.libcamera.org/comment/1795/","msgid":"<20190608163537.GB25825@pendragon.ideasonboard.com>","date":"2019-06-08T16:35:37","subject":"Re: [libcamera-devel] [PATCH 04/17] libcamera: geometry: SizeRange:\n\tAdd toString()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n \nOn Thu, May 30, 2019 at 12:00:13AM +0100, Kieran Bingham wrote:\n> On 27/05/2019 01:15, Niklas Söderlund wrote:\n> > It's useful to be able to print a string representation of a SizeRange\n> > to the log or console, add a toString() method. While at it turn the\n> > structure into a class as it contains functions as well as data.\n\nNote that a class can also contain methods. The only difference is that\nmembers of a struct are public by default, while members of a class are\nprivate. This being said, I'm not opposed to the change.\n\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > include/libcamera/geometry.h | 6 +++++-\n> > src/libcamera/geometry.cpp | 22 ++++++++++++++++++++++\n> > 2 files changed, 27 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> > index 1c9267b14274cb5d..ca920a1e16817860 100644\n> > --- a/include/libcamera/geometry.h\n> > +++ b/include/libcamera/geometry.h\n> > @@ -67,7 +67,9 @@ static inline bool operator>=(const Size &lhs, const Size &rhs)\n> > \treturn !(lhs < rhs);\n> > }\n> > \n> > -struct SizeRange {\n> > +class SizeRange\n> > +{\n> > +public:\n> > \tSizeRange()\n> > \t{\n> > \t}\n> > @@ -90,6 +92,8 @@ struct SizeRange {\n> > \t{\n> > \t}\n> > \n> > +\tconst std::string toString() const;\n\nNo need for the first const, you're returning a value.\n\n> > +\n> > \tSize min;\n> > \tSize max;\n> > \tunsigned int hStep;\n> > diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> > index e7f1bafd40e944f5..337f2efa828ba996 100644\n> > --- a/src/libcamera/geometry.cpp\n> > +++ b/src/libcamera/geometry.cpp\n> > @@ -259,6 +259,28 @@ bool operator<(const Size &lhs, const Size &rhs)\n> > * \\brief The vertical step\n> > */\n> > \n> > +/**\n> > + * \\brief Assemble and return a string describing the size range\n> > + * \\return A string describing the SizeRange\n> > + */\n> > +const std::string SizeRange::toString() const\n> > +{\n> > +\tstd::stringstream ss;\n> \n> Seeing the output of this in the cam --info option:\n> \n> * Pixelformat: 0x47504a4d Width: 176-1920 Height: 144-1080 hStep: 1\n> vStep: 1\n> \n> Seems a bit convoluted to read.\n\nI agree.\n\n> > +\n> > +\tif (min == max)\n> > +\t\tss << \"Width: \" << min.width\n> > +\t\t << \" Height: \" << min.height\n> \n> Can't we just do the following ?:\n> \t\tss << min.toString\n> \n> \n> > +\t\t << \" hStep: \" << hStep\n> > +\t\t << \" vStep: \" << vStep;> +\telse\n> > +\t\tss << \"Width: \" << min.width << \"-\" << max.width\n> > +\t\t << \" Height: \" << min.height << \"-\" << max.height\n> > +\t\t << \" hStep: \" << hStep\n> > +\t\t << \" vStep: \" << vStep;\n> \n> \n> \n> How about:\n> \n> const std::string SizeRange::toString() const\n> {\n> \tstd::stringstream ss;\n> \n> \tss << min.toString;\n> \n> \tif (min != max)\n> \t\tss << \" -> \" << max.toString();\n> \n> \tss << \" hStep: \" << hStep << \" vStep: \" << vStep;\n> \n> \treturn ss.str();\n> }\n\nThat's better but still a bit long. How about\n\n\tss << \"(\" << min.toString() << \")-(\" << max.toString() << \")/(+\"\n\t << hStep << \",+\" << vStep << \")\";\n\nwhich should print\n\n\t(640x480)-(1024x768)/(+4,+4)\n\nFeel free to propose a different representation, but I think we should\nkeep it compact and avoid spaces.\n\n> > +\n> > +\treturn ss.str();\n> > +}\n> > +\n> > /**\n> > * \\brief Compare size ranges for equality\n> > * \\return True if the two size ranges are equal, false otherwise","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B62716BEDC\n\tfor ;\n\tSat, 8 Jun 2019 18:35:55 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:a03f:44f0:8500:ca05:8177:199c:fed4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B9215D;\n\tSat, 8 Jun 2019 18:35:55 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560011755;\n\tbh=9rVTpW7kEOmArNVMFtP1dPvlVG95TbMYuiUY9nc2LpQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Xt2u/FbL7j3wri/EiJODmxqoRqaaCu80H5T4McoApM2ZB2dMPyY6ZoEr07v9ARIWr\n\tQGRfSeXHXUj50g1AT7PznJapSrUZsJTfYpzKiKvwpkbLqhxjNuCUNoPdsaMwo2N/hH\n\tPA4gNA6gwpykzgJRzjBCr+iV4KlDihFy2otcgIFM=","Date":"Sat, 8 Jun 2019 19:35:37 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190608163537.GB25825@pendragon.ideasonboard.com>","References":"<20190527001543.13593-1-niklas.soderlund@ragnatech.se>\n\t<20190527001543.13593-5-niklas.soderlund@ragnatech.se>\n\t<8b93f260-0573-f61c-738e-17e58d44edec@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<8b93f260-0573-f61c-738e-17e58d44edec@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 04/17] libcamera: geometry: SizeRange:\n\tAdd toString()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 08 Jun 2019 16:35:55 -0000"}}]