[{"id":18200,"web_url":"https://patchwork.libcamera.org/comment/18200/","msgid":"","date":"2021-07-15T20:29:04","subject":"Re: [libcamera-devel] [PATCH v2 1/2] Fixes: 4fd6bb33 (\"libcamera:\n\tAdd support for XRGB8888 and XBGR8888\")","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Vedant,\n\nThank you for the patch.\n\nThe Fixes: line still doesn't go in the subject. Paul explained this in\nthe review of v1.\n\nOn Thu, Jul 15, 2021 at 11:45:21PM +0530, Vedant Paranjape wrote:\n> This patch fixes V4L2 pixel format for formats::XBGR8888 by updating\n> the existing matching to V4L2_PIX_FMT_RGBX32\n> \n> Signed-off-by: Vedant Paranjape \n> Reviewed-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/formats.cpp | 2 +-\n> src/libcamera/v4l2_pixelformat.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 59a34853..578ac4af 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -198,7 +198,7 @@ const std::map pixelFormatInfo{\n> \t{ formats::XBGR8888, {\n> \t\t.name = \"XBGR8888\",\n> \t\t.format = formats::XBGR8888,\n> -\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_XRGB32),\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n> \t\t.bitsPerPixel = 32,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t\t.packed = false,\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 87d728fe..59a01e02 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -52,7 +52,7 @@ const std::map vpf2pf{\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> -\t{ V4L2PixelFormat(V4L2_PIX_FMT_XRGB32), formats::XBGR8888 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), formats::XBGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32), formats::ARGB8888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ARGB32), formats::BGRA8888 },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1CC0C3226\n\tfor ;\n\tThu, 15 Jul 2021 20:29:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3626368539;\n\tThu, 15 Jul 2021 22:29:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 181096059F\n\tfor ;\n\tThu, 15 Jul 2021 22:29:07 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36CBB340;\n\tThu, 15 Jul 2021 22:29:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h5oYcj87\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626380946;\n\tbh=EF+FAKLE6/1u+sLEDyn8D8bGWbcIbDg5xPWvS6tuoOU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=h5oYcj87xO20ef9iesUeYMKo+CoIT0vKCq6Po0nQizxNr4Bo/L+8G6NpPgt2PaHPE\n\tzGvvEdVrXftusS9MMn8toBLPUm2Po4OI3sYmmpU/7ZKniPybXfebNiPaVBRntJA80e\n\tl1ZR3mkyQ+cch2URbg+6UUnLTACPaxrBsytTe72U=","Date":"Thu, 15 Jul 2021 23:29:04 +0300","From":"Laurent Pinchart ","To":"Vedant Paranjape ","Message-ID":"","References":"<20210715181522.273606-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210715181522.273606-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] Fixes: 4fd6bb33 (\"libcamera:\n\tAdd support for XRGB8888 and XBGR8888\")","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]