[{"id":18287,"web_url":"https://patchwork.libcamera.org/comment/18287/","msgid":"<608394bf-17c9-50c0-13b1-bc8f9151a87b@ideasonboard.com>","date":"2021-07-23T13:32:58","subject":"Re: [libcamera-devel] [PATCH 2/3] android: capabilties: Rationalize\n\tget[YUV|Raw]Resolution names","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"HI Jacopo\n\nThanks for the patch.\n\nOn 7/15/21 9:02 PM, Jacopo Mondi wrote:\n> The getYUVResolutions() and getRawResolutions() functions are called\n> from the initializeStreamConfigurations() function, which is called by\n> initialize().\n>\n> Rationalize the function naming scheme by renaming the two functions to\n> initializeYUVResolutions() and initializeRawResolution().\n>\n> Cosmetic change only.\n>\n> Signed-off-by: Jacopo Mondi \nReviewed-by: Umang Jain \n> ---\n> src/android/camera_capabilities.cpp | 14 ++++++++------\n> src/android/camera_capabilities.h | 6 +++---\n> 2 files changed, 11 insertions(+), 9 deletions(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 6543c2bbc6c3..15e54192adff 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -138,8 +138,9 @@ int CameraCapabilities::initialize(std::shared_ptr camera,\n> \treturn initializeStaticMetadata();\n> }\n> \n> -std::vector CameraCapabilities::getYUVResolutions(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t\tconst std::vector &resolutions)\n> +std::vector\n> +CameraCapabilities::initializeYUVResolutions(const PixelFormat &pixelFormat,\n> +\t\t\t\t\t const std::vector &resolutions)\n> {\n> \tstd::vector supportedResolutions;\n> \tstd::unique_ptr cameraConfig =\n> @@ -164,7 +165,8 @@ std::vector CameraCapabilities::getYUVResolutions(const PixelFormat &pixel\n> \treturn supportedResolutions;\n> }\n> \n> -std::vector CameraCapabilities::getRawResolutions(const libcamera::PixelFormat &pixelFormat)\n> +std::vector\n> +CameraCapabilities::initializeRawResolutions(const libcamera::PixelFormat &pixelFormat)\n> {\n> \tstd::unique_ptr cameraConfig =\n> \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n> @@ -323,10 +325,10 @@ int CameraCapabilities::initializeStreamConfigurations()\n> \t\tstd::vector resolutions;\n> \t\tconst PixelFormatInfo &info = PixelFormatInfo::info(mappedFormat);\n> \t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> -\t\t\tresolutions = getRawResolutions(mappedFormat);\n> +\t\t\tresolutions = initializeRawResolutions(mappedFormat);\n> \t\telse\n> -\t\t\tresolutions = getYUVResolutions(mappedFormat,\n> -\t\t\t\t\t\t\tcameraResolutions);\n> +\t\t\tresolutions = initializeYUVResolutions(mappedFormat,\n> +\t\t\t\t\t\t\t cameraResolutions);\n> \n> \t\tfor (const Size &res : resolutions) {\n> \t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n> diff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\n> index e72bf084cd65..e7aa46c0a689 100644\n> --- a/src/android/camera_capabilities.h\n> +++ b/src/android/camera_capabilities.h\n> @@ -43,10 +43,10 @@ private:\n> \t};\n> \n> \tstd::vector\n> -\tgetYUVResolutions(const libcamera::PixelFormat &pixelFormat,\n> -\t\t\t const std::vector &resolutions);\n> +\tinitializeYUVResolutions(const libcamera::PixelFormat &pixelFormat,\n> +\t\t\t\t const std::vector &resolutions);\n> \tstd::vector\n> -\tgetRawResolutions(const libcamera::PixelFormat &pixelFormat);\n> +\tinitializeRawResolutions(const libcamera::PixelFormat &pixelFormat);\n> \tint initializeStreamConfigurations();\n> \n> \tint initializeStaticMetadata();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBDBBC0109\n\tfor ;\n\tFri, 23 Jul 2021 13:33:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49CA4687A9;\n\tFri, 23 Jul 2021 15:33:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7196168537\n\tfor ;\n\tFri, 23 Jul 2021 15:33:03 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.103])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BB073F2;\n\tFri, 23 Jul 2021 15:33:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MjHzsfYF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627047183;\n\tbh=5+Q12312DI56cemlDW1EhD2PXu6ENsX2Z5NwdsozkDA=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=MjHzsfYFCv2lhNb2DVUzIrA/QFkdnN6JBZ29EDhud9uitDwELVbAYKksrD7g+q0O2\n\tyqKBwzyOq/VMa51PKvdeK3BG9OKSL1cDQm49+1DfsNMRx8g12ip8IMlswlL5yUHjuq\n\tVvJPz0lhqBZXr5VSIbTMWRQe/hbyFSo6VCXYTfl8=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210715153241.63971-1-jacopo@jmondi.org>\n\t<20210715153241.63971-3-jacopo@jmondi.org>","From":"Umang Jain ","Message-ID":"<608394bf-17c9-50c0-13b1-bc8f9151a87b@ideasonboard.com>","Date":"Fri, 23 Jul 2021 19:02:58 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210715153241.63971-3-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/3] android: capabilties: Rationalize\n\tget[YUV|Raw]Resolution names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18290,"web_url":"https://patchwork.libcamera.org/comment/18290/","msgid":"","date":"2021-07-23T13:37:53","subject":"Re: [libcamera-devel] [PATCH 2/3] android: capabilties: Rationalize\n\tget[YUV|Raw]Resolution names","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jul 15, 2021 at 05:32:40PM +0200, Jacopo Mondi wrote:\n> The getYUVResolutions() and getRawResolutions() functions are called\n> from the initializeStreamConfigurations() function, which is called by\n> initialize().\n> \n> Rationalize the function naming scheme by renaming the two functions to\n> initializeYUVResolutions() and initializeRawResolution().\n\nThere's a difference between initializeStreamConfigurations() and the\nget*Resolutions() functions, in the sense that the former performs\ninitialization of CameraCapabilities, and the latter retrieve and return\nsupported resolutions without modifying CameraCapabilities.\n\nI don't have a strong opinion, so if you think these names are better,\n\nReviewed-by: Laurent Pinchart \n\n> Cosmetic change only.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_capabilities.cpp | 14 ++++++++------\n> src/android/camera_capabilities.h | 6 +++---\n> 2 files changed, 11 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 6543c2bbc6c3..15e54192adff 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -138,8 +138,9 @@ int CameraCapabilities::initialize(std::shared_ptr camera,\n> \treturn initializeStaticMetadata();\n> }\n> \n> -std::vector CameraCapabilities::getYUVResolutions(const PixelFormat &pixelFormat,\n> -\t\t\t\t\t\t\tconst std::vector &resolutions)\n> +std::vector\n> +CameraCapabilities::initializeYUVResolutions(const PixelFormat &pixelFormat,\n> +\t\t\t\t\t const std::vector &resolutions)\n> {\n> \tstd::vector supportedResolutions;\n> \tstd::unique_ptr cameraConfig =\n> @@ -164,7 +165,8 @@ std::vector CameraCapabilities::getYUVResolutions(const PixelFormat &pixel\n> \treturn supportedResolutions;\n> }\n> \n> -std::vector CameraCapabilities::getRawResolutions(const libcamera::PixelFormat &pixelFormat)\n> +std::vector\n> +CameraCapabilities::initializeRawResolutions(const libcamera::PixelFormat &pixelFormat)\n> {\n> \tstd::unique_ptr cameraConfig =\n> \t\tcamera_->generateConfiguration({ StreamRole::Raw });\n> @@ -323,10 +325,10 @@ int CameraCapabilities::initializeStreamConfigurations()\n> \t\tstd::vector resolutions;\n> \t\tconst PixelFormatInfo &info = PixelFormatInfo::info(mappedFormat);\n> \t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> -\t\t\tresolutions = getRawResolutions(mappedFormat);\n> +\t\t\tresolutions = initializeRawResolutions(mappedFormat);\n> \t\telse\n> -\t\t\tresolutions = getYUVResolutions(mappedFormat,\n> -\t\t\t\t\t\t\tcameraResolutions);\n> +\t\t\tresolutions = initializeYUVResolutions(mappedFormat,\n> +\t\t\t\t\t\t\t cameraResolutions);\n> \n> \t\tfor (const Size &res : resolutions) {\n> \t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n> diff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\n> index e72bf084cd65..e7aa46c0a689 100644\n> --- a/src/android/camera_capabilities.h\n> +++ b/src/android/camera_capabilities.h\n> @@ -43,10 +43,10 @@ private:\n> \t};\n> \n> \tstd::vector\n> -\tgetYUVResolutions(const libcamera::PixelFormat &pixelFormat,\n> -\t\t\t const std::vector &resolutions);\n> +\tinitializeYUVResolutions(const libcamera::PixelFormat &pixelFormat,\n> +\t\t\t\t const std::vector &resolutions);\n> \tstd::vector\n> -\tgetRawResolutions(const libcamera::PixelFormat &pixelFormat);\n> +\tinitializeRawResolutions(const libcamera::PixelFormat &pixelFormat);\n> \tint initializeStreamConfigurations();\n> \n> \tint initializeStaticMetadata();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B8A2C322C\n\tfor ;\n\tFri, 23 Jul 2021 13:37:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE0D8687A9;\n\tFri, 23 Jul 2021 15:37:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7695E68537\n\tfor ;\n\tFri, 23 Jul 2021 15:37:55 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 130913F2;\n\tFri, 23 Jul 2021 15:37:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lkWlquNT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1627047475;\n\tbh=GyaqMZXkp2iNaRkl0KaWkvyKuRyFDqo/2Bv3XFUW+GU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lkWlquNTYFXFE+B0+Hy+yxLbuqlHd5abINrGIPaOBY4sA8V7wSRNj6sxxtFGfSEGh\n\tAy+ikLz228h9/wX9n2IBgcahJxGwxdgSv4F7jzmJM8dUVGD48QQk2oAG04MnZHr3zA\n\tnXUcDJqU7KXrOnekaT3QfF5B5UBIU0JtJn7QSKMo=","Date":"Fri, 23 Jul 2021 16:37:53 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210715153241.63971-1-jacopo@jmondi.org>\n\t<20210715153241.63971-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210715153241.63971-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] android: capabilties: Rationalize\n\tget[YUV|Raw]Resolution names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]