[{"id":18185,"web_url":"https://patchwork.libcamera.org/comment/18185/","msgid":"","date":"2021-07-15T11:37:23","subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jul 15, 2021 at 12:28:45PM +0100, Kieran Bingham wrote:\n> In libcamera commit 6a31a8d8e274 (\"libcamera: buffer: Rename buffer.h to\n> framebuffer.h\"), the public header buffer.h was renamed.\n> \n> Update the usage accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera-helpers/mapped_buffer.h | 2 +-\n> ipu3.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera-helpers/mapped_buffer.h b/include/libcamera-helpers/mapped_buffer.h\n> index b34a70c5f2c5..6cfc57217d75 100644\n> --- a/include/libcamera-helpers/mapped_buffer.h\n> +++ b/include/libcamera-helpers/mapped_buffer.h\n> @@ -13,7 +13,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/ipu3.cpp b/ipu3.cpp\n> index e0e87a8d70ec..651e0bb5efc1 100644\n> --- a/ipu3.cpp\n> +++ b/ipu3.cpp\n> @@ -11,8 +11,8 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> +#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B922C3225\n\tfor ;\n\tThu, 15 Jul 2021 11:37:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7149268525;\n\tThu, 15 Jul 2021 13:37:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB7126059F\n\tfor ;\n\tThu, 15 Jul 2021 13:37:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 142E3340;\n\tThu, 15 Jul 2021 13:37:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UT1T5BWQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626349046;\n\tbh=ZFQzmjnLoZ+Q9tZMtamHnxHe2ynXNOhHPWmI/SyGnn4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UT1T5BWQqYNENd523uCEz5/x9EE3hlE2bXppaxmsiwzDRpw8C6cphPSywwbs1/RLx\n\t3FlaNkiNpkJuKcaQYB60ZKFNd1BtOS68sxmoKNuPWNWbbGrePTPpS7xrFIA5pGu0jA\n\t2HBMZ7Utl0+1P+BjvP87LZroo38iGjZBAQoD6ptk=","Date":"Thu, 15 Jul 2021 14:37:23 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210715112845.4049846-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210715112845.4049846-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18186,"web_url":"https://patchwork.libcamera.org/comment/18186/","msgid":"","date":"2021-07-15T11:41:08","subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 15/07/2021 12:37, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Jul 15, 2021 at 12:28:45PM +0100, Kieran Bingham wrote:\n>> In libcamera commit 6a31a8d8e274 (\"libcamera: buffer: Rename buffer.h to\n>> framebuffer.h\"), the public header buffer.h was renamed.\n>>\n>> Update the usage accordingly.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n\nThanks, I'll integrate this as an immediate fix.\n\nI've now added the IPA to my daily build system, so it will be rebuilt\nagainst any libcamera updates, and I'll catch this sooner next time.\n\n(Looks like it's taken me 4 days to notice this !)\n--\nKieran\n\n\n> \n>> ---\n>> include/libcamera-helpers/mapped_buffer.h | 2 +-\n>> ipu3.cpp | 2 +-\n>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/include/libcamera-helpers/mapped_buffer.h b/include/libcamera-helpers/mapped_buffer.h\n>> index b34a70c5f2c5..6cfc57217d75 100644\n>> --- a/include/libcamera-helpers/mapped_buffer.h\n>> +++ b/include/libcamera-helpers/mapped_buffer.h\n>> @@ -13,7 +13,7 @@\n>> #include \n>> #include \n>> \n>> -#include \n>> +#include \n>> \n>> namespace libcamera {\n>> \n>> diff --git a/ipu3.cpp b/ipu3.cpp\n>> index e0e87a8d70ec..651e0bb5efc1 100644\n>> --- a/ipu3.cpp\n>> +++ b/ipu3.cpp\n>> @@ -11,8 +11,8 @@\n>> #include \n>> #include \n>> \n>> -#include \n>> #include \n>> +#include \n>> #include \n>> #include \n>> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3EE2C3225\n\tfor ;\n\tThu, 15 Jul 2021 11:41:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 249CC68525;\n\tThu, 15 Jul 2021 13:41:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2B226059F\n\tfor ;\n\tThu, 15 Jul 2021 13:41:11 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5726D340;\n\tThu, 15 Jul 2021 13:41:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dUE+AKMG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626349271;\n\tbh=bZoY5PPlrcmWSbnfCkIjgS50n75X89yQT2WUo1219Kk=;\n\th=From:Subject:To:Cc:References:Date:In-Reply-To:From;\n\tb=dUE+AKMGsKOPWZVtmDIdSbn4mKAWTBJyX1GDupBkJzlHf8c7NDyqsDJ+voq7GOi3U\n\tp2ypIOx29AoYkkzuaoZJJEwphhl1/r+cILW1txKdVUFN7LOfLjyoX2wbMIfRhA7czJ\n\tELF/MG2QGgexkpkCfsq8irCoZTVJ6RLXUi76mNbk=","From":"Kieran Bingham ","To":"Laurent Pinchart ","References":"<20210715112845.4049846-1-kieran.bingham@ideasonboard.com>\n\t","Message-ID":"","Date":"Thu, 15 Jul 2021 12:41:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18204,"web_url":"https://patchwork.libcamera.org/comment/18204/","msgid":"","date":"2021-07-16T08:48:56","subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 15/07/2021 13:28, Kieran Bingham wrote:\n> In libcamera commit 6a31a8d8e274 (\"libcamera: buffer: Rename buffer.h to\n> framebuffer.h\"), the public header buffer.h was renamed.\n> \n> Update the usage accordingly.\n> \n> Signed-off-by: Kieran Bingham \nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> include/libcamera-helpers/mapped_buffer.h | 2 +-\n> ipu3.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera-helpers/mapped_buffer.h b/include/libcamera-helpers/mapped_buffer.h\n> index b34a70c5f2c5..6cfc57217d75 100644\n> --- a/include/libcamera-helpers/mapped_buffer.h\n> +++ b/include/libcamera-helpers/mapped_buffer.h\n> @@ -13,7 +13,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/ipu3.cpp b/ipu3.cpp\n> index e0e87a8d70ec..651e0bb5efc1 100644\n> --- a/ipu3.cpp\n> +++ b/ipu3.cpp\n> @@ -11,8 +11,8 @@\n> #include \n> #include \n> \n> -#include \n> #include \n> +#include \n> #include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50C64C3228\n\tfor ;\n\tFri, 16 Jul 2021 08:49:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A382068539;\n\tFri, 16 Jul 2021 10:49:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0CB060280\n\tfor ;\n\tFri, 16 Jul 2021 10:48:59 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:a9d0:5adc:fd03:cd8e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5944C3F0;\n\tFri, 16 Jul 2021 10:48:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BGaFV93X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626425339;\n\tbh=+1AryCRAWdnbTFEA2D3fb38x87TzKNbfDkyPaaW943Q=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=BGaFV93XnKHr9Qhp8uODQc7dcwohU6RpZwaPjYNFOO/Pbj8tUJo8Y2iOcRTVfWoci\n\tsd8OjR/hbLG90sDuK/2XrD9Wlqr63cbud2OXtxBDmWATd5bgiqmPh1XeGTOzmHXq8B\n\tlA7ZDhFlC1BB7kkIvbI1lx13WJDeShyO9F2gYqVQ=","To":"Kieran Bingham ,\n\tUmang Jain ,\n\tlibcamera devel ","References":"<20210715112845.4049846-1-kieran.bingham@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Fri, 16 Jul 2021 10:48:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210715112845.4049846-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18218,"web_url":"https://patchwork.libcamera.org/comment/18218/","msgid":"<166650bc-637d-c367-9ff5-fc951a603520@ideasonboard.com>","date":"2021-07-18T14:54:50","subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 7/15/21 5:11 PM, Kieran Bingham wrote:\n> Hi Laurent,\n>\n> On 15/07/2021 12:37, Laurent Pinchart wrote:\n>> Hi Kieran,\n>>\n>> Thank you for the patch.\n>>\n>> On Thu, Jul 15, 2021 at 12:28:45PM +0100, Kieran Bingham wrote:\n>>> In libcamera commit 6a31a8d8e274 (\"libcamera: buffer: Rename buffer.h to\n>>> framebuffer.h\"), the public header buffer.h was renamed.\n>>>\n>>> Update the usage accordingly.\n>>>\n>>> Signed-off-by: Kieran Bingham \nLGTM too.\n>> Reviewed-by: Laurent Pinchart \n> Thanks, I'll integrate this as an immediate fix.\n>\n> I've now added the IPA to my daily build system, so it will be rebuilt\n> against any libcamera updates, and I'll catch this sooner next time.\n>\n> (Looks like it's taken me 4 days to notice this !)\nYes, it was on my to-do list to ensure if rename patches have been \nmerged, handle this as well. Thanks for handling them while I was away!\n> --\n> Kieran\n>\n>\n>>> ---\n>>> include/libcamera-helpers/mapped_buffer.h | 2 +-\n>>> ipu3.cpp | 2 +-\n>>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/include/libcamera-helpers/mapped_buffer.h b/include/libcamera-helpers/mapped_buffer.h\n>>> index b34a70c5f2c5..6cfc57217d75 100644\n>>> --- a/include/libcamera-helpers/mapped_buffer.h\n>>> +++ b/include/libcamera-helpers/mapped_buffer.h\n>>> @@ -13,7 +13,7 @@\n>>> #include \n>>> #include \n>>> \n>>> -#include \n>>> +#include \n>>> \n>>> namespace libcamera {\n>>> \n>>> diff --git a/ipu3.cpp b/ipu3.cpp\n>>> index e0e87a8d70ec..651e0bb5efc1 100644\n>>> --- a/ipu3.cpp\n>>> +++ b/ipu3.cpp\n>>> @@ -11,8 +11,8 @@\n>>> #include \n>>> #include \n>>> \n>>> -#include \n>>> #include \n>>> +#include \n>>> #include \n>>> #include \n>>> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8262BC3228\n\tfor ;\n\tSun, 18 Jul 2021 14:54:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB2636853A;\n\tSun, 18 Jul 2021 16:54:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0B4860280\n\tfor ;\n\tSun, 18 Jul 2021 16:54:57 +0200 (CEST)","from [192.168.0.107] (unknown [103.251.226.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07A594FB;\n\tSun, 18 Jul 2021 16:54:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"awT4zZFg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626620097;\n\tbh=8blc7cQ6Bh4wUaAUmAbO210zdmA2YL/mTrfef+JlB1k=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=awT4zZFgJ7WIqBqR8wnpZkoiaNkndu6lKHMzbTDPD2kyb7Ul0wSFhYIlsOQ16nsBp\n\tc7EbAJCjZvtiuOQGcWDSnhT3QSuaV7Gi8R7F1hBmSly/j+fTrzn7noL/Sy+vXzwQ6p\n\t2olsJnv2reZ0HQDfKR+Q2RFFUHcxxUjOFrz3/rwc=","To":"Kieran Bingham ,\n\tLaurent Pinchart ","References":"<20210715112845.4049846-1-kieran.bingham@ideasonboard.com>\n\t\n\t","From":"Umang Jain ","Message-ID":"<166650bc-637d-c367-9ff5-fc951a603520@ideasonboard.com>","Date":"Sun, 18 Jul 2021 20:24:50 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [IPU3-IPA][PATCH] ipu3: Use updated buffer.h\n\theader","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]