[{"id":18188,"web_url":"https://patchwork.libcamera.org/comment/18188/","msgid":"","date":"2021-07-15T14:12:36","subject":"Re: [libcamera-devel] [PATCH] libipa: Correct OV5670\n\tCameraSensorHelper gain values","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Thu, Jul 15, 2021 at 12:17:09PM +0200, Jean-Michel Hautbois wrote:\n> The datasheet states that the low 7 bits are fraction bits.\n> real_gain = GainCode/128\n> For example, 0x080 is 1x gain, 0x100 is 2x gain.\n> \n> It means that we should have m0=1 and c1=128.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 17e4f0b2..709835a8 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -300,7 +300,7 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper\n> public:\n> \tCameraSensorHelperOv5670()\n> \t{\n> -\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 256 };\n> +\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> \t}\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5670\", CameraSensorHelperOv5670)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 478AFC3226\n\tfor ;\n\tThu, 15 Jul 2021 14:12:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 475BF68524;\n\tThu, 15 Jul 2021 16:12:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C99DA60282\n\tfor ;\n\tThu, 15 Jul 2021 16:12:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C9EC340;\n\tThu, 15 Jul 2021 16:12:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ErjCSg5I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626358358;\n\tbh=qGpBvVUXRTJxpl9FsZc528rNhyb2P9s0JWMOf89aiAg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ErjCSg5IMkcg86w1E5kNR3g1QHSJcvP+PNFgtxIS2Fs2lYByNcuenu82bFWSXgOYw\n\tt9iy36f+mq3/Bydkzl2c9FUwD7bQXkkDSZhuDsD84Ba+wiot0vvEtZs0551/TUB8yQ\n\tjk5DFaYul4mMB3SMhc56C46DP9k0eYsMOcbfCAzA=","Date":"Thu, 15 Jul 2021 17:12:36 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210715101709.202034-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210715101709.202034-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libipa: Correct OV5670\n\tCameraSensorHelper gain values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18194,"web_url":"https://patchwork.libcamera.org/comment/18194/","msgid":"","date":"2021-07-15T14:38:17","subject":"Re: [libcamera-devel] [PATCH] libipa: Correct OV5670\n\tCameraSensorHelper gain values","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 15/07/2021 11:17, Jean-Michel Hautbois wrote:\n> The datasheet states that the low 7 bits are fraction bits.\n> real_gain = GainCode/128\n> For example, 0x080 is 1x gain, 0x100 is 2x gain.\n> \n> It means that we should have m0=1 and c1=128.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 17e4f0b2..709835a8 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -300,7 +300,7 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper\n> public:\n> \tCameraSensorHelperOv5670()\n> \t{\n> -\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 256 };\n> +\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> \t}\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5670\", CameraSensorHelperOv5670)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68ABBC3226\n\tfor ;\n\tThu, 15 Jul 2021 14:38:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21C7B68533;\n\tThu, 15 Jul 2021 16:38:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CCCB60282\n\tfor ;\n\tThu, 15 Jul 2021 16:38:21 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8BBF340;\n\tThu, 15 Jul 2021 16:38:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NXwFOkh2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626359900;\n\tbh=gEciai2a8HECLJnIlGV95gbJAiD9BIDkp0Vc31/q3MM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=NXwFOkh2DGQAYqad6+XC38NyWTPyipX7T8DNyDjbmwdGI2EY7H46gqOCw7u8aXTxI\n\tHUujgaGA6VvFfaPHJA/kgHuzBpq9NWCdz4HHoW12z8Urp7IyseXD7sC4wQVg83fC7D\n\tCH9oyDKDZPzy5vkaJaZfX/0A2kOaQ8W2bpg8yYwE=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210715101709.202034-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"","Date":"Thu, 15 Jul 2021 15:38:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210715101709.202034-1-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libipa: Correct OV5670\n\tCameraSensorHelper gain values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]