[{"id":18189,"web_url":"https://patchwork.libcamera.org/comment/18189/","msgid":"","date":"2021-07-15T14:15:31","subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tOV13858","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Thu, Jul 15, 2021 at 12:13:15PM +0200, Jean-Michel Hautbois wrote:\n> Extend the CameraSensorHelper factory with support for an\n> OV13858 sensor as found in the Soraka Chromebook.\n> \n> The datasheet states that low 7 bits are fraction bits, so the gain is\n> calculated as gainCode=128*gain.\n> According to the formula, it means m0=1 and c1=128.\n> m1 then has to be 0, and c0=0.\n> \n> Signed-off-by: Kieran Bingham \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 84d8ccf7..17e4f0b2 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -315,6 +315,16 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> \n> +class CameraSensorHelperOv13858 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv13858()\n> +\t{\n> +\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n> +\n> #endif /* __DOXYGEN__ */\n> \n> } /* namespace ipa */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A259C3226\n\tfor ;\n\tThu, 15 Jul 2021 14:15:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0FC36852A;\n\tThu, 15 Jul 2021 16:15:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF30660282\n\tfor ;\n\tThu, 15 Jul 2021 16:15:32 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C663340;\n\tThu, 15 Jul 2021 16:15:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E6budNWs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626358532;\n\tbh=Y3KkTE0FC5ayEc6vyxXwgW8SLl+HOnBZTivGOJWDF6I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E6budNWspFtcqgyhN7/AykVa/w1z4JK8bljiJTAsBV67uL7kdq69Jest04hsFpIqT\n\tNCDuF1MKxbqmH+asz1WF4UNwdCU1xBHvSEzq2HajHpcAxq/Jc1pxFBZa/PYXiE1NUM\n\txWwgQQSIS48lQJuXCervknwV/GVsPF3bqNZcVj+A=","Date":"Thu, 15 Jul 2021 17:15:31 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210715101315.199703-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210715101315.199703-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tOV13858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18191,"web_url":"https://patchwork.libcamera.org/comment/18191/","msgid":"<8722d437-d40d-7350-6a6c-03b0d5f03c75@ideasonboard.com>","date":"2021-07-15T14:30:43","subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tOV13858","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 15/07/2021 11:13, Jean-Michel Hautbois wrote:\n> Extend the CameraSensorHelper factory with support for an\n> OV13858 sensor as found in the Soraka Chromebook.\n> \n> The datasheet states that low 7 bits are fraction bits, so the gain is\n> calculated as gainCode=128*gain.\n> According to the formula, it means m0=1 and c1=128.\n> m1 then has to be 0, and c0=0.\n> \n> Signed-off-by: Kieran Bingham \n> Signed-off-by: Jean-Michel Hautbois \n\nWhile I already have an SoB here - This can also apply ;-)\n\nReviewed-by: Kieran Bingham \n\n\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 84d8ccf7..17e4f0b2 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -315,6 +315,16 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> \n> +class CameraSensorHelperOv13858 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv13858()\n> +\t{\n> +\t\tanalogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n> +\n> #endif /* __DOXYGEN__ */\n> \n> } /* namespace ipa */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 141E9C3226\n\tfor ;\n\tThu, 15 Jul 2021 14:30:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAA3F68533;\n\tThu, 15 Jul 2021 16:30:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3915B60282\n\tfor ;\n\tThu, 15 Jul 2021 16:30:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8371340;\n\tThu, 15 Jul 2021 16:30:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sqJcitWc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626359446;\n\tbh=8eqrhfVlPpeGEYvhBYj7pelWrVZ1+QB8YL/stsaDYLY=;\n\th=From:Subject:To:References:Date:In-Reply-To:From;\n\tb=sqJcitWcFYt7mfolBXBuhmsnuQUw9084r02BmhAS+CUSoZS1FYrDWrQGBbKFCqykq\n\twtwxhcAFCL6lhgc1XCy6kSiChaxH6xIjWNmjp16UaMRboKvW8bINIu7Df3V8pKs87+\n\t6i9Iy7IedKlw3BaeoFJkOAaEBf7pN+ILBwKPW3J4=","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210715101315.199703-1-jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<8722d437-d40d-7350-6a6c-03b0d5f03c75@ideasonboard.com>","Date":"Thu, 15 Jul 2021 15:30:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210715101315.199703-1-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2] libipa: Add CameraSensorHelper for\n\tOV13858","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]