[{"id":18174,"web_url":"https://patchwork.libcamera.org/comment/18174/","msgid":"","date":"2021-07-14T13:14:28","subject":"Re: [libcamera-devel] [PATCH v2] ipa: raspberrypi: Remove unused\n\tMetadataPtr","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jean-Michel,\n\nThank you for your patch.\n\nOn Wed, 14 Jul 2021 at 14:02, Jean-Michel Hautbois <\njeanmichel.hautbois@ideasonboard.com> wrote:\n\n> The Metadata class defines a shared_ptr named MetadataPtr. It is not\n> used anywhere in the source code, so remove it.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Laurent Pinchart \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/controller/metadata.hpp | 3 ---\n> 1 file changed, 3 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/metadata.hpp\n> b/src/ipa/raspberrypi/controller/metadata.hpp\n> index fd6aac88..51e576cf 100644\n> --- a/src/ipa/raspberrypi/controller/metadata.hpp\n> +++ b/src/ipa/raspberrypi/controller/metadata.hpp\n> @@ -10,7 +10,6 @@\n>\n> #include \n> #include \n> -#include \n> #include \n> #include \n>\n> @@ -108,6 +107,4 @@ private:\n> std::map data_;\n> };\n>\n> -typedef std::shared_ptr MetadataPtr;\n> -\n> } // namespace RPiController\n> --\n> 2.30.2\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA5FFC3226\n\tfor ;\n\tWed, 14 Jul 2021 13:14:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60F6768506;\n\tWed, 14 Jul 2021 15:14:48 +0200 (CEST)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 728EA68503\n\tfor ;\n\tWed, 14 Jul 2021 15:14:45 +0200 (CEST)","by mail-lf1-x12f.google.com with SMTP id b26so3540895lfo.4\n\tfor ;\n\tWed, 14 Jul 2021 06:14:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KmB/3pcm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=RiXH8oBRIOL75r/pNYwP+QL1HHSEftyRNNdiaADXXcM=;\n\tb=KmB/3pcmD0vqxfsjXSQJWSmznTR4GzYn1rGgZc39J3sIDpyO/KZ2s0OHYh/IIW/zb+\n\trKBVkUZ2i9j5p1JM2vi+0P573/+7gIjzYwc4t9XuSlp1yPxt3AFWhHew3U0hcpiUoBJq\n\trYxqClv/BZedfoZHTsAwG0EL2grhIWsF145Fiu2glaLXbfNAs800oHCAZtki+B4qT/j3\n\t+IU+X+1Q3+657ngOcd6GhKcKBhkpGdsKn/AkR6ZRvmYvurntJShfq/q9DLfpr0iCtQez\n\twICkkBVHHXVA81VW6QJvFlUrzvxBeYhETZzPl3yr2eh+tM9T4xBjkDx9J59rHuKcTyXX\n\tOMwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=RiXH8oBRIOL75r/pNYwP+QL1HHSEftyRNNdiaADXXcM=;\n\tb=XDG+tbE+7zyh3uLB6Jr1qLhc5d31/1Nnl7Q4zB+5U7SxP/7DK0mppysxqEoYbKO8wX\n\t76/fsK1SrdOkZh0hRFJY5FGWDm3di5MPQIy4vn3DfdW29wSi8CfErAC2F9RAG24LMJ/9\n\t0HyekrrHPULCNpNCCaYpG7SDzy7gqoQ5w/biZXmP54pI1mSGWKbpFlpr9ozoUG5i9ju9\n\thxxVhekHPY0cl+OhBQLK4L5AdRnO3rRdrQqFM1Eo98FG7SN4MiBTfrjr4Z7dlHokLYEU\n\tvhSsRTassj2BsALBunO1NxJacsAD+YKbj+LO5S2fRBxjQ2ppMkXNk/MAUGd1ONJewwgr\n\tUEww==","X-Gm-Message-State":"AOAM532PeEDArfUONrggG138cIu3BbS+yy1z+Pk+tOWFUQpFMc8NrdQF\n\tlfUBDzc878xmJlP6OAHnhmPeuM6nWGG25vN4gbg6lA==","X-Google-Smtp-Source":"ABdhPJwxRnub8pF3rbQTgSwm4j73WQ/GKA43Xygm3RCTnd+hnxph/Sopm04/aP1oePZWmXKuj/qPkZOORwr9b7TYiLo=","X-Received":"by 2002:a19:4f09:: with SMTP id d9mr7898737lfb.567.1626268484708;\n\tWed, 14 Jul 2021 06:14:44 -0700 (PDT)","MIME-Version":"1.0","References":"<20210714130232.63284-1-jeanmichel.hautbois@ideasonboard.com>","In-Reply-To":"<20210714130232.63284-1-jeanmichel.hautbois@ideasonboard.com>","From":"Naushir Patuck ","Date":"Wed, 14 Jul 2021 14:14:28 +0100","Message-ID":"","To":"Jean-Michel Hautbois ","Content-Type":"multipart/alternative; boundary=\"00000000000057439c05c71523ae\"","Subject":"Re: [libcamera-devel] [PATCH v2] ipa: raspberrypi: Remove unused\n\tMetadataPtr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]