[{"id":18170,"web_url":"https://patchwork.libcamera.org/comment/18170/","msgid":"","date":"2021-07-14T09:12:02","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tMetadataPtr","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Wed, Jul 14, 2021 at 11:06:59AM +0200, Jean-Michel Hautbois wrote:\n> The Metadata class defines a shared_ptr named MetadataPtr. It is not\n> used anywhere in the source code, so remove it.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nAvoiding new std::shared_ptr<> users is also a good idea.\n\nYou can now drop inclusion of . With this,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/metadata.hpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp\n> index fd6aac88..4b2b4ca3 100644\n> --- a/src/ipa/raspberrypi/controller/metadata.hpp\n> +++ b/src/ipa/raspberrypi/controller/metadata.hpp\n> @@ -108,6 +108,4 @@ private:\n> \tstd::map data_;\n> };\n> \n> -typedef std::shared_ptr MetadataPtr;\n> -\n> } // namespace RPiController","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 791AEC3225\n\tfor ;\n\tWed, 14 Jul 2021 09:12:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE2CB68525;\n\tWed, 14 Jul 2021 11:12:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE6F360282\n\tfor ;\n\tWed, 14 Jul 2021 11:12:03 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7377FCC;\n\tWed, 14 Jul 2021 11:12:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mZbAAkWL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626253923;\n\tbh=yrQuYc5yDYavNfwyr0ztrBO90Jo+Do6dFh/BJQaNwxc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mZbAAkWLGmUIgcZuDmoc0urg0GVVSZoxj3RjddFmkDhHgAWpj7C4RGM6EcqoXsC5d\n\tou10VDYPHztwV8gdRp8q5PXE3BE6Kn1pbskgH8V6jfQhpl9TdVrQxidxAt8wXbfLVR\n\tvug/Ndw5cMW/pYcqsXa6PbhAz2jcsv/wxmwWVLK8=","Date":"Wed, 14 Jul 2021 12:12:02 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210714090659.48758-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210714090659.48758-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tMetadataPtr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]