{"id":12934,"url":"https://patchwork.libcamera.org/api/patches/12934/?format=json","web_url":"https://patchwork.libcamera.org/patch/12934/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210712215645.30478-22-laurent.pinchart@ideasonboard.com>","date":"2021-07-12T21:56:36","name":"[libcamera-devel,v2,21/30] cam: Drop unneeded error check and message","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"69e621a40cbe3e0c3c6cc957ed0cb8b7d4b64dda","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12934/mbox/","series":[{"id":2229,"url":"https://patchwork.libcamera.org/api/series/2229/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2229","date":"2021-07-12T21:56:15","name":"Multi-camera support in the cam application","version":2,"mbox":"https://patchwork.libcamera.org/series/2229/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12934/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12934/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4439DC3228\n\tfor ;\n\tMon, 12 Jul 2021 21:57:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E834D6852B;\n\tMon, 12 Jul 2021 23:57:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFDE86854B\n\tfor ;\n\tMon, 12 Jul 2021 23:57:42 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6782056B\n\tfor ;\n\tMon, 12 Jul 2021 23:57:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m2/SRche\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626127062;\n\tbh=JNMwK9ZSYz74XZ/FXU8Sqe7EC2ux5T3ZhU5D9oBlbU4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=m2/SRcheqxE5TcECjyzmEt7llwdUgQDP1dKwHEXA+RlyQsirWiwRiNC/DZa7knwqf\n\t7iGwlovgti7XfEfFYOTJWI7Su35kkTKKuP7BFxBL79K9FWBZj5FAvZKeXgJRj3SsS1\n\tT0gZ3SZjm9ziptF7zbCImpJa4lwB/kpFZ0/MUQNU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Jul 2021 00:56:36 +0300","Message-Id":"<20210712215645.30478-22-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","References":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 21/30] cam: Drop unneeded error check\n\tand message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The EventLoop::exec() function returns the exit code of the event loop,\nnot an error status. Drop the corresponding error check and error\nmessage.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/cam/main.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 2ef26353e712..19ed9837cf4f 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -313,9 +313,7 @@ int CamApp::run()\n \n \tif (options_.isSet(OptMonitor)) {\n \t\tstd::cout << \"Press Ctrl-C to interrupt\" << std::endl;\n-\t\tret = loop_.exec();\n-\t\tif (ret)\n-\t\t\tstd::cout << \"Failed to run monitor loop\" << std::endl;\n+\t\tloop_.exec();\n \t}\n \n \treturn 0;\n","prefixes":["libcamera-devel","v2","21/30"]}