{"id":12932,"url":"https://patchwork.libcamera.org/api/patches/12932/?format=json","web_url":"https://patchwork.libcamera.org/patch/12932/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210712215645.30478-21-laurent.pinchart@ideasonboard.com>","date":"2021-07-12T21:56:35","name":"[libcamera-devel,v2,20/30] cam: Use std::unique_ptr<> to manage CameraManager","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e22d4026673f1f9b3f7ebd30db9ee9557f85f712","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12932/mbox/","series":[{"id":2229,"url":"https://patchwork.libcamera.org/api/series/2229/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2229","date":"2021-07-12T21:56:15","name":"Multi-camera support in the cam application","version":2,"mbox":"https://patchwork.libcamera.org/series/2229/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12932/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12932/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD77CC3226\n\tfor ;\n\tMon, 12 Jul 2021 21:57:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59FCC68548;\n\tMon, 12 Jul 2021 23:57:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 745A76852B\n\tfor ;\n\tMon, 12 Jul 2021 23:57:42 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 197913F1\n\tfor ;\n\tMon, 12 Jul 2021 23:57:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jgpd4Peh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626127062;\n\tbh=bUtsSy4UE3H6V43iaM72VWdZ+Y8/Y9xnZbYxwPkH0K8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Jgpd4PehLO/vjQkkEDAy+iwipFBLGELk0r8x9RJPBaAz+HB1QPKQ4+7ejlN5lWJ15\n\t/biVyu2KL36ve1/JhcVQggZhzWFZqtj0dSqnHw1lab4hOCavK+9mxjTW30ZfrbOumo\n\tX5n+jcTt7xEMGAU9rktVy2yGAmzAGarReIUEDxzI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Jul 2021 00:56:35 +0300","Message-Id":"<20210712215645.30478-21-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","References":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 20/30] cam: Use std::unique_ptr<> to\n\tmanage CameraManager","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Store the CameraManager instance in a unique_ptr to simplify memory\nmanagement and avoid leaks.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/cam/main.cpp | 13 +++----------\n 1 file changed, 3 insertions(+), 10 deletions(-)","diff":"diff --git a/src/cam/main.cpp b/src/cam/main.cpp\nindex 8ed5e841a1e9..2ef26353e712 100644\n--- a/src/cam/main.cpp\n+++ b/src/cam/main.cpp\n@@ -25,7 +25,6 @@ class CamApp\n {\n public:\n \tCamApp();\n-\t~CamApp();\n \n \tstatic CamApp *instance();\n \n@@ -49,8 +48,8 @@ private:\n \n \tstatic CamApp *app_;\n \tOptionsParser::Options options_;\n-\tCameraManager *cm_;\n \n+\tstd::unique_ptr cm_;\n \tstd::unique_ptr session_;\n \n \tEventLoop loop_;\n@@ -59,16 +58,10 @@ private:\n CamApp *CamApp::app_ = nullptr;\n \n CamApp::CamApp()\n-\t: cm_(nullptr)\n {\n \tCamApp::app_ = this;\n }\n \n-CamApp::~CamApp()\n-{\n-\tdelete cm_;\n-}\n-\n CamApp *CamApp::instance()\n {\n \treturn CamApp::app_;\n@@ -82,7 +75,7 @@ int CamApp::init(int argc, char **argv)\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tcm_ = new CameraManager();\n+\tcm_ = std::make_unique();\n \n \tret = cm_->start();\n \tif (ret) {\n@@ -92,7 +85,7 @@ int CamApp::init(int argc, char **argv)\n \t}\n \n \tif (options_.isSet(OptCamera)) {\n-\t\tsession_ = std::make_unique(cm_, options_);\n+\t\tsession_ = std::make_unique(cm_.get(), options_);\n \t\tif (!session_->isValid()) {\n \t\t\tstd::cout << \"Failed to create camera session\" << std::endl;\n \t\t\tcleanup();\n","prefixes":["libcamera-devel","v2","20/30"]}