[{"id":1706,"web_url":"https://patchwork.libcamera.org/comment/1706/","msgid":"<20190527092229.7rkgmbiwkdqbiyrb@uno.localdomain>","date":"2019-05-27T09:22:29","subject":"Re: [libcamera-devel] [PATCH 02/17] libcamera: geometry: SizeRange:\n\tAdd constructor for a single size","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Mon, May 27, 2019 at 02:15:28AM +0200, Niklas Söderlund wrote:\n> The SizeRange can describe a single size where min == max. Add a\n> constructor to help create such a description.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/geometry.h | 5 +++++\n> src/libcamera/geometry.cpp | 7 +++++++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index a87d65d3ed7951c2..ec5ed2bee196c82d 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -72,6 +72,11 @@ struct SizeRange {\n> \t{\n> \t}\n>\n> +\tSizeRange(unsigned int width, unsigned int height)\n> +\t\t: min(width, height), max(width, height)\n> +\t{\n> +\t}\n> +\n> \tSizeRange(unsigned int minW, unsigned int minH,\n> \t\t unsigned int maxW, unsigned int maxH)\n> \t\t: min(minW, minH), max(maxW, maxH)\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index 97c367bcb454b517..cc25b816e6796ba1 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -196,6 +196,13 @@ bool operator<(const Size &lhs, const Size &rhs)\n> * \\brief Construct a size range initialized to 0\n> */\n>\n> +/**\n> + * \\fn SizeRange::SizeRange(unsigned int width, unsigned int height)\n> + * \\brief Construct size range with a single size\n\nnit: for consistency with the existing constructor and the structure\ndocumentation:\n \\brief Construct a size range representing a single size\n\n> + * \\param[in] width Single width\n> + * \\param[in] height Single height\n\nnit: I would drop 'Single' in favour of just 'The size width/height'\n\nMinors apart:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> + */\n> +\n> /**\n> * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)\n> * \\brief Construct an initialized size range\n> --\n> 2.21.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ACAF600EA\n\tfor ;\n\tMon, 27 May 2019 11:21:22 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9D45F1C0008;\n\tMon, 27 May 2019 09:21:21 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 27 May 2019 11:22:29 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190527092229.7rkgmbiwkdqbiyrb@uno.localdomain>","References":"<20190527001543.13593-1-niklas.soderlund@ragnatech.se>\n\t<20190527001543.13593-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"jptsuzcwiwxuia22\"","Content-Disposition":"inline","In-Reply-To":"<20190527001543.13593-3-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 02/17] libcamera: geometry: SizeRange:\n\tAdd constructor for a single size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 27 May 2019 09:21:22 -0000"}},{"id":1794,"web_url":"https://patchwork.libcamera.org/comment/1794/","msgid":"<20190608162741.GA25825@pendragon.ideasonboard.com>","date":"2019-06-08T16:27:41","subject":"Re: [libcamera-devel] [PATCH 02/17] libcamera: geometry: SizeRange:\n\tAdd constructor for a single size","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Mon, May 27, 2019 at 11:22:29AM +0200, Jacopo Mondi wrote:\n> On Mon, May 27, 2019 at 02:15:28AM +0200, Niklas Söderlund wrote:\n> > The SizeRange can describe a single size where min == max. Add a\n> > constructor to help create such a description.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > include/libcamera/geometry.h | 5 +++++\n> > src/libcamera/geometry.cpp | 7 +++++++\n> > 2 files changed, 12 insertions(+)\n> >\n> > diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> > index a87d65d3ed7951c2..ec5ed2bee196c82d 100644\n> > --- a/include/libcamera/geometry.h\n> > +++ b/include/libcamera/geometry.h\n> > @@ -72,6 +72,11 @@ struct SizeRange {\n> > \t{\n> > \t}\n> >\n> > +\tSizeRange(unsigned int width, unsigned int height)\n> > +\t\t: min(width, height), max(width, height)\n> > +\t{\n> > +\t}\n> > +\n> > \tSizeRange(unsigned int minW, unsigned int minH,\n> > \t\t unsigned int maxW, unsigned int maxH)\n> > \t\t: min(minW, minH), max(maxW, maxH)\n> > diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> > index 97c367bcb454b517..cc25b816e6796ba1 100644\n> > --- a/src/libcamera/geometry.cpp\n> > +++ b/src/libcamera/geometry.cpp\n> > @@ -196,6 +196,13 @@ bool operator<(const Size &lhs, const Size &rhs)\n> > * \\brief Construct a size range initialized to 0\n> > */\n> >\n> > +/**\n> > + * \\fn SizeRange::SizeRange(unsigned int width, unsigned int height)\n> > + * \\brief Construct size range with a single size\n> \n> nit: for consistency with the existing constructor and the structure\n> documentation:\n> \\brief Construct a size range representing a single size\n> \n> > + * \\param[in] width Single width\n> > + * \\param[in] height Single height\n> \n> nit: I would drop 'Single' in favour of just 'The size width/height'\n> \n> Minors apart:\n> Reviewed-by: Jacopo Mondi \n\nI agree with both comments.\n\nReviewed-by: Laurent Pinchart \n\n> > + */\n> > +\n> > /**\n> > * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)\n> > * \\brief Construct an initialized size range","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F27A26BE6E\n\tfor ;\n\tSat, 8 Jun 2019 18:27:55 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [109.132.30.162])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 895025D;\n\tSat, 8 Jun 2019 18:27:55 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560011275;\n\tbh=CMgTgnBvjtTe84d3LRndwEjJkC/Jc1ila9kovJnF2Oc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iWFHUXCqyDMR4Hi9a+pCkb1bJeN4NXb/75BxYXIm4+b1deiFV/+N3C2yWc3vG9g9S\n\t3MkdcnOjpZQQjOVPSyJD/f6Z8CzvthHmEl9jz/RjXK5Q1ABe3SxncGdfbTxL+nT225\n\trdZJnj7hL7CQyst/Yi+IvRAXeVGLrRBcEaWUSpbQ=","Date":"Sat, 8 Jun 2019 19:27:41 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","Message-ID":"<20190608162741.GA25825@pendragon.ideasonboard.com>","References":"<20190527001543.13593-1-niklas.soderlund@ragnatech.se>\n\t<20190527001543.13593-3-niklas.soderlund@ragnatech.se>\n\t<20190527092229.7rkgmbiwkdqbiyrb@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190527092229.7rkgmbiwkdqbiyrb@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 02/17] libcamera: geometry: SizeRange:\n\tAdd constructor for a single size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 08 Jun 2019 16:27:57 -0000"}}]