[{"id":1701,"web_url":"https://patchwork.libcamera.org/comment/1701/","msgid":"<20190525034442.GB5011@pendragon.ideasonboard.com>","date":"2019-05-25T03:44:42","subject":"Re: [libcamera-devel] [PATCH] tests: list_formats: Fix argument\n\tnames and add const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, May 25, 2019 at 02:22:29AM +0200, Niklas Söderlund wrote:\n> Argument name differs from definition and implementation, fix it by\n> renaming the definition. While at it make the argument const.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/v4l2_subdevice/list_formats.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> index 18dd8761a8ab408f..3f0edafcdcd72d6b 100644\n> --- a/test/v4l2_subdevice/list_formats.cpp\n> +++ b/test/v4l2_subdevice/list_formats.cpp\n> @@ -26,15 +26,15 @@ protected:\n> \n> private:\n> \tvoid printFormats(unsigned int pad, unsigned code,\n> -\t\t\t std::vector &formats);\n> +\t\t\t const std::vector &sizes);\n> };\n> \n> void ListFormatsTest::printFormats(unsigned int pad,\n> \t\t\t\t unsigned int code,\n> -\t\t\t\t std::vector &sizes)\n> +\t\t\t\t const std::vector &sizes)\n> {\n> \tcout << \"Enumerate formats on pad \" << pad << endl;\n> -\tfor (SizeRange &size : sizes) {\n> +\tfor (const SizeRange &size : sizes) {\n> \t\tcout << \"\tmbus code: 0x\" << setfill('0') << setw(4)\n> \t\t << hex << code << endl;\n> \t\tcout << \"\tmin width: \" << dec << size.min.width << endl;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED39A60E49\n\tfor ;\n\tSat, 25 May 2019 05:45:00 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [212.213.198.112])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54531443;\n\tSat, 25 May 2019 05:45:00 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558755900;\n\tbh=rLwxvNe8ol4zKmLdEn4exEW3NPWtEh6qQ40mNP/5ZrM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I5ts0sUncSO0Y4XkBlLe5xsTLJU5+ZANDTjB51eRzc7coxG9J5PA0rmaLfHxsqfFe\n\tjGj2kDbgUPdDIy5uRMnXnt9ARymCSxY8Q8lDzN0CBaRlOkN5CEd3PWYqOaLD/nCbjO\n\tGUOvZOG2T6OPUv4hAfMdugFVrm11MMCAMZD4S1Lk=","Date":"Sat, 25 May 2019 06:44:42 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190525034442.GB5011@pendragon.ideasonboard.com>","References":"<20190525002229.1160-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190525002229.1160-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] tests: list_formats: Fix argument\n\tnames and add const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 May 2019 03:45:01 -0000"}},{"id":1702,"web_url":"https://patchwork.libcamera.org/comment/1702/","msgid":"<20190525125243.GC6678@bigcity.dyn.berto.se>","date":"2019-05-25T12:52:43","subject":"Re: [libcamera-devel] [PATCH] tests: list_formats: Fix argument\n\tnames and add const","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have pushed this to master with Laurent's tag, thanks!\n\nOn 2019-05-25 06:44:42 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Sat, May 25, 2019 at 02:22:29AM +0200, Niklas Söderlund wrote:\n> > Argument name differs from definition and implementation, fix it by\n> > renaming the definition. While at it make the argument const.\n> > \n> > Signed-off-by: Niklas Söderlund \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > test/v4l2_subdevice/list_formats.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\n> > index 18dd8761a8ab408f..3f0edafcdcd72d6b 100644\n> > --- a/test/v4l2_subdevice/list_formats.cpp\n> > +++ b/test/v4l2_subdevice/list_formats.cpp\n> > @@ -26,15 +26,15 @@ protected:\n> > \n> > private:\n> > \tvoid printFormats(unsigned int pad, unsigned code,\n> > -\t\t\t std::vector &formats);\n> > +\t\t\t const std::vector &sizes);\n> > };\n> > \n> > void ListFormatsTest::printFormats(unsigned int pad,\n> > \t\t\t\t unsigned int code,\n> > -\t\t\t\t std::vector &sizes)\n> > +\t\t\t\t const std::vector &sizes)\n> > {\n> > \tcout << \"Enumerate formats on pad \" << pad << endl;\n> > -\tfor (SizeRange &size : sizes) {\n> > +\tfor (const SizeRange &size : sizes) {\n> > \t\tcout << \"\tmbus code: 0x\" << setfill('0') << setw(4)\n> > \t\t << hex << code << endl;\n> > \t\tcout << \"\tmin width: \" << dec << size.min.width << endl;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DA1560BBB\n\tfor ;\n\tSat, 25 May 2019 14:52:45 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id 188so10927442ljf.9\n\tfor ;\n\tSat, 25 May 2019 05:52:45 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tv23sm1050853ljk.53.2019.05.25.05.52.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 25 May 2019 05:52:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=nft8mgEi4IGbFHdzZDCnQEQpHsfyl+Y6a0W5UU6Dp4Y=;\n\tb=issQ5dSTX+dXu8oEczR2u6ghmgAm+DHX2gM3gNDaBDcneeQdSnoaEsmxoWqCcDLM1m\n\tShsvxW8qiYaoP5QDiOlh7BkuboSxyHHFkwI//egrT5hHtV4Ccc29X75aPO0CS0Eg2Pw+\n\tJDlAWfKsbunceyBqrf2m3eTUD77vOKdOPf9wNyh5guqEKEqVw7GdQ8lyLEw6MyjmvY9r\n\tMwj9VVw0iHtHeOKyMselndB7iNofOuQRgwlZdyR3CDBSuofQEK9LTTSlDwWFnWqjcDH5\n\tTLs7yqR42GdJ0VQfsNcFcJBHUGugitFFwtsXF1Wqmw8Caph4+ASj/nWIs8IZzA79FO25\n\tD6EA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=nft8mgEi4IGbFHdzZDCnQEQpHsfyl+Y6a0W5UU6Dp4Y=;\n\tb=jxBm5oyEA2DxLa3FuZy6PqMJI4fUgI6AHMleUnrDZ2siffkZlSdcnqJYmwCGGVTSfU\n\tkFlnB6A+zxe7qCn9TgSEKZoh7dibDfs0HjDmWIGf6rLFFWGAHccuPLX8qhiemxRekd0V\n\tXkeMapqj24Nig/3+QY8oiuSSRMtpx8TygjetCDqRRg14RIHIoiMtrvhKpA2Qli41eEZ/\n\tC+WondN80kOr9C81ebaX86bz/ALhiN2BGCkjww/Sr7cPlc21HG4/9qten1T8zN+Vsz9N\n\tVt+Vu6HhdJMnBowomLGW/DPkxQBtEO91OhkO6Gb4a0HiuSWQ1JkLoSHHKZpQVrlM7PnN\n\tAgLA==","X-Gm-Message-State":"APjAAAV4pReLZZXOWcv7v+KNrwqf04ZRR+UsTvCj1xSRjpLisfGjsava\n\tGfCjaBBQgSe3Z2dIDmhWcJjhUcaaojQ=","X-Google-Smtp-Source":"APXvYqykQBkow72g6Vr/hM3y7rlC+2K4hq0IqROm/EtuI9EPxCyr1bW5K+9wsTuS3XDFSBx7J2ylrw==","X-Received":"by 2002:a2e:97cf:: with SMTP id\n\tm15mr13427637ljj.135.1558788764575; \n\tSat, 25 May 2019 05:52:44 -0700 (PDT)","Date":"Sat, 25 May 2019 14:52:43 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190525125243.GC6678@bigcity.dyn.berto.se>","References":"<20190525002229.1160-1-niklas.soderlund@ragnatech.se>\n\t<20190525034442.GB5011@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190525034442.GB5011@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.11.4 (2019-03-13)","Subject":"Re: [libcamera-devel] [PATCH] tests: list_formats: Fix argument\n\tnames and add const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 25 May 2019 12:52:45 -0000"}}]