{"id":12917,"url":"https://patchwork.libcamera.org/api/patches/12917/?format=json","web_url":"https://patchwork.libcamera.org/patch/12917/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210712215645.30478-5-laurent.pinchart@ideasonboard.com>","date":"2021-07-12T21:56:19","name":"[libcamera-devel,v2,04/30] cam: options: Move OptionValue class after OptionsParser","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6e1b95da24f13bfe2df34a50d346a5217d8b398d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12917/mbox/","series":[{"id":2229,"url":"https://patchwork.libcamera.org/api/series/2229/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2229","date":"2021-07-12T21:56:15","name":"Multi-camera support in the cam application","version":2,"mbox":"https://patchwork.libcamera.org/series/2229/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12917/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12917/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B1E2C3227\n\tfor ;\n\tMon, 12 Jul 2021 21:57:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 143DC6854A;\n\tMon, 12 Jul 2021 23:57:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 378A468521\n\tfor ;\n\tMon, 12 Jul 2021 23:57:37 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD239CC\n\tfor ;\n\tMon, 12 Jul 2021 23:57:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"myuv8jVW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626127057;\n\tbh=u4NF1n4ch7rg4HLqz/5lzP6cCkpx25MmJyUbamz+650=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=myuv8jVW9rBkaut2wlswymE3hVKD3SclvNlQCiyK29CyifM6PpNHxfWdzqDKqTfKt\n\tqcNTr76V2tgLexR6u3HL1yJipT4LgEUcPzn6hFcSW2tlt4WXZ4LlNnxF9p7kvj5xVs\n\ttTUCL0bElykqTvy37k78P3pDjLqaG6a52VcN8/8o=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Jul 2021 00:56:19 +0300","Message-Id":"<20210712215645.30478-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","References":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 04/30] cam: options: Move OptionValue\n\tclass after OptionsParser","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To prepare for usage of the OptionsParser::Options class in OptionValue,\nmove the definition of the OptionValue class after OptionsParser. There\nis no functional change.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/cam/options.h | 54 +++++++++++++++++++++++------------------------\n 1 file changed, 27 insertions(+), 27 deletions(-)","diff":"diff --git a/src/cam/options.h b/src/cam/options.h\nindex 688fe26011f8..a3b18bb6c4ea 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -74,6 +74,33 @@ private:\n \tstd::map optionsMap_;\n };\n \n+class OptionsParser\n+{\n+public:\n+\tclass Options : public OptionsBase\n+\t{\n+\t};\n+\n+\tOptionsParser();\n+\t~OptionsParser();\n+\n+\tbool addOption(int opt, OptionType type, const char *help,\n+\t\t const char *name = nullptr,\n+\t\t OptionArgument argument = ArgumentNone,\n+\t\t const char *argumentName = nullptr, bool array = false);\n+\tbool addOption(int opt, KeyValueParser *parser, const char *help,\n+\t\t const char *name = nullptr, bool array = false);\n+\n+\tOptions parse(int argc, char *argv[]);\n+\tvoid usage();\n+\n+private:\n+\tvoid parseValueError(const Option &option);\n+\n+\tstd::list