{"id":12914,"url":"https://patchwork.libcamera.org/api/patches/12914/?format=json","web_url":"https://patchwork.libcamera.org/patch/12914/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210712215645.30478-2-laurent.pinchart@ideasonboard.com>","date":"2021-07-12T21:56:16","name":"[libcamera-devel,v2,01/30] cam: options: Make KeyValueParser::usage() private","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f34077b1fc67cdd471cf9beaf2f37956883f4f74","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12914/mbox/","series":[{"id":2229,"url":"https://patchwork.libcamera.org/api/series/2229/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2229","date":"2021-07-12T21:56:15","name":"Multi-camera support in the cam application","version":2,"mbox":"https://patchwork.libcamera.org/series/2229/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12914/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12914/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07C5DC3226\n\tfor ;\n\tMon, 12 Jul 2021 21:57:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACA2368530;\n\tMon, 12 Jul 2021 23:57:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ACE868523\n\tfor ;\n\tMon, 12 Jul 2021 23:57:36 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9CD63F1\n\tfor ;\n\tMon, 12 Jul 2021 23:57:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MTAUkNxy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626127055;\n\tbh=SZc5X1SBE2MXZ6mozu/Ndinq4j+ms+BeGc+t/+h9EWM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=MTAUkNxyYwodVmhoYsFQzOqbQFISRSsLRLhhVQDNtomtT8Ty1Oxherha7tXFpIviL\n\tzplsY7PjlMwu2wpAgch8QAgtEXCihutpJvfRTljWYI9WYlrM1IKzQGsyhKukUyoEVr\n\t/B6B3A0as5IegJBXy4sQ9MK7Z22Bn+xk7tNnVd/M=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 13 Jul 2021 00:56:16 +0300","Message-Id":"<20210712215645.30478-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","References":"<20210712215645.30478-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 01/30] cam: options: Make\n\tKeyValueParser::usage() private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The KeyValueParser::usage() function is meant to be called from an\nOptionsParser or another KeyValueParser only. Make it private, and set\nthe OptionsParser class as a friend of the KeyValueParser class.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/cam/options.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/cam/options.h b/src/cam/options.h\nindex f02eeca2eef9..d0defb4bd665 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -79,9 +79,11 @@ public:\n \t\t OptionArgument argument = ArgumentNone);\n \n \tvirtual Options parse(const char *arguments);\n+\n+private:\n+\tfriend class OptionsParser;\n \tvoid usage(int indent);\n \n-private:\n \tstd::map optionsMap_;\n };\n \n","prefixes":["libcamera-devel","v2","01/30"]}