{"id":12909,"url":"https://patchwork.libcamera.org/api/patches/12909/?format=json","web_url":"https://patchwork.libcamera.org/patch/12909/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210712100209.447893-9-naush@raspberrypi.com>","date":"2021-07-12T10:02:09","name":"[libcamera-devel,v7,8/8] ipa: raspberrypi: Make variable names consistent","commit_ref":"37e31b2c6b241dff5153025af566ab671b10ff68","pull_url":null,"state":"accepted","archived":false,"hash":"f31a50c0338dff5ce2c47fc852d5e1f000206f7f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12909/mbox/","series":[{"id":2227,"url":"https://patchwork.libcamera.org/api/series/2227/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2227","date":"2021-07-12T10:02:01","name":"ipa: raspberrypi: Allow long exposure modes for imx477.","version":7,"mbox":"https://patchwork.libcamera.org/series/2227/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12909/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12909/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65065C3226\n\tfor ;\n\tMon, 12 Jul 2021 10:02:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EB4D68524;\n\tMon, 12 Jul 2021 12:02:26 +0200 (CEST)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D914E68537\n\tfor ;\n\tMon, 12 Jul 2021 12:02:21 +0200 (CEST)","by mail-wm1-x330.google.com with SMTP id k32so7791495wms.4\n\tfor ;\n\tMon, 12 Jul 2021 03:02:21 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:3395:5e50:10bb:f8fd])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm14249941wrs.51.2021.07.12.03.02.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 12 Jul 2021 03:02:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RNbX5AmQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JfVlZgifnrAPHzprhAfOgQPbEe41tKFlQcQqQlEMu0M=;\n\tb=RNbX5AmQ+a8w6fYoLVsQbAeMBsrJqSk4KGIglmpM7j0KAeKVEjYIX5kuMq0UOq1+p0\n\tyZhP2JzxlSam76LGOG9O4rC/wAdQuILtn06p+0Qlcj5P2goeqmyu1TeRUWJ8j6LLiTz3\n\txRwZv0G9n7il1oV8wR0xCYSfjRFpgM9HjvwKRNGrHiruIctPbpePfZoXmzMzwQtGMgy0\n\tYA8FxBDRQn7XqXOqHJ4sdvnD3SEDY+QZqfLwAgPn4KN0RIQxgHxUg8i/xvkxKBUY2swo\n\tFvEv1vcl30d8sjjiVSSwavx23ck0/8N7pvfcWHdt2XBJfokJ86olxUMskDZf/dXwq5UV\n\t/Zkg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JfVlZgifnrAPHzprhAfOgQPbEe41tKFlQcQqQlEMu0M=;\n\tb=MZ9fam+Ozfed792Nxt18fW0KyayA5W7EHIBIQNYT6C0Y5yMgsrxxJqbMQl+2Bx+J0s\n\tgY3aY2qXc+jOAJSZBbrPbhtsRSR8rfVB172VoYA/KvOmrecYItLwKnjYyhaC+g7Pow2c\n\tTtfOJUpyzYEB349PB0vgFNSEltYzDrpLvf4a3nv1lYyjRhptV/FEx9zCOCx8XQjMxIQe\n\tLEGpGWkWq15O8apgt2JYOgnPuuymdAN3wLH4OPuHwNUtsiq0GyzmLCXH+uDMAR7/v7IM\n\t0aZIt1dUAmqHfGgordZbcDggLhvgJhwp+WKXyHU5WM6M/jghlgchQRRwwhfUA6NXSP3A\n\tCZDg==","X-Gm-Message-State":"AOAM5332E7aEkD0UJB5jP7BR3n5F9EgJ69N7iPZm0tBXR4yNd+FRWgRQ\n\tleDDQv9Uveek0fqrJfvq+KSh0O/nzEI/iw==","X-Google-Smtp-Source":"ABdhPJzm9wIfhdSwtW/PXbUlWj8e+fGRilbgHUAhqPsPLyU6eA+RciCRAdDynFYPHNkmHiHxBA0DnQ==","X-Received":"by 2002:a1c:1d8e:: with SMTP id\n\td136mr36956864wmd.52.1626084141450; \n\tMon, 12 Jul 2021 03:02:21 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 12 Jul 2021 11:02:09 +0100","Message-Id":"<20210712100209.447893-9-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210712100209.447893-1-naush@raspberrypi.com>","References":"<20210712100209.447893-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 8/8] ipa: raspberrypi: Make variable\n\tnames consistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"s/DefaultAnalogueGain/defaultAnalogueGain/\ns/DefaultExposureTime/defaultExposureTime/\n\nChange these for consistency with the other static const variables.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 8fb98a49da63..1dd7fd68c3e9 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n using utils::Duration;\n \n /* Configure the sensor with these values initially. */\n-constexpr double DefaultAnalogueGain = 1.0;\n-constexpr Duration DefaultExposureTime = 20.0ms;\n+constexpr double defaultAnalogueGain = 1.0;\n+constexpr Duration defaultExposureTime = 20.0ms;\n constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n constexpr Duration defaultMaxFrameDuration = 250.0s;\n \n@@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n \t\t/* Supply initial values for gain and exposure. */\n \t\tControlList ctrls(sensorCtrls_);\n \t\tAgcStatus agcStatus;\n-\t\tagcStatus.shutter_time = DefaultExposureTime;\n-\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n+\t\tagcStatus.shutter_time = defaultExposureTime;\n+\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n \t\tapplyAGC(&agcStatus, ctrls);\n \n \t\tASSERT(controls);\n","prefixes":["libcamera-devel","v7","8/8"]}