{"id":12902,"url":"https://patchwork.libcamera.org/api/patches/12902/?format=json","web_url":"https://patchwork.libcamera.org/patch/12902/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210712100209.447893-2-naush@raspberrypi.com>","date":"2021-07-12T10:02:02","name":"[libcamera-devel,v7,1/8] ipa: raspberrypi: Make device_status.h C++ only header, and update comments","commit_ref":"ace5e21feba28cf43461375312f09c29230df370","pull_url":null,"state":"accepted","archived":false,"hash":"9fc4c198c499d9ada202e2973a56da03a2b14301","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/12902/mbox/","series":[{"id":2227,"url":"https://patchwork.libcamera.org/api/series/2227/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2227","date":"2021-07-12T10:02:01","name":"ipa: raspberrypi: Allow long exposure modes for imx477.","version":7,"mbox":"https://patchwork.libcamera.org/series/2227/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/12902/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/12902/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F9B8C3224\n\tfor ;\n\tMon, 12 Jul 2021 10:02:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9AC986852C;\n\tMon, 12 Jul 2021 12:02:18 +0200 (CEST)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C36168521\n\tfor ;\n\tMon, 12 Jul 2021 12:02:16 +0200 (CEST)","by mail-wr1-x433.google.com with SMTP id v5so24795815wrt.3\n\tfor ;\n\tMon, 12 Jul 2021 03:02:16 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:3395:5e50:10bb:f8fd])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm14249941wrs.51.2021.07.12.03.02.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 12 Jul 2021 03:02:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Hd7M+Cel\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IF2nPnuOcRtGtByOSMQln8DsOJyZiq6YxqgDrJr80Sw=;\n\tb=Hd7M+Cel46Y/Z9W9VMlzCNi7R/MwWz3EbWy5c0ssJJtSNzWKvTzngiXLNsx+PhuOI6\n\tZcLf74B8LKDDNmolYfXh9v9fdkhGcpfPirs08bmiOnzw8CsBjHNwqjYUv61JsRBapbja\n\tkme+axAXQlD16pincDF1TNsBwkuNE8t65vEikXKy5Cb/VrRiWqr2cZQ4CvzpVEMo69Zk\n\tMhTdozFwT4fwV9j34A6InAn1DXouL9pvAPOfwc8yAdIAwVxAVf3uasK06+HB1xyna3B1\n\tbOREUvWxYdYAPXLOFGCgjNkEAyFBCa6kuuSDFWRihcspx1IQJtCK91hcnj9jrjMvbjXc\n\tsvig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=IF2nPnuOcRtGtByOSMQln8DsOJyZiq6YxqgDrJr80Sw=;\n\tb=a4amdq+sd/OOPGKnJVVnzX1cPlE8r/3wKCBcfO44D20WnloJtl/P1VnRQ8v00Il3l2\n\twrG+JS6fEH4o9ZfiI84sYccMS8tjUW/5sdsNzuKED1ntYVbCYE1gsQ39rJR+MrhhGDXx\n\tw2o0dUlPzRP0oxnOXPK3XpUjcZHVLO1632c60J2duXXkE/3PNORYNMl2Xai6SFLjUkJZ\n\tmk2ineyldOH55cqilgm2I8Gv01qMytAgsgtS+23g6G5PWx6W5ojtUxOQiZkRzlfdOrH/\n\t7cMF/s2Fc+aCv2mj9ewO8xr/bOU0TE3G+uW7I6BYvCRZ8HGclGkxm4XL88DaoA/vaR9C\n\tDKYQ==","X-Gm-Message-State":"AOAM532aGCC5OyKywxDX25VtlTzaxbv/RA1OLDIpXf+1AZz8d1elNL0a\n\taSNK6TEuTEBjqZdLmqzlA6hnzBi4u2CAyQ==","X-Google-Smtp-Source":"ABdhPJxh2ABBDCDdkI5ap7CL/OAW5BBPCW/ZqgaN1WtKlZp0lJrXwAEiOFI16OEKqvq84yDlux3PNA==","X-Received":"by 2002:adf:f907:: with SMTP id\n\tb7mr57650785wrr.357.1626084135872; \n\tMon, 12 Jul 2021 03:02:15 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 12 Jul 2021 11:02:02 +0100","Message-Id":"<20210712100209.447893-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210712100209.447893-1-naush@raspberrypi.com>","References":"<20210712100209.447893-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 1/8] ipa: raspberrypi: Make\n\tdevice_status.h C++ only header, and update comments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This header file is no longer C compatible, so remove the extern \"C\"\ndeclaration.\n\nReplace C++ style comments with C style based on libcamera guidelines.\n\nThere are no functional changes in this commit.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Kieran Bingham \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n .../raspberrypi/controller/device_status.h | 24 +++++++------------\n 1 file changed, 9 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/device_status.h b/src/ipa/raspberrypi/controller/device_status.h\nindex f74235248b12..733378dbfa27 100644\n--- a/src/ipa/raspberrypi/controller/device_status.h\n+++ b/src/ipa/raspberrypi/controller/device_status.h\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-2-Clause */\n /*\n- * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n+ * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n *\n * device_status.h - device (image sensor) status\n */\n@@ -8,25 +8,19 @@\n \n #include \n \n-// Definition of \"device metadata\" which stores things like shutter time and\n-// analogue gain that downstream control algorithms will want to know.\n-\n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n+/*\n+ * Definition of \"device metadata\" which stores things like shutter time and\n+ * analogue gain that downstream control algorithms will want to know.\n+ */\n \n struct DeviceStatus {\n-\t// time shutter is open\n+\t/* time shutter is open */\n \tlibcamera::utils::Duration shutter_speed;\n \tdouble analogue_gain;\n-\t// 1.0/distance-in-metres, or 0 if unknown\n+\t/* 1.0/distance-in-metres, or 0 if unknown */\n \tdouble lens_position;\n-\t// 1/f so that brightness quadruples when this doubles, or 0 if unknown\n+\t/* 1/f so that brightness quadruples when this doubles, or 0 if unknown */\n \tdouble aperture;\n-\t// proportional to brightness with 0 = no flash, 1 = maximum flash\n+\t/* proportional to brightness with 0 = no flash, 1 = maximum flash */\n \tdouble flash_intensity;\n };\n-\n-#ifdef __cplusplus\n-}\n-#endif\n","prefixes":["libcamera-devel","v7","1/8"]}