[{"id":18093,"web_url":"https://patchwork.libcamera.org/comment/18093/","msgid":"<7dfe302c-120f-221c-80b0-447483fe01da@ideasonboard.com>","date":"2021-07-12T07:47:53","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipa_manager: Fix IPA\n\tmodule min/max version check","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/07/2021 00:15, Laurent Pinchart wrote:\n> The IPAManager::createIPA() function has its minVersion and maxVersion\n> parameters inverted. This doesn't cause any issue at the moment as both\n> the minimum and maximum version are set to 1 by all callers, but it's\n> still a bug. Fix it.\n\n\nCertainly seems more logical to have min,max, rather than max,min!\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/ipa_manager.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> index 34224e330da7..42201839901b 100644\n> --- a/include/libcamera/internal/ipa_manager.h\n> +++ b/include/libcamera/internal/ipa_manager.h\n> @@ -31,8 +31,8 @@ public:\n> \n> \ttemplate\n> \tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t uint32_t maxVersion,\n> -\t\t\t\t\t uint32_t minVersion)\n> +\t\t\t\t\t uint32_t minVersion,\n> +\t\t\t\t\t uint32_t maxVersion)\n> \t{\n> \t\tIPAModule *m = nullptr;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FD66BD794\n\tfor ;\n\tMon, 12 Jul 2021 07:47:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A30768524;\n\tMon, 12 Jul 2021 09:47:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EDB368506\n\tfor ;\n\tMon, 12 Jul 2021 09:47:56 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A5F4CC;\n\tMon, 12 Jul 2021 09:47:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f7OPex6j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626076075;\n\tbh=l8Lt5y88qdM2nXJT0aEqFX14bMcMZ5KRVMuFmFm8dPs=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=f7OPex6jDFk6oYDvQ9Iki368+Tqe8QXi9k7D1N5NebL/Ei80YN9Wyw8IIdRFxE/oq\n\tyLdKvKT/sS8J4Iy1F3NGwkVGB/2XhwIwbcz2gfq99/S6PMHgkpRHDXKdWAYjfiRUvO\n\t3CMGEpnZiBaNHkgdwTJ3EX3LxqS2MKxVKTdso8Ck=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210711231547.19664-1-laurent.pinchart@ideasonboard.com>\n\t<20210711231547.19664-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<7dfe302c-120f-221c-80b0-447483fe01da@ideasonboard.com>","Date":"Mon, 12 Jul 2021 08:47:53 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210711231547.19664-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipa_manager: Fix IPA\n\tmodule min/max version check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":18219,"web_url":"https://patchwork.libcamera.org/comment/18219/","msgid":"<20210719031506.GG2395@pyrite.rasen.tech>","date":"2021-07-19T03:15:06","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipa_manager: Fix IPA\n\tmodule min/max version check","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Jul 12, 2021 at 02:15:45AM +0300, Laurent Pinchart wrote:\n> The IPAManager::createIPA() function has its minVersion and maxVersion\n> parameters inverted. This doesn't cause any issue at the moment as both\n> the minimum and maximum version are set to 1 by all callers, but it's\n> still a bug. Fix it.\n\nHuh, idk why it was inverted in the first place :/\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/ipa_manager.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> index 34224e330da7..42201839901b 100644\n> --- a/include/libcamera/internal/ipa_manager.h\n> +++ b/include/libcamera/internal/ipa_manager.h\n> @@ -31,8 +31,8 @@ public:\n> \n> \ttemplate\n> \tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> -\t\t\t\t\t uint32_t maxVersion,\n> -\t\t\t\t\t uint32_t minVersion)\n> +\t\t\t\t\t uint32_t minVersion,\n> +\t\t\t\t\t uint32_t maxVersion)\n> \t{\n> \t\tIPAModule *m = nullptr;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3BCFC322B\n\tfor ;\n\tMon, 19 Jul 2021 03:15:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1167F6853A;\n\tMon, 19 Jul 2021 05:15:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F14E160278\n\tfor ;\n\tMon, 19 Jul 2021 05:15:14 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 530BD465;\n\tMon, 19 Jul 2021 05:15:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nPwMP90d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626664514;\n\tbh=g0OQMqto3jtwHMXmpVSaK40PDSorWe2D3oo830QO6pE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nPwMP90dw2NjeWhdQPGReep9Wn952PSmarasVNumHEEdD1NNBPrRCiOL4qyWc0TxC\n\tJIEPIABoScBoXlaxlKOgJjtg24gyJmCWYJSTKjw9DGjaPOt/PoO6gUfraKNd6vgX9D\n\tsOBPP54MLvCy7lRQmMmReultKWQW4WaOkpfyOMpQ=","Date":"Mon, 19 Jul 2021 12:15:06 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210719031506.GG2395@pyrite.rasen.tech>","References":"<20210711231547.19664-1-laurent.pinchart@ideasonboard.com>\n\t<20210711231547.19664-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210711231547.19664-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: ipa_manager: Fix IPA\n\tmodule min/max version check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]