[{"id":18070,"web_url":"https://patchwork.libcamera.org/comment/18070/","msgid":"<20210709162538.kg6why3zh2rrrep7@uno.localdomain>","date":"2021-07-09T16:25:38","subject":"Re: [libcamera-devel] [PATCH v6 8/8] ipa: raspberrypi: Make\n\tvariable names consistent","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Naush,\n\nOn Fri, Jul 09, 2021 at 03:58:25PM +0100, Naushir Patuck wrote:\n> s/DefaultAnalogueGain/defaultAnalogueGain/\n> s/DefaultExposureTime/defaultExposureTime/\n>\n> Change these for consistency with the other static const variables.\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 8fb98a49da63..1dd7fd68c3e9 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;\n> using utils::Duration;\n>\n> /* Configure the sensor with these values initially. */\n> -constexpr double DefaultAnalogueGain = 1.0;\n> -constexpr Duration DefaultExposureTime = 20.0ms;\n> +constexpr double defaultAnalogueGain = 1.0;\n> +constexpr Duration defaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> constexpr Duration defaultMaxFrameDuration = 250.0s;\n>\n> @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,\n> \t\t/* Supply initial values for gain and exposure. */\n> \t\tControlList ctrls(sensorCtrls_);\n> \t\tAgcStatus agcStatus;\n> -\t\tagcStatus.shutter_time = DefaultExposureTime;\n> -\t\tagcStatus.analogue_gain = DefaultAnalogueGain;\n> +\t\tagcStatus.shutter_time = defaultExposureTime;\n> +\t\tagcStatus.analogue_gain = defaultAnalogueGain;\n> \t\tapplyAGC(&agcStatus, ctrls);\n>\n> \t\tASSERT(controls);\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6F94BD794\n\tfor ;\n\tFri, 9 Jul 2021 16:24:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4332684E7;\n\tFri, 9 Jul 2021 18:24:51 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58105605AC\n\tfor ;\n\tFri, 9 Jul 2021 18:24:50 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id EC0CF200008;\n\tFri, 9 Jul 2021 16:24:49 +0000 (UTC)"],"Date":"Fri, 9 Jul 2021 18:25:38 +0200","From":"Jacopo Mondi ","To":"Naushir Patuck ","Message-ID":"<20210709162538.kg6why3zh2rrrep7@uno.localdomain>","References":"<20210709145825.2943443-1-naush@raspberrypi.com>\n\t<20210709145825.2943443-9-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210709145825.2943443-9-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v6 8/8] ipa: raspberrypi: Make\n\tvariable names consistent","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]