[{"id":18069,"web_url":"https://patchwork.libcamera.org/comment/18069/","msgid":"<20210709162507.lsudi27u3bnskher@uno.localdomain>","date":"2021-07-09T16:25:07","subject":"Re: [libcamera-devel] [PATCH v6 7/8] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Naush\n\nOn Fri, Jul 09, 2021 at 03:58:24PM +0100, Naushir Patuck wrote:\n> With the recent change to allow long exposures on the imx477, the existing 100s\n> limit was not adequate.\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index db103a885b7a..8fb98a49da63 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -62,7 +62,7 @@ using utils::Duration;\n> constexpr double DefaultAnalogueGain = 1.0;\n> constexpr Duration DefaultExposureTime = 20.0ms;\n> constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;\n> -constexpr Duration defaultMaxFrameDuration = 100.0s;\n> +constexpr Duration defaultMaxFrameDuration = 250.0s;\n>\n> /*\n> * Determine the minimum allowable inter-frame duration to run the controller\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB663BD794\n\tfor ;\n\tFri, 9 Jul 2021 16:24:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B451684E7;\n\tFri, 9 Jul 2021 18:24:20 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D65D9605AC\n\tfor ;\n\tFri, 9 Jul 2021 18:24:18 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7087440002;\n\tFri, 9 Jul 2021 16:24:18 +0000 (UTC)"],"Date":"Fri, 9 Jul 2021 18:25:07 +0200","From":"Jacopo Mondi ","To":"Naushir Patuck ","Message-ID":"<20210709162507.lsudi27u3bnskher@uno.localdomain>","References":"<20210709145825.2943443-1-naush@raspberrypi.com>\n\t<20210709145825.2943443-8-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210709145825.2943443-8-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v6 7/8] ipa: raspberrypi: Increase the\n\tdefault max frame duration to 250s","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]